From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6815D3858439 for ; Tue, 19 Jul 2022 12:52:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6815D3858439 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-439-g66gSpjuO6eqHglVEnQhlg-1; Tue, 19 Jul 2022 08:52:09 -0400 X-MC-Unique: g66gSpjuO6eqHglVEnQhlg-1 Received: by mail-wm1-f69.google.com with SMTP id n21-20020a7bc5d5000000b003a2ff4d7a9bso5400601wmk.9 for ; Tue, 19 Jul 2022 05:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=MFvjSzHiPd57jbIRJMQJ6aBWZLTgPECKCS9oKPDAKNU=; b=k9GU1E8KsgiXOxPlk/FAyzKYfAB55PxaizULG4qg6LIHz3u/dQWUbWcmd8gRZHboVW F8CP0NWZUjKnhhdVJZYSfeTNVYw+KjEQnWXxf7Awp2pXsU6VO2w8n9Q6xo+cG7ndRT7N EITbQNLPifivSOz9kdGbfV34cYoXYo4Agfmtx8AyxP9ThtNuo3+OZLrbE2Lsi9UvDWAY ZEV5jcCRUub8NwPvux33TrXKhq0xWTOR1FSxTaYEkqOogCyUn2RhmeeJm/mMKeos+uG7 94EVAu6/dZpFesSyMZ3coi8J99cXL/Sbg6Q83gpBp4F0xTnd90OzELtMlMa3TnjH8yrP 8TuQ== X-Gm-Message-State: AJIora+UmuzSfNYjIwrAxZGWRRpIVVB0bJSfFTfcDJOK+LCvklSFvcdT l9pA80F4H3ucpKY63Pw1CnraJo971wC5U5OJ8XBOJVjq7l/1muQyGDJQGeCMiBa3pZB8xoyJztG 8XNiDpqeWMkoe8WM/Bl/XB+r55RxgBr4T31kyXFKO7R0BdO+UQ1oynWT2jmXvsue8+XJABw== X-Received: by 2002:a05:600c:6009:b0:3a3:1506:f60f with SMTP id az9-20020a05600c600900b003a31506f60fmr13483361wmb.144.1658235128588; Tue, 19 Jul 2022 05:52:08 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s1s+aFQlrmLIUaOv1R3mLuXL606UCatvUWKEx0XslfBW382+I9MvSSECCbY0bCsBMPXU5xYQ== X-Received: by 2002:a05:600c:6009:b0:3a3:1506:f60f with SMTP id az9-20020a05600c600900b003a31506f60fmr13483339wmb.144.1658235128211; Tue, 19 Jul 2022 05:52:08 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id q5-20020a1c4305000000b003a2d6c623f3sm21773247wma.19.2022.07.19.05.52.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 05:52:07 -0700 (PDT) From: Andrew Burgess To: Andrew Burgess via Binutils , binutils@sourceware.org Subject: Re: [PATCHv4 0/2] AArch64 libopcodes styling In-Reply-To: References: Date: Tue, 19 Jul 2022 13:52:06 +0100 Message-ID: <87fsixqn7t.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 12:52:12 -0000 Andrew Burgess via Binutils writes: > Changed since v3: > > - Patch #1 is unchanged, > > - Removed debug code that was accidentally left in patch #2, > > - Patch #2 now sets the disassemble_info::created_styled_output flag > correctly in disassembler.c. > > Changes since v2: > > - Patch #1 is unchanged, > > - Patch #2, now with more OBSTACK! This patch is pretty much a > complete rewrite from the gound up based on Richard's feedback. > The new iteration makes use of obstacks (in aarch64-dis.c and > tc-aarch64.c) to format each chunk of disassembler output. These > chunks are then combined in aarch64-opc.c as required. > > Changes since v1: > > - Original patch #1 has been merged, > > - New patch #1 adds a dis_style_sub_mnemonic style and updates > objdump to handle this style, > > - Patch #2 has been updated to make use of the new style. Ping! Thanks, Andrew