From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id CBFFF3858C78 for ; Tue, 15 Mar 2022 20:10:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBFFF3858C78 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22FISunQ020016; Tue, 15 Mar 2022 20:10:55 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80] (may be forged)) by mx0b-00069f02.pphosted.com with ESMTP id 3et60rc5ww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Mar 2022 20:10:55 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22FKAsrm196164; Tue, 15 Mar 2022 20:10:54 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107]) by userp3030.oracle.com with ESMTP id 3et65ppqcv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Mar 2022 20:10:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IHPpZEY2gMQDKE4A2rWqrwsMQoH3PY96pJTPIuOkQABquqUXxM8g5cZO832OcD5WKGKs/6f99Fh6R5NX90D6WsjlMew4BYoVxOXSTScloVChd+DNsew3b1mCrikE8+EYU9YuH/PhAgmguYgitSNj4ZTj2XoKddvc9/cJG4y7XZVrRo1kFzShxKC4g8VgyVFkrmiTj4ioH6eP9vJiwrSr4Nawa1Bx4zqdVJSlSzmmiSihrBCx57TjnaqxHU0037ScvMKKltYM3L/ISwq6SJGPpD/olQzVrg9hBf47b4/QGH5Tf2SoqZ3a6A26798rcyVyJWYhjdHigJUHDwBZB2PuHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKNW48s5iRocgQHB+F7w1O5kCdnnLn/nr96iKbXc4xY=; b=a7oSjRJS55lV5ZAMnJcR5hXDCpP+aGWH8skMGKWwBt6Ie712R2suAVhThZZ8VRTaDhsTXu3WFOfP1lhoceb+Q0CLsR7cvIkLvvsxm0f8r00XEfMjcj+h2wxoJrjBejEbNSPEObJZrHJv5ZHFwuHrrCKjPDkSxJaBVABEgn5S7lREm/cTOaLZtRZVvovUwp/B+jzeoDfB3sPedQhAmuWtZhMNXpduPka+rsqkOwE49JL/jshJjnCx3AgnDnT+DfKvpv0aZQPpH6Oc8LrjUtMhXMAwVmhBijTrbRiW8ShmOa4OxYQr++iGH19uDuPVgwHNnFPs6sgSKHuAQoAOylqOGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by DS7PR10MB4992.namprd10.prod.outlook.com (2603:10b6:5:3a1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Tue, 15 Mar 2022 20:10:51 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::acaf:630:dca7:5bff]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::acaf:630:dca7:5bff%7]) with mapi id 15.20.5061.029; Tue, 15 Mar 2022 20:10:51 +0000 From: "Jose E. Marchesi" To: "H.J. Lu via Binutils" Subject: Re: [PATCH 1/3] gprofng: Define ATTRIBUTE_FALLTHROUGH References: <20220315162204.2659495-1-hjl.tools@gmail.com> <20220315162204.2659495-2-hjl.tools@gmail.com> Date: Tue, 15 Mar 2022 21:10:43 +0100 In-Reply-To: <20220315162204.2659495-2-hjl.tools@gmail.com> (H. J. Lu via Binutils's message of "Tue, 15 Mar 2022 09:22:02 -0700") Message-ID: <87fsnjj7ss.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0160.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::21) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8109b412-e27e-4a15-4b93-08da06bfe71a X-MS-TrafficTypeDiagnostic: DS7PR10MB4992:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ikndcnbknjwZMHzeNz/vXx+p29KsercucsmvjpOpQpDxGfC8eOd+eWFUPaw1NsjqoIe19MycnN6oZG0EyWCS1TbA0JWGOYld1SSv1vegBmCMw9KcVLYl7marEwLFbKsNltSKqH8npFMsXTTRA47fAWEwCV25UKexXKUeriDXTPCWALedFWgZYEMs8FLuVeSqsePfFBd+Yjsc1PNHwGJZorsLlLlzGr7CgAoivNb052hNT69oPjecdzepWgrXEbVNfFr5RzbuqVTSnpHudqz30vw720ErN/kRbNLAidxcaGSbrR9Un0CMzTA81PImWtvdFC5qjzrtj70XVTHTqbiDB4GdGIjOoaXEsnoSYQ4nbiYaJ2VsUdXufPNXuTx18H4FPGecQ8wkq9ftKiFnNbRmqMIX/yktqe7mBwtfKJHWy38l5rPYmBtLe84gD8T/02mixclAmBkvlv3LRkMH4r13bMqvkCIGjmFgapW6cENcF1P6EiS2kBrEKjLGGSV5PEMZUWwHB4cgPDsMLGes1xUIvLDndkKhllWtO5zXwoSXCYTLjt8cwkewu6fxGQjP567GBRRvFaHgRXCoXx00RZjPuvZyKmsO15R4/r8zki9C80vb02RPT6Q8sPYfZElnr13aLGBPcxGxCcGtDOJSKBXs0ho2EStFHnX3awM3WIl3idY7+7tXQ6e1aOrLNDUcoJEhQZ/88kOi95foJVYIA283w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38350700002)(86362001)(316002)(6916009)(6486002)(5660300002)(38100700002)(2906002)(66946007)(8676002)(4326008)(66476007)(8936002)(66556008)(2616005)(83380400001)(36756003)(186003)(52116002)(6506007)(6512007)(6666004)(508600001)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NfL+MhI4rvLk8PwiKZ5xbesx9E6ChYamuuXuyAUl8bgLnIDq1j2BzyYDZuDb?= =?us-ascii?Q?mOXiGCigBSI1mVljCAcMTdwmXjCnmI8SDUMIzPsRLcuefaP/a4XAHt4RdUK7?= =?us-ascii?Q?F7O2xrCxCJTAuWLW8/kIuO9+ylc213ULckvzKvfjDsXXMZfW+89wPJL+9eUq?= =?us-ascii?Q?aH4JxU1fzdvM2uwd9F2mQv32iAGkq6OhFI6UpZl0UZ/oyqdMPjXn6v7xBqBm?= =?us-ascii?Q?kSEAwinasZDV1P66gUG4mSLp8f4KiBy3/3tXaCgkRI6KXnCH2O+s7BSyYsrx?= =?us-ascii?Q?qVpqcLZEf8CPzHFGG7blU5nuP1y6AF9JH9OaC3OS3t1W/WYXk56lqtzTBrVs?= =?us-ascii?Q?51NcpvwcZYv/sgxhyYKRLQMbJhbDVmfziN46nOxE/NsJWVLi6t/ZKMXsXkJh?= =?us-ascii?Q?3FQfsbSnYmkdWuCfQqbNulLNNc9vTevOjJLq0/vBRF85vLYhrCwqbiTJVsuZ?= =?us-ascii?Q?PBL8cgXCUJUAwK0oP2HfYvOfe85w6shiuLdrh6DrIoycgHnUCpbr8fhf0fau?= =?us-ascii?Q?d73+WGEzu6zDJE6EbRfwA1o6PcRH3BozGjjJ+chO72IH1WJSMuxdmX5h2g3G?= =?us-ascii?Q?sWetbvZziygSYadCYU5MaxnwGt2wFww+5l2mtRHes9myqXwxpaHwWCRZ1Y9V?= =?us-ascii?Q?e4hX09sWwDU0UJJ/ltvEQs8ql4njkT5IT7GUAaQGdbjskagTttS7e6xsmso0?= =?us-ascii?Q?Lza7p7oRsLBk3FcY0Ct/Ig3KNSpnn+mnRYHtiGK7tLAVgYGsRnXrYcYQU3yL?= =?us-ascii?Q?yFMyLp7GgC57f6c5uAfrcDDXeUo7Dn+Tj9zFrvkqB9KcixtbZetmroGeDYAI?= =?us-ascii?Q?twNai6byRbSbCk0TzoCEvzkq5x7HLRfBUobO44zFkMNGk/0SJuIXKw8GryhL?= =?us-ascii?Q?7ax2QkA+ETxk1Qr7HVZeLrMf8ZdzvubmyVVx+uPeZze2jFr7ckc+Fzdfldrb?= =?us-ascii?Q?zTywwVMnnqdVdyIhNJsrpSzyVBE+UxKrc7TsuUPN+J1ThdebPsjieckROh9a?= =?us-ascii?Q?prFvUIXfZFj/tFUqvGUVmxPtL9S+2MCm7q7CurWbPaZNc3nDkExJpiZlAils?= =?us-ascii?Q?dRoXQhSSTSZTfkQYfI5qn3RYcJ5dCNi3OL2ErzvIooukNm/iJcld/gltwwL3?= =?us-ascii?Q?geMKIRY2dQH8CaHNFv9G/fpC66yG/yhV2xmn9lWp96GgR9CM8i/Ev3tu0h7+?= =?us-ascii?Q?xH16iLwlMdoDWrY61u3TelbrfeijwkSeQtI4u2gw0WpfoQda784Dr29mOjLX?= =?us-ascii?Q?DndgcCUlQLckgig9VtovLM42tUPFv2jb/ZWh8VgZA7SvKm/2mJ/kL30qP7x7?= =?us-ascii?Q?VgJTJMAjUSBFgsKwdHw4OUKpQFSeazQBdAXdNHcva7uy2Xjny9KV/SAkvkBq?= =?us-ascii?Q?MsIfL5NTXXVmzjds+MYH1kmdbkQXoHIVx3MB9hx37OLXmrASOpQI5fwTjsOF?= =?us-ascii?Q?1BuhLmTWiQWGjoLOotdzKj+5rYs4funvjlSr46jpnpdIAynVmXEJEw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8109b412-e27e-4a15-4b93-08da06bfe71a X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 20:10:51.5876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RBkz50xnDucWxs1j+GF4txmbC+Q6i6QrQxXaZhiGbAoRFVXVztyOUEWffREtvn0Gu2vP/Gj2kcSSKfoR9n1dLZQBaEo+eCAjUl5SxkSRHUk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4992 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10287 signatures=693139 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203150118 X-Proofpoint-GUID: psKmYfSb5Qwe7IM7w0WP-bsGgJ3xM1pc X-Proofpoint-ORIG-GUID: psKmYfSb5Qwe7IM7w0WP-bsGgJ3xM1pc X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 20:10:58 -0000 > Define ATTRIBUTE_FALLTHROUGH to __attribute__ ((fallthrough)) only for > GCC 7 or above. > > PR gprof/28969 > * common/gp-defs.h (ATTRIBUTE_FALLTHROUGH): New. > * src/gp-collect-app.cc (collect::check_args): Replace > __attribute__ ((fallthrough)) with ATTRIBUTE_FALLTHROUGH. Oh sorry HJ I just pushed the patch below as obvious because I couldn't build gprofng with GCC 6. Didnt see your patch here which is better. commit 6aa03e9c1769c8d925f4d23d72af93483bfd31f3 Author: Jose E. Marchesi Date: Tue Mar 15 21:04:57 2022 +0100 gprofng: avoid using `fallthrough' attributes gprofng didn't build with gcc 6.3 due to the usage of __attribute__ ((fallthrough)). This patch uses /* FALLTHROUGH */ instead. 2022-03-15 Jose E. Marchesi * gprofng/src/gp-collect-app.cc (collect::check_args): Use fallthrough comment instead of attribute. diff --git a/ChangeLog b/ChangeLog index 73b6085d6ef..dfe468c0af4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2022-03-15 Jose E. Marchesi + + * gprofng/src/gp-collect-app.cc (collect::check_args): Use + fallthrough comment instead of attribute. + 2022-03-11 Vladimir Mezentsev * Makefile.def: Add gprofng module. diff --git a/gprofng/src/gp-collect-app.cc b/gprofng/src/gp-collect-app.cc index afaae70bc2b..a40cf8fb9be 100644 --- a/gprofng/src/gp-collect-app.cc +++ b/gprofng/src/gp-collect-app.cc @@ -848,7 +848,7 @@ collect::check_args (int argc, char *argv[]) } case 'O': overwriteExp = true; - __attribute__ ((fallthrough)); + /* FALLTHROUGH */ case 'o': if (precheck == 1) {