Offering enhancement to 'strings'

Offering enhancement to 'strings'

[Ralf Brown]

I've added support for UTF-8 and EUC encodings to the strings(1) code,
and would like to contribute the changes back to the FSF. I'm willing
to sign a copyright assignment.

I saved multiple checkpoints during the update, so I can offer a
series of incremental patches starting with the CVS version as of the
morning of 2011-07-25:

  Patch 1: Simple refactoring to move the actual reading of bytes from
get_char() into its own function get_byte(), as we will be using this
code multiple times.

  Patch 2: Move the decision of whether a character is a desired
graphical character into get_char() and adjust print_strings()
accordingly.

  Patch 3: Enhance the character-handling code in print_strings() to
deal with multi-byte characters.

  Patch 4: Add UTF-8 processing to get_char() and add new 'u' encoding
type in main().

  Patch 5: Add baseline EUC processing to get_char() and add new 'e'
encoding type in main().

I look forward to hearing from you.

   Ralf Brown

Re: Offering enhancement to 'strings'

[Richard Sandiford]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Ralf Brown <ralf.brown@gmail.com> writes:
> I've added support for UTF-8 and EUC encodings to the strings(1) code,
> and would like to contribute the changes back to the FSF. I'm willing
> to sign a copyright assignment.

Sounds like a really useful extension, thanks.  The patch split
looks good too.

Like you say, a copyright assignment would be needed for a contribution
of this size.  I've attached the form, in case you don't already have
a copy.

Thanks,
Richard


[-- Attachment #2: request-assign.future --]
[-- Type: application/octet-stream, Size: 971 bytes --]

Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]


[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]





[Which files have you changed so far, and which new files have you written
so far?]