* PATCH: Don't use empy files in ld-elfvers
[not found] ` <hod6iwy26e.fsf@byrd.suse.de>
@ 2003-05-06 15:41 ` H. J. Lu
0 siblings, 0 replies; 6+ messages in thread
From: H. J. Lu @ 2003-05-06 15:41 UTC (permalink / raw)
To: Andreas Jaeger
Cc: binutils, gcc, GNU C Library, Kenneth Albanowski, Mat Hostetter,
Warner Losh, linux-mips, Ron Guilmette, Ralf Baechle,
Linas Vepstas, Leonard Zubkoff, Steven J. Hill, linux-gcc
[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]
On Tue, May 06, 2003 at 09:17:13AM +0200, Andreas Jaeger wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
>
> > This is the beta release of binutils 2.14.90.0.1 for Linux, which is
> > based on binutils 2003 0505 in CVS on sourecs.redhat.com plus various
> > changes. It is purely for Linux.
> >
> > The Linux/mips support is added. You have to use
> >
> > # rpm --target=[mips|mipsel] -ta binutils-xx.xx.xx.xx.xx.tar.gz
> >
> > to build it. Or you can read mips/README in the source tree to apply
> > the mips patches and build it by hand.
> >
> > Please report any bugs related to binutils 2.14.90.0.1 to hjl@lucon.org.
>
> HJ,
>
> the package is broken, the testsuite fails since the following
> (empty!) files from the ld/testsuite are not part of the tarball:
>
>
> ./testsuite/ld-elfvers/vers25b.c
> ./testsuite/ld-elfvers/vers25b.dsym
> ./testsuite/ld-elfvers/vers25b.ver
> ./testsuite/ld-elfvers/vers26b.dsym
> ./testsuite/ld-elfvers/vers26b.ver
> ./testsuite/ld-elfvers/vers27b.dsym
> ./testsuite/ld-elfvers/vers27b.ver
> ./testsuite/ld-elfvers/vers27c.c
> ./testsuite/ld-elfvers/vers27c.dsym
> ./testsuite/ld-elfvers/vers27c.ver
>
It is not such a good idea to use empty files in CVS. I will check in
this patch. Please apply binutils-2.14.90.0.1-empty-test.patch to the
Linux binutils 2.14.90.0.1.
H.J.
[-- Attachment #2: binutils-2.14.90.0.1-empty-test.patch --]
[-- Type: text/plain, Size: 3415 bytes --]
2003-05-06 H.J. Lu <hjl@gnu.org>
* ld-elfvers/vers.exp (objdump_versionstuff): Support comment
in expected version file.
* ld-elfvers/vers25b.c: Add a line of comment.
* ld-elfvers/vers25b.dsym: Likwise.
* ld-elfvers/vers25b.ver: Likwise.
* ld-elfvers/vers26b.dsym: Likwise.
* ld-elfvers/vers26b.ver: Likwise.
* ld-elfvers/vers27b.dsym: Likwise.
* ld-elfvers/vers27b.ver: Likwise.
* ld-elfvers/vers27c.c: Likwise.
* ld-elfvers/vers27c.dsym: Likwise.
* ld-elfvers/vers27c.ver: Likwise.
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers.exp.empty 2003-05-05 14:46:50.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers.exp 2003-05-06 08:32:18.000000000 -0700
@@ -457,7 +457,11 @@ proc objdump_versionstuff { objdump obje
set f1 [open $tmpdir/objdump.out r]
set f2 [open $expectfile r]
- gets $f2 l2
+ while { [gets $f2 l2] != -1 } {
+ if { ![regexp "^#.*$" $l2] } then {
+ break
+ }
+ }
while { [gets $f1 l1] != -1 } {
if { [string match $l2 $l1] } then {
if { [gets $f2 l2] == -1 } then {
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.c.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.c 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+/* Empty file */
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file.
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers25b.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers26b.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27b.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.c.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.c 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+/* Empty file */
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.dsym.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.dsym 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
--- binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.ver.empty 2003-05-06 08:32:18.000000000 -0700
+++ binutils-2.14.90.0.1/ld/testsuite/ld-elfvers/vers27c.ver 2003-05-06 08:32:18.000000000 -0700
@@ -0,0 +1 @@
+# Empty file
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: The Linux binutils 2.14.90.0.1 is released
[not found] <20030505223301.A28436@lucon.org>
[not found] ` <hod6iwy26e.fsf@byrd.suse.de>
@ 2003-05-09 7:24 ` Ben Elliston
1 sibling, 0 replies; 6+ messages in thread
From: Ben Elliston @ 2003-05-09 7:24 UTC (permalink / raw)
To: binutils
Hi HJ,
"H. J. Lu" <hjl@lucon.org> writes:
> This is the beta release of binutils 2.14.90.0.1 for Linux, which is
> based on binutils 2003 0505 in CVS on sourecs.redhat.com plus
> various changes. It is purely for Linux.
As I understand it, you started up your "HJ special" binutils around
the time that binutils development has slowed/stalled. It is now
actively maintained. I'm left wondering why it is necessary for you
to continue to maintain your own binutils releases. Can your changes
be folded into mainline binutils?
Ben
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: The Linux binutils 2.14.90.0.1 is released
2003-05-10 0:17 ` Ben Elliston
@ 2003-05-10 14:36 ` Thiemo Seufer
0 siblings, 0 replies; 6+ messages in thread
From: Thiemo Seufer @ 2003-05-10 14:36 UTC (permalink / raw)
To: binutils
Ben Elliston wrote:
> Jack Howarth <howarth@bromo.msbb.uc.edu> writes:
>
> > I think the rational of the HJ releases is provide a way to
> > rapidly release as many critical fixes as possible for use with
> > linux.
>
> Hmmm .. this sounds like something with a much greater sense of
> urgency than I would expect for binutils. I can understand that it
> makes sense when a new Linux kernel port and binutils are coming up at
> the same time,
New Features or just different usage are also a point to consider,
for the kernel as well as for userland.
> but for established platforms, I can't see the need.
The Linux development tree is probably never a "established platform".
And IMO it's very valuable for binutils to get a wider test audience
sooner than the release cycle suggests.
Thiemo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: The Linux binutils 2.14.90.0.1 is released
2003-05-09 13:04 Jack Howarth
2003-05-09 14:51 ` H. J. Lu
@ 2003-05-10 0:17 ` Ben Elliston
2003-05-10 14:36 ` Thiemo Seufer
1 sibling, 1 reply; 6+ messages in thread
From: Ben Elliston @ 2003-05-10 0:17 UTC (permalink / raw)
To: binutils
Jack Howarth <howarth@bromo.msbb.uc.edu> writes:
> I think the rational of the HJ releases is provide a way to
> rapidly release as many critical fixes as possible for use with
> linux.
Hmmm .. this sounds like something with a much greater sense of
urgency than I would expect for binutils. I can understand that it
makes sense when a new Linux kernel port and binutils are coming up at
the same time, but for established platforms, I can't see the need.
IHMO, there are better things to do with one's time than maintaining a
binutils fork.
Cheers, Ben
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: The Linux binutils 2.14.90.0.1 is released
2003-05-09 13:04 Jack Howarth
@ 2003-05-09 14:51 ` H. J. Lu
2003-05-10 0:17 ` Ben Elliston
1 sibling, 0 replies; 6+ messages in thread
From: H. J. Lu @ 2003-05-09 14:51 UTC (permalink / raw)
To: Jack Howarth; +Cc: binutils, bje
On Fri, May 09, 2003 at 09:04:46AM -0400, Jack Howarth wrote:
> Ben,
> I think the rational of the HJ releases is provide
> a way to rapidly release as many critical fixes as
> possible for use with linux. Those releases are
> focused on being bug-free on the linux platform
> (hence their hosting on ftp.kernel.org).
Thanks, Jack. That is well said. Also some Linux projects may need
certain new features in a released version of binutils. We can live
with regressions and breakages on non-linux platforms. But I don't
think the FSF binutils should/will make that kind of commitment.
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: The Linux binutils 2.14.90.0.1 is released
@ 2003-05-09 13:04 Jack Howarth
2003-05-09 14:51 ` H. J. Lu
2003-05-10 0:17 ` Ben Elliston
0 siblings, 2 replies; 6+ messages in thread
From: Jack Howarth @ 2003-05-09 13:04 UTC (permalink / raw)
To: binutils, bje
Ben,
I think the rational of the HJ releases is provide
a way to rapidly release as many critical fixes as
possible for use with linux. Those releases are
focused on being bug-free on the linux platform
(hence their hosting on ftp.kernel.org).
Jack
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-05-10 14:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20030505223301.A28436@lucon.org>
[not found] ` <hod6iwy26e.fsf@byrd.suse.de>
2003-05-06 15:41 ` PATCH: Don't use empy files in ld-elfvers H. J. Lu
2003-05-09 7:24 ` The Linux binutils 2.14.90.0.1 is released Ben Elliston
2003-05-09 13:04 Jack Howarth
2003-05-09 14:51 ` H. J. Lu
2003-05-10 0:17 ` Ben Elliston
2003-05-10 14:36 ` Thiemo Seufer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).