From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3FA813858016 for ; Wed, 14 Feb 2024 16:14:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FA813858016 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FA813858016 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707927292; cv=pass; b=ADSUAH7FSOE1dW0IbAiYhY1JvXQ25FQS9KZw0nimdG3w+quk8+l5kMNrfraMjrsXZDiJnCBLc59dcATsX1Fupj+bL0IKa+Rdi7oYByPGMNe5IT3NL4h10xAxYk4yS5XDJLo1jBl9itkVXW2UMn1exM6jELxXGvzUGtTwQWJ8omY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707927292; c=relaxed/simple; bh=bmR9kn5xMQaZnLiQ8XltMWyc9TCkbPTrNO+RBC+xZ1g=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=GXv/2lkClEf1zxG6GGjgoNWRgFFKQYbKRSCpFW3/PafVLMs8F/7fhhHmRD8XYk49UWlGaskuT9GIL2A6oJo47UZXXPSaDpHK6HCMa1J55M2Rg1Rko6YhPkqZiQzcW/YFGc6UfiKRf3uEtKSDWvcVLmUudcusIdc9HHSoInHBSxo= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41EGDqg3027794; Wed, 14 Feb 2024 16:14:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=9zTKRJX8BqRiXCN7P0/8xgalfdj/2cuwgzNXRUz5dcw=; b=Am+XODIIJ46XyF/a0MDyh2tk2hAiX+YO3UlVfJReP3/w7/QB/1HMXhxe1JwIfy2JdRUO CKuvOac3ZrDm62j9Ur0ZtqPjHDVTG/ezLuTglfMQvGHcW/v6r/00w+fc7zmtINzB/BQo JBOQwBmpbYjnaRKH1HqDCV20Nzz4+gzbFJdC8hMPeipVFgMvXhPKGKFG69QH0ZhNY4+P yDaQejgOfk5Al4KxoKoqpC3HsVB8Jb2vq4dl/8G60mQxkAQjafiEVgyw5tF9nAbCFLsn hsuv0IHNO9l1zDcz1WRcgNcEqG91gJHkUZHcAoAE9MjzkgAHLD4Z9ecWRhIGagCtMfq9 8w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w8ypm88mc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Feb 2024 16:14:48 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41EGBeFG014987; Wed, 14 Feb 2024 16:14:47 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2041.outbound.protection.outlook.com [104.47.73.41]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w5yk8vtfr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Feb 2024 16:14:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YHDoT1HJeppnbpm7/OmUzjXDvk7+9uUsyAQK4m9eeoYbcAfaVmrL8qVSkJUj6SFrB+yAdMJ+aGYCz8kZl4hK2fsWMCFwnSjP/yqmwM/Kr5mNcZEQmdR2n45MghCnMD0rDOwvX6J0fu7SHoHlWIrZ6gs41G9UVTDl8c4ngvxvcENlvYkjPIeq1fsAofu5fM3WBYbdYHGsQ8V9ClOoFZaS5Vec9ni8944gr0CdVzvKFDP5GZYjmpFGFvs1O6CaP7gJY4audFgft6OfnEiU3hOnxhLTkohdq3qcTIXr4bx4yp1tRQF/E1W1hBNMM3/DoC1RuuoPmqMS+H4DfyiT/+6IKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9zTKRJX8BqRiXCN7P0/8xgalfdj/2cuwgzNXRUz5dcw=; b=Y1jly2QlFBHzHrwtZ4kTj/x4bvWD8EG8bygMUxzoJnl3v1w4gqJ5truFdkPXcBJmvISjMh5xH501vNJ+RBnGssW54O67bSpjakH/cX14bFk8aUtIfy3bUC3okwJM1YH2EbZYqZaJV5wJNvE5RjCR0uAomaa6Rn6D5SmAUn8P6hc0qxn/l8/rHt9suBhXVXTX2kN1rRTemzbwsQ7YAXpqj/2E6+xuE6ErEuI16qv24DEfqDJiRWL4Td6Hl32wG+odI1UZDoLz9Kgz4asW/7Kk/qQAkE8IBJtuT/79X/i84Bm3Sqnif1X3MHV1J2tChsJP/odcxHoBGJVEKkWYy/VIJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9zTKRJX8BqRiXCN7P0/8xgalfdj/2cuwgzNXRUz5dcw=; b=cthGJazJzuDNUtAaC69mggB7OD74tskAsXiakdL4WJ2l9OW1i3RV/UIbwBqH08+TsUtXemRie79+GZjtSKi0HD43+gGS5bO2Vke3ySP7gox1ycPxawQwAa39VBv7YoyAHw3dKRZZiEjGRjiN7QUnwjwJ5HsszaYac3UnhYOCbIA= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by CO1PR10MB4737.namprd10.prod.outlook.com (2603:10b6:303:91::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25; Wed, 14 Feb 2024 16:14:45 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1%4]) with mapi id 15.20.7270.036; Wed, 14 Feb 2024 16:14:45 +0000 From: "Jose E. Marchesi" To: Will Hawkins Cc: Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 In-Reply-To: (Will Hawkins's message of "Wed, 14 Feb 2024 11:04:55 -0500") References: <20240212174209.620310-1-hawkinsw@obs.cr> <20240212174209.620310-2-hawkinsw@obs.cr> <82116e8c-390b-4389-8d04-744839785f2c@redhat.com> <87jzn7nwhe.fsf@oracle.com> Date: Wed, 14 Feb 2024 17:14:41 +0100 Message-ID: <87h6ibkopa.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0151.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::12) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|CO1PR10MB4737:EE_ X-MS-Office365-Filtering-Correlation-Id: 3dea2fec-29d7-410b-6d1c-08dc2d780f1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2dffKCQrzdXFIPFcn1MRI/ob1zfN/o8c7/aK6FujWcblL+I3CcRDeihS9ztWI/r6TP0LCgK6cqkw2FLoNQ5MRoQGUt9j5+OJeABuTuN79BCEPkO54aAsTD5666UFP8DbFL0737m/lVKjx6AbmhHtwTW9kuv19yMXOY0u0fqc3ef0J8hcXmfAHUHO1d2XCVQ9Dj1eJw9M5lPgnLeLMNd5R0bv9iEpIh8arXbaR6vlKwMrenJ96RVItJs75lB7boTfsjh7KcBjUxCpySqFh/ppNzibv4nL1uVCoZ/hIAglLmnmUHoEKdZzKsyelnfb7NLOOaaa09UcK4xGJqUQcEqOOr5mMi9jJABe0Rm3dgJQteVtvDxgZYwKKZVBkZzqDvh/w/HVF3eXQGwIWRxe7QSIt7UAglbtRW6gQZmJ8Y2msOOhgXBmwX7QVwZ/KHHZGQQEbmNvM9fDlPO7qhoCj68w2os80fOG5Gs3x6CwmhDSKSsTrhvaI+xElGY6DsJdZiXMerlIIcmpui2eRPXfr/UmfRyNlOttmA7s5ZPcrXF+9c7Y0+bvMSGWRJ0RoN2YKam X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(376002)(396003)(136003)(366004)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(8936002)(6512007)(4326008)(26005)(41300700001)(2616005)(66574015)(83380400001)(66946007)(66556008)(6506007)(53546011)(6916009)(6486002)(66476007)(8676002)(316002)(478600001)(6666004)(38100700002)(86362001)(36756003)(66899024)(2906002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cisxdUJWWmlkVms0YWNCbHg1OFhHWVBUb1pJYzZGYnhHMmRGSVEwNXl6ZTFa?= =?utf-8?B?amtRUUhzcW1TUldSWXNPZjVIdHNWNjRpdHM4R1FqQlVLSytSSjlVUVlKMUND?= =?utf-8?B?QlhtWE1hRmc0eHltdVZBa2VubHh4bjVVeDB3bk5DZVB2Z1FjNFNBSG9SN1da?= =?utf-8?B?M1VqNVlkSlZSaC82cmI1ZWpCRnY5ZEhPTGFGN3Z5VithYWc2bkdXZDBPYlVJ?= =?utf-8?B?eUJMTmZGUVMxd3l1cHRzamdXcWNLendUS290YU9ONzduUndYbGdKZW9MUisy?= =?utf-8?B?UlEydDdzeGlhZElwdjFNb0tPRzhoRmRhb2xTemZsUlJPMHlVL24xdm5sL1du?= =?utf-8?B?MThKdTRJVmhKbmNoOGlKSThyN1VmeTNvY3dKZ1AycUE0NWRieUUyWm4xWllp?= =?utf-8?B?emdoR2pPbDVvZWRzOXpHcWtiMFZ0V0FveXh0cUxEWEd1UklGcnZIWHN2Mmty?= =?utf-8?B?LzA2U0E1aTZaVkZUQjlwenZRelh1TGRUWUNHT0VkekVkYmdTWE56MjNxbHNt?= =?utf-8?B?a1pRZ2N5M2doSG1sSEZwRWNLbExOVG5wY2J6QklGS1hpRGVCUUg3YjJvc29Y?= =?utf-8?B?RWMxeDNiS3Nya1RHUU5RMnNWTlRCUjVZQ0pzeHptMWpTd0dFdDc3QnV1Ykl4?= =?utf-8?B?VVZyQ1YxMCtxK2xWZnZabTVQU29RcFRTZkpRNHpHdVUydzJFZEV6THZoNUNP?= =?utf-8?B?Y1JvQ3hLR2tScjFpZ2FZcWc5Vm5Oa0hYbEZWVmZ1YTlHby90REczTmhiaDcz?= =?utf-8?B?azlPc0c4VHpiS1p6bE1rS3k0aUw3ZUtHVnBzZmxFZ1RWaXA4dVp0OG9XeTdI?= =?utf-8?B?VWJqTERZVXFXdU15OE5rQVlsaHV3SDk1TXE0U3doTG9SbWtIaVI0dzdwNzJG?= =?utf-8?B?dVowcTNJQWFpN2thRDJ0NWh4d1VzWFY5WDVqblQ2NkE1WUl6Y2VVR2xkY3RS?= =?utf-8?B?aG8wQUF0QzM4T2p5b2RxWGhYa1Q4MWVFOWhOb1N1SHhUaXpVajMwN1JFamhZ?= =?utf-8?B?eElIc1FHUDRkdlM3b3NKc1E4YUVxMEdRanBvRTVIaTdjVTg1VEpPVmpYeHFJ?= =?utf-8?B?N2MyT0N4bFI0ZG1MdnNCQTBTT0JpaFpiWGpIdnVuVVp2MVFZU0RKYlJSR2lh?= =?utf-8?B?dmtRN0JBS1pnajhNQ3YxdFFFY2tGcmE0TmhGTXgvTGhUL2kyTXRZTVNQdkUv?= =?utf-8?B?ejBwVE1MUGNYSkFqQkpLR3lkcGVqUDNBU0s4eTUvUGVSei96a3FCUGJKZFNV?= =?utf-8?B?VTh5RVJDenZUUHpMMzdJYWJGc1VONUxXbXE0OFJkMlZ2Ri8rK2srdXIyUnJn?= =?utf-8?B?bTY3ZjJ1Z0VNYXB2c1lMU0dLb0NZUzFXbldyYVJhMFNwYUVEK0dNalozQTBG?= =?utf-8?B?eU1MNktPSktDOW9jZ3hSM2JmeHA3VkNVODYxbWdYV05Uc2hxTlF0YkViK0RZ?= =?utf-8?B?alZrMUlFSmxxQmhlU1ZBODkxdHRycEhFQU5NMXhSZXFJZlN1K1JuZ2RoWHJp?= =?utf-8?B?WDZiQlJRa0xOUks5Mkc1QndQR05jK0lKMnJLU1ZQYXlQUXp5c0t6V2k5NUx5?= =?utf-8?B?SktUNDRreSs5ZGZyOWgzN2w2ZlY4aGVsdTgzNGhPRmJhb21IWmh6VFBnV0Jo?= =?utf-8?B?dmFlZDJjOGVhRlQrT2xza3UwZmhxWWRZMmFvTGJreHJ5MzMwSFUzY0NCQ0pH?= =?utf-8?B?Qi9JUFgxZ1ppMzJ0cHBTSFhBMkxGbTE0QXI4clB4RUlIN2RyQWNIQ0V2Ni83?= =?utf-8?B?MEhpbGp1UXpkdVRDZllSQ3NFT3NNZEVHNjdmQ1J5SFhpS3pLQ21JN1dXUEIw?= =?utf-8?B?MXN5WDRkcHdIRU4vRTE4dm1aMW9XVENjUFI1V2UwRFd4cm85RGQ3amxZS29k?= =?utf-8?B?U0xVZXlXdThxNXI0SzNDc1YrVzJDVXVSNU9Ub1dLS3ZSQW9wd3lrbFUxOC9K?= =?utf-8?B?ZEJaT2xhTnZrY2JhTElRcGRYcnB6dnRybmdFSHRuQVpCeHBRR08reFl6bURD?= =?utf-8?B?YkNhUUZmQXNhRGEwUTFtekZrTG1oRVNtTFpGbEx2R1hWRjdEQ2V2SjRUUEdI?= =?utf-8?B?UjlsNmdiM0dQdnhGYWZUdGN5QXhlQzhHeGkyd3BzeDFoN00ranhGSVNxOTVi?= =?utf-8?B?T1YvN0NvUnplNnUrbE5YN1E3NGdCRy9LLzJRRnF4NUd3TzdWYmxadVpTdEZV?= =?utf-8?B?Vmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OOCCI05hd/sSVtjSWOdBJ/CSfPQrs3HyVY8KGp9HkYEo4/jXCZAXym+o/gAoQGdsFgsN4AQo85ZoJo012yNCjMqxumPCnxSE9e2Hh+MubxrMVoCsVCQvCuGzJaJfkJjTxXJSrcZCVJFsHxbv7Zk2zJKPkzBiTjQnGkW5I4cU4mdqX0lQaa8TW33AKvP95uPjlwzytiq7JC3dUh6QpNrwDzM+a4mOM2Hb+Jn3Wo7KmeYwpCqHke8a8338h1uw811pP7kjzVNa3ZXGaWnGUWVVw9puK79TafLmybwci72xgITTcYhvz9M+81KAzB7mj1ocHFAa1gEObGQONu/xxWe6rrcWT9ruj+Qdn+VGrE59JZdx/sV3EH+po/dD2vVjZe1HJ/1kt3oHnyM8PhbHXENtII5jU64jkff2nm/wKR/qU9PAqdbzR/mLWHDgxvOzlbA667zVI51QJdTkm8BwER+ES7bfoK5jp9R7+ov8HvTpr9EvNtVfQZudqIWqt59tk1I9QcYFgmPn9G+/QzKkz1Y59086EfBoPc/6ugU/2S4+iPpdkUNdbFUF3tGabGkom5IesXA9jZ5DXDTOQQr4TqfxGafYdPDTCQ4b3gXLN8BDdg0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dea2fec-29d7-410b-6d1c-08dc2d780f1b X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 16:14:45.4429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oR6i1b1m0m+aR3qoHKp3h4HLmw+hxX5fLnQ9c0SD3vZXmJPYFOxsp5VOZ570rDFHi4Ad+Y8p4BqQpUygfLelMnUIpCl0AihclJBW/9DljBI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4737 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-14_08,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402140126 X-Proofpoint-GUID: beaGWjL--HC-bwz9YzbHcIgrJxmm8wDP X-Proofpoint-ORIG-GUID: beaGWjL--HC-bwz9YzbHcIgrJxmm8wDP X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Wed, Feb 14, 2024 at 5:58=E2=80=AFAM Jose E. Marchesi > wrote: >> >> >> > First, as I said yesterday in my direct message to you, thank you for >> > making binutils such a pleasant place to contribute to FOSS. You have >> > no idea what that means to contributors like me! >> > >> > Second, thank you for this helpful critique. I really appreciated >> > reading your feedback and will reply inline below (including with an >> > offer for a patch unrelated to callx that may clean up some of the >> > non-constant uses throughout the bpf-specific code). >> > >> > Third, there is good news: The heavy lifting of this patch is largely >> > "overcome by events" -- clang/llvm developers are changing their >> > encoding of the callx instruction to more closely match what gcc does. >> > In fact, v3 of this patch will look much more like v1 than v2. >> >> Hi Will. >> >> It seems to me that all we need binutils-wise is to enable the callx >> instruction with BPF >=3D v1. No other changes are necessary as far as = I >> can see, other than adjusting the testsuite accordingly. > > It should be making its way across the Internet to you now! Thanks :) > The only thing ... it will probably cause a build error until a > corresponding patch in the simulator lands that takes into > consideration the new enum value. > > I am happy to handle that however you like! No problem. I will tackle the simulator patch in the GDB list and apply both at almost the same time so the buildbots do not get (too) upset. > Sorry for the delay! > Will > > >> >> Thanks!