From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id AE8673858D38 for ; Mon, 12 Feb 2024 18:39:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE8673858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE8673858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707763174; cv=pass; b=a3TOxRn7MxylbLbOY531jueCTKp2ZxOuVXBy60e0vDTfOsutVcGUn7E6B17kqFUFfxKQh3oR6lxlb1PJpC6VKLCSFaKT8fOpeb9VcOm3d/4FX5VfTsffpeuSthYWUNZ4TofEMrxYMBViKYzEYUZMdxrVJxv5F8ouAaHItNod3vI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707763174; c=relaxed/simple; bh=RcbcUbpeQ14hkQfKrCbuUhSJopTmBfS0CqLJO/dKuds=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=OYyHUHfR+ivmkGlf6c1qxA+idMUHRbkmo1h3Lh+ShpZfxH5NjTlL/NqC4h5MEzRXpTR4Y6Dr79cgGEcfpG8DgOGuT0bnLCn0jNcEk5bDYYmtqOQfkXUUxUOMdMbh9xDfIgCOh+X/c+mj753sG5GxZuNBltSnj3HpBAq8snAu/yA= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41CFUUxd023326; Mon, 12 Feb 2024 18:39:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=3AyLYE3bH+rnTXXsD1B1AI8CsZGxMv+ERGnJCKJZuSA=; b=X/ogYfjqOzco2PIMeH841rFSKLJkF4EoTUanHh0S44ncGFreYgVy3vhyudAqK3XUZ6d9 WuOwiKr6NpafTKpLpriTjpmW2VsYXVaWy3zSRiJynf5CMDWJtMkRcj+n1f7YKFszM7xP Yy5+FBDb8+LVbaF/VFrUzOlG0DxTI0Bj6VkhTwQopj8KYfeAhb9lKRnwRfucMRX664YI D8EP/0aOCHOrKho7jFRXu06oh2wNaE5wcX2VH/YA/+8QkLphLA/cCkLOIFNXjAAzB9e2 2EN0B6TeqXc3Dfonbh+dVtJxXJFW26+odFmGUYuhlxKrHmAw+TrOoosJe675S9jRQVxH sQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w7p1h0jbm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Feb 2024 18:39:26 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41CI4fpc031332; Mon, 12 Feb 2024 18:39:24 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3w5yk65bsm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Feb 2024 18:39:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHS2Lve1YUHjrJ5M1zApq83XCZGryHpBXh6zQWFwOFIO4AkKIwJKgRDAuo09N+fETMG+WDRe0Cu4u6Q4G5Ijr4Oq7hd4aqgerG0fzb7k3b/y+eQkOPwh8bspqpcoyWeBNGrUzAui/4S5Ve32xy4vwwaO3x5ER7ifZA+7T11gU9hvoIOSk8Lk8s/V/IXItNmkXfnwnx995KQzX3xtRWeRn+RY4IIzKSyOkK8f1/Fzv6orjlzqzDgaJkLxUzrVOkjsSMj9WRi6YwnJpg43/ZUMV4s7RgU5B/l5iMdaC9R9cm5JnTf4nThzjYKLW4pR+f8bSHMFxJ+NDHP6aG9jLfn6AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3AyLYE3bH+rnTXXsD1B1AI8CsZGxMv+ERGnJCKJZuSA=; b=P9MGYGFIdY7jFfO7p+Z1Dg3tODq1mTuBnxOWFPmkB/NCC1AyCWYrbTsEag6YzIP5XiLBf5qC3hmBbZ6+kfQtQW8kE5cyqS+c1lYE0lW4MLD/UobQlHsg6MeC1X29TxHH6r6ateW47Wwb/RFsz1RysivUmjYbuwwPqMP4YLQ7WTvC3am8vdYS7p71gLL4oZRiT+NybXqSmThyRGO2Url8ufo+15G0A4lEwYlOSvHf9OXK3pPZnD5+9kGk8EPaK0IAxJjcezPzLvj5+qhdLMj45U9QoxRts3gsr4fHwmR5LPARzxP/HZnHz8gx3ldGLbicSCWqiOW2aOTwOXoZ6Saetw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3AyLYE3bH+rnTXXsD1B1AI8CsZGxMv+ERGnJCKJZuSA=; b=SXKvTF41l3x920tJ8+Yz1AH0k6hM0lHda3EjnvSXzYq7HBO9AOarWnKkGjojrBT9bad0jRTT28jOmC9b9PEZEa1vFdoRvmttkeCPOeLoPpmzn4+wiAkB6ul30OdmWobPDHrzlqr/1KsBFjhRl6ljuRD/gm5d9iotL6xmm5wFBrs= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by CY5PR10MB5987.namprd10.prod.outlook.com (2603:10b6:930:29::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.38; Mon, 12 Feb 2024 18:39:23 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1%4]) with mapi id 15.20.7270.036; Mon, 12 Feb 2024 18:39:22 +0000 From: "Jose E. Marchesi" To: Will Hawkins Cc: binutils@sourceware.org, Yonghong Song , Eduard Zingerman Subject: Re: [PATCH v2 0/1] Add BPF callx support to objdump and as In-Reply-To: <20240212174209.620310-1-hawkinsw@obs.cr> (Will Hawkins's message of "Mon, 12 Feb 2024 12:42:05 -0500") References: <20240212174209.620310-1-hawkinsw@obs.cr> Date: Mon, 12 Feb 2024 19:39:19 +0100 Message-ID: <87h6idv86g.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0406.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::34) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|CY5PR10MB5987:EE_ X-MS-Office365-Filtering-Correlation-Id: e47aac6a-23a7-45a7-75ce-08dc2bf9ee62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: udbaDK1Qz4BojcLZ1iBCEEvxySXsIO1LgUWqncDKosYyORO5WewWzRwIUsHFpHW+n2fMvZ//WVtyFM6pNeZz6bcNTy4CMiOhF48I63OXIFC8sbt25QICXvIRYB89cfckEcA0I/jgdB1NBONUROEF3S9BVDGZ8kbAsz4n38zHOjdwCawZFVqxkh7d9FdfYjaBdKBGI0iB5HxoMDZO+MsQOc8kejkQuxjY2dZ/uoAteT8K031BfNvGGHiE0nhTYqsD3X57SwV+Ezr3O2raNtHOaZTn97O8GBNFX8x9r7dLNJ3CP1zAeZW9fqQbWeb1UFIfPbBrA1D7F7UdlHmz9rGfoUWKEQ8lbb9PBV/kmecPYDkFp/FdwqWKb+f+w719pdTIGJe0FQAt2B2dQQEuKTtoo/Dl7mtk6LVZ5TkKXmLJNoIiLVjmRb5zz89FTFEpv3HDgSeAJ31fdJ1eYmWVyc2CE1bHQZYDtwEOV30jUCdD7wm1Q/9yp4rEm6bz+al6w/wBoFyBZ1cldJ0qKQUiHCF2T/fRRSPKW25d/XCjDFjFbkglvoAn5qSZqCWpZGoN4jSi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(346002)(366004)(136003)(39860400002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(5660300002)(86362001)(316002)(6486002)(6916009)(66946007)(66556008)(66476007)(54906003)(6506007)(6666004)(478600001)(2906002)(4326008)(8676002)(8936002)(38100700002)(2616005)(6512007)(83380400001)(26005)(66899024)(36756003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YR4x7e1qmWwcu03WMHM0KHDYCQ1PTwXJEr+cOXw+GxDtatozut7Ngib9bJIi?= =?us-ascii?Q?YPYOz9+ksRxYOvG/roH5WpVtTBSExYqAxVkOsANN1LDQzEVX21I8p/QWnEgZ?= =?us-ascii?Q?Ih0MZegPxCNUb6ywWSft0RLX5URQ/eGedcE5CUcAJj8JMbxU3dKtCU6OCxRH?= =?us-ascii?Q?vc7VIKuRt9jXOA4oB8DFGT3JMPMezzYJMcpL7CuNL5DjTz1OQuuuqbeXXXq3?= =?us-ascii?Q?Uc6VWs1B9IGIWuuHsXqGkmYNgenG4WCXZEehngQ2tU1lpBsxwO+g4nMv+NSI?= =?us-ascii?Q?KkGIkrJPcoLO91XMFmjAzDzBPph0E+q5GYxIpMmbfSXaW3ht0UOPnAAXtXvC?= =?us-ascii?Q?mw812F/kn7Aacok9+0VF0AQMGvWpYmwmyMbS8fRZ0R6wyyJk5vcLZkYqXx/g?= =?us-ascii?Q?3Nz6MD9SOkw0lOvQC191VHqee0YBKVVa0AE+JIKfw0K2RB6ervC/Tv5TRKGS?= =?us-ascii?Q?PX2Vz/DXdP22vjQkN50sH5VRUFQMvEE0+2P4aHXMLOOqFWW1o73Cwvzpju9J?= =?us-ascii?Q?2v+af9SCLGK4h3ij3+9Z/Z3w9I4mnDsCcHYyg4haKtHSNOX8z8mcKz2TzN46?= =?us-ascii?Q?THexkNLzaNIdAqSarEClMLro7Bd41QGF77zztInOV2T5H2ezZDGeO3AfdJng?= =?us-ascii?Q?j/RitRWUyJMa0ddSNAq+oK3JJFnPSWeL0FBg7nNa3jA2VxwG6ZDwE2UbgHQo?= =?us-ascii?Q?qhgXkzDJ+4ESc2VuoJCILMPQYtAk4nbgwTj4+Oju+e2Rm8dHMSoY4nsKrvBf?= =?us-ascii?Q?HFXtKGx1mvfj6I7KjOBl36wSaUoz5rNufjkyhD+b00dFqxvKPaMHWj8iQ3pp?= =?us-ascii?Q?eAQrWTKaOQ/xxDlBsmoIZaksYDoSvgtQdeV9rOhfVjYy/KquPkAn6pgvQYf8?= =?us-ascii?Q?bv32/llMn8Zy/QAuLxG46Cp3fnX60gsZYgDie/FG4A3emOSHRt4afUduTD60?= =?us-ascii?Q?SUOGP6pOnCc3WziIvEEMFp9hziJjQZCde7tC9y+opj0DKnPUMjXVUqYN63Oj?= =?us-ascii?Q?MGM9ckvsmdkeuBkEmXuzJpJNCqybAvGzPeY2NGqj8x/TVBuOHNdu5mzyJd3K?= =?us-ascii?Q?jGJvF9eXy8Vt7DNvDSXovDGyjb07tAdGdvyfQkuN9xf5aeGphsZkxDCZyWiK?= =?us-ascii?Q?vQV/oQvPu6tFb5yDlFvnCmJjwiF7eZ8fv9gRcauGMC25hDRncptYjT3DVDnT?= =?us-ascii?Q?Ym4joQmcjUu8g5wbWiNIOtskrM7elXndqNmkQ47yjLrSwaZ3XIcKDzsJGTB8?= =?us-ascii?Q?9vTBXL4yhPbPvyBAz/A3xPncxFjTOLZ6t91bDvkNADE76Dc7GwmjYh/dIGQU?= =?us-ascii?Q?lkUKxwI/NJG7+ieE3H0t/MCthOgZqH9Pe7CW84XKxGosP3e7llprMZ/LcafF?= =?us-ascii?Q?vFXRn6mS48JiCB244VMh3/JIh9p7dynwIWtdK/g+QDZ7EwCzeNTd+9ghNc1M?= =?us-ascii?Q?+b2yszzCD3xrl1jCjMKM6UAH3JpWtVqRDW+ikZkOG4OM7buokG4Nu7HTB3hy?= =?us-ascii?Q?bWScjOsj7lvH60bucrGtF6JU5ko+0nIoLY7ZTY6QKbjPoOS/OYuy+KWiI8pk?= =?us-ascii?Q?4BulDzaNY2hHhwAV/eNPlZHTPSVQtWo6Q6KCzEllTFCeMvccZhOo+8Bepput?= =?us-ascii?Q?hg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Uzchww09PIqYeFBkkBnzjZAH2EhotF3P1ImhdR75juh89IWE2lmmJAHPipT2+XqkCw99WPg4sEDagfNhia+CXhq8SPKWm57gytNlg3dppBycMao3XSIzSEm3hcPMOUdnEVWbURDRa4dmaLaGs4FhQWHwMp8CkhGyQlRee6b/cMoP77RRNqdYb1vJs/vPj5ervNRkuGvSybpKbkPSqLmpjcI3A7ULjweK3GvEJexauLyXZFsDqCl8qCpIpspqth2HyXSwcEpKhjU4Su0NxR3fxDlBucnGCdezFSvbKjpndkFw4WOjypDDTMRt/J3Pt6Yl629jRq/8PKON00/5g85iDPbqdq7H21tfkSRtJ6DSpgBWYh9EwoijbiJm3CRYFcjCyMsCXtMWL1NMi8pD76TtWcfbNt0db8u/pqzqTi0xwz1A8RsUt95/SIoVx+P4vRh941VhBxYAqaSCjmNG/wPoiO5dvuPJaeiDDq+FJ+j1r1bH8jAILB0NGi19o2we+H68JGuvnlv/G2wcK9qxZIRhBuSuvLPHQPkMz+3bsuxfDUhHnL2mpxaGH3rr0iu7Z7u//uZRPse09b79CAWG9Wa5wZoxOFoaVuN+mRZaI9ChYwE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e47aac6a-23a7-45a7-75ce-08dc2bf9ee62 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 18:39:22.8075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IfKFNNAjUZ+zI59DRVHcDVSM6PEhrFH9pIZuxOiRBXNSvjH1Pp90B8DNtwlM5YbnCaca3Hy/l/av6j/LOf0WoXGH0uvZ7f2qwswD+NCcywg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5987 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-12_16,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=787 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402120143 X-Proofpoint-GUID: sKRCEu4s-LgyizqcKq-VIFBasN5vKfQP X-Proofpoint-ORIG-GUID: sKRCEu4s-LgyizqcKq-VIFBasN5vKfQP X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Will. [Adding Yonghong and Eduard in CC] > After additional consideration and discussion with Jose and Dave, > it seems like we have determined the way that clang, gcc and binutils > need to handle the callx/callr: > > 1. callr remains with the register holding the target of the jump stored > in the dst_reg. > 2. callx is added with the register holding the target of the jump stored > in the imm32. > 3. We have to remove the pseudoc syntax because it is no longer possible > to disambiguate between versions of call by simply looking at the > parameter. I don't recall reaching any agreement on the above. What is the point of having both callr and callx? The existing callr is generated by GCC in -mxbpf mode. It is an experimental extension that we use in order to be able to run more of the GCC testsuite, so it is always possible to change it to use imm32 instead of dst_reg. I wouldn't personally welcome that change and would much prefer if clang starts using either reg_src or reg_dst, because compromising/reserving endian-dependent 32 whole bits for a register number that only requires 4 bits seems like a waste of insn space that will complicate future ISA extensions. In either case, if we all use the same encoding for the indirect call instruction (I fail to see any reason for not doing so) then point 3. becomes moot. > > Tests are added/refactored to meet the above. > > I am more than happy to resend as a separate mailing to the list but > sending first as a reply in order to keep list traffic manageable. > > As I said before, I sincerely appreciate all that you are doing for > the community and how welcoming you have been to a first-time contributor. > > Sincerely, > Will > > Will Hawkins (1): > objdump, as: Add callx support for BPF CPU v1 > > gas/config/tc-bpf.c | 25 ++++++++++++++++++- > gas/testsuite/gas/bpf/bpf.exp | 4 +-- > .../gas/bpf/{indcall-1.d => callr.d} | 4 +-- > .../gas/bpf/{indcall-1.s => callr.s} | 2 +- > gas/testsuite/gas/bpf/indcall-1-pseudoc.d | 23 ----------------- > gas/testsuite/gas/bpf/indcall-1-pseudoc.s | 13 ---------- > include/opcode/bpf.h | 3 ++- > opcodes/bpf-dis.c | 6 +++++ > opcodes/bpf-opc.c | 4 ++- > sim/bpf/bpf-sim.c | 4 +++ > 10 files changed, 44 insertions(+), 44 deletions(-) > rename gas/testsuite/gas/bpf/{indcall-1.d => callr.d} (90%) > rename gas/testsuite/gas/bpf/{indcall-1.s => callr.s} (90%) > delete mode 100644 gas/testsuite/gas/bpf/indcall-1-pseudoc.d > delete mode 100644 gas/testsuite/gas/bpf/indcall-1-pseudoc.s