From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 4CD5B3858285 for ; Mon, 29 Jan 2024 21:37:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CD5B3858285 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CD5B3858285 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706564255; cv=pass; b=pDCAWXcY1pBNB0g7AYiUpGpasCyhMpKR0FJWA3DVMHjits1HTJzYng9eFocEBStjkwl23dUrVpgFwa3M8weEfVGMiI/1GnqFPgZvbFOyvkbBdCkQnTq0Q8XSvp1pGr1MXu+hZxxr7BG8kHS6wgcCvrGJcFUTAL3BIy+2jOtU7gw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706564255; c=relaxed/simple; bh=+zVTaZ5RqyfJ6Jtlb9LWijEUjuO/JmPgi1nFZ1dnHq4=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=rsbZN0Ax/Quevrq21mJ0D4gxO1bVWxN2VbGkpb7oL+Njh+SFLySp4CU2/F4fGBkY1sIwXtpukeLQQamw8Zauis7eG5uBqXE6NInNAZQWWhUPgqBhL9S4BqaXl0PewCLGSOKzOhpcdRAn2GfN8vt/S87TdQOZuSxxxcOlfm/acjg= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40TJi3gb016923; Mon, 29 Jan 2024 21:37:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=J4tuLQfPTWHfSLwTnK6bezBa8WZeAqCu2y8o/PHuHE4=; b=TYV7J2Y/wGBluWPODR/UUDEQx0AHOkCR5TD8XR3w6737V1R7V5IW2wYNXUvngel1Q++d /J1jVMZfZr4ZGeqxrgYaFbZbIPNPumJEAb8TqyngATU8xzutSov91VIXxM3rWkM3dG64 c8apJD6YlAmuOWWB8WgP1MbC/4Foot/yLU0KrkjJyPiIwFidfsONYHzCT6CQFMMR3mKJ wR5+iokLVffYojx4FNfm8JciLCH7AYJ2mnNFJwOBaYlzXUve1U1bVaqxRhb4OM/cvtCH 64P4c/NGd4irM3Wt5DuUCmp3nMBXGm4w2P0dNlA9OCjx8qbZcCzM62FG5b1ZC7Ahkhkc fA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vvsvdn1xt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Jan 2024 21:37:23 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40TK654O014544; Mon, 29 Jan 2024 21:37:22 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vvr9681h8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Jan 2024 21:37:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bffQGKDIya/PjW4y1ikEUIcqGC5SLIgo0cgaQydqtEwUaT0Qpo3MNsIF7qxkVJAYEByJb/FTUNU6CW82i+DLDXnxqgxgi/gkieD/uIsJm/Ux6HnBqSnkj+K8WsN21baECNJOHtxL/22I/g/MKFGXiV2o4sEQ83ermFR8MI71R4UO5nBeDMvXB5FCrkpsG0NB6qrTxUKaW2LcQzE0LrOLh3DxL5/lInDs1ZUrKOTKScHU+dGPfV7ZI5qYSgxluuomotIg7Mxh0L2LlkwU2JMbKlKoJONbg7gL7ug0EKXiawvZ1aPR9Cgnp4hf3/ljnMz3iCqBQyYbwUhC7HSWiyDqqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J4tuLQfPTWHfSLwTnK6bezBa8WZeAqCu2y8o/PHuHE4=; b=W0+dsX787fH+/NjKQr2JpS5nXA5F+wbO5KwMADDbm2SacRd4U4rmfNMVFa3d9GWtQV76qbeBzRzDupsPh9SK4OjT+JNhitVzIZbCDC6mOxJ58z3GTiBR4zDjouj108H/CG6Lln4PFBA2EMt6A/Ce5PhMtEQmP0JcxaE7TN9s5wpc9cJ9jY03/qJj2GslkiCznz2TwSh6arb4UQMG7arcV3PHFRZeBnyxt/ZtFxcyxssaLHiH2aIurCfXv1ho73I0tSv2agr5TWnhNBdfG9KFFuZvzB7hq/mMfNmI8JlsfGe5dKkSUxRr84WqhEwTr2DDKaGDKnjxmLHy0FYNlmX+qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J4tuLQfPTWHfSLwTnK6bezBa8WZeAqCu2y8o/PHuHE4=; b=XUTNFGcYOcMeYhyoIBHe1S3Th5E3GmUmSvNi3wT0VU/vDbneXmIpjn500vjYeltPE3RyAuoxF1Tgv+WgzI0DVjTMy4/V3DyJRSeTpoyNIZ75FkU/wvRZKzy5p/pC8ATVhayRr+tlJ6jj4m7BX99QpXSICfCaXQ470HA2CM4jhrc= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by DM6PR10MB4379.namprd10.prod.outlook.com (2603:10b6:5:21e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Mon, 29 Jan 2024 21:37:19 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1%4]) with mapi id 15.20.7228.029; Mon, 29 Jan 2024 21:37:19 +0000 From: "Jose E. Marchesi" To: Mark Wielaard Cc: binutils@sourceware.org Subject: Re: [PATCH] bpf: there is no ldinddw nor ldabsdw instructions In-Reply-To: <20240129202000.GF9744@gnu.wildebeest.org> (Mark Wielaard's message of "Mon, 29 Jan 2024 21:20:00 +0100") References: <20240129182803.4867-1-jose.marchesi@oracle.com> <87zfwom0sm.fsf@oracle.com> <20240129202000.GF9744@gnu.wildebeest.org> Date: Mon, 29 Jan 2024 22:37:14 +0100 Message-ID: <87h6ivn7n9.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR03CA0087.eurprd03.prod.outlook.com (2603:10a6:208:69::28) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|DM6PR10MB4379:EE_ X-MS-Office365-Filtering-Correlation-Id: 807300c9-8b41-415a-3248-08dc2112784c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 29OhS3mEa/5zERsLR5WOVPc+uz3EzRk9mq5rxpGhTRJnYxGPORduuq4Id4CHWteJv7EL+yYVnFKv3GGScwxJKZuH7T41n2x56pRdELXHXG+Okovzi0p6BRXYpmVtyN+XlWRUzdAprpIX8vurI+6+B2qoyIuB0zUXOf+MCBlHcxYe0ZfnV4Klor76ZIYq9mYR/jp2ZagB2H5rfqZXDlKu0fTWMU25Y8J2jUfo9ZaLd8Zc3QsR7NC0bsI4PiUb7dztJrJNgfHKO2SJUC8FTI+f+xGx+xdeUsDV05swbmqx9Crnj0TbYCIB+p7DNaNjmRwsJnaoZu1BCQz2mVqeF+jBGy6H5ys6lwcaRQPuoC8OLFGB0Zft4h/fkqafaLcre2y03OrASXoJvAlV/uVahd7L+NGcZHZz+a0OXLgw2qHKdHNApr5k6E+GAX0QfqO2EfYSM1aw9pKtZ1WPLKhXvTGRRMbzFvj6hb0lTzKKLjMpZunjUdjBkco69giQwWVeP4NFT5rA6zV5PgKxfkngsZchZA4IPHh4jMQ5if6jamHWjBI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(366004)(396003)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(86362001)(6916009)(38100700002)(83380400001)(26005)(2616005)(6666004)(6506007)(478600001)(966005)(6486002)(316002)(66946007)(66476007)(66556008)(8676002)(5660300002)(4326008)(8936002)(2906002)(30864003)(36756003)(6512007)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzRMQ3pwWXhKdVYyQU8xZkFGb0hzT3QxcDZiTkV2RTBFOEpMTU1KY0xqYlQ1?= =?utf-8?B?Zm83OWNLNHBBUHp4Wnp0eUxQUG5SN1pSem02RlVUWElZdHdPTzVxc2Z0V3o4?= =?utf-8?B?Z0xsUHJpZm5vZEM3bVpKRTh6ekszMnhpK1dFTWl6VEhpRVl6aE1kQzVHV3JR?= =?utf-8?B?ajE5bHUvcENZeTlqZy9YQnRMOGhFYTFPL1B5cnJVd2R3YXNQYUIwVXYxSEw4?= =?utf-8?B?QXVsOFg1bTlXeEpuMkhZalAyVGZ4bUY0am9ibTJpTWM3U2MySEVZLzAvYVJk?= =?utf-8?B?YjVqTlV5dGQ2UlVBNnJlQ2pMNmUveUVQUkNaRS9peEZRMkp3bWJ5STlRSmQx?= =?utf-8?B?S0t0ZTI5clNnYVZNRXpmY1A4UkdOdlhZdWZKTldlT1BZYVc4YW1ZdnZnUTlG?= =?utf-8?B?aHZQRU0zVHR2N3Z6SDBrc1FibG15bFFiZE91SkgwdTJvUDdGUGVjUHZCOUVD?= =?utf-8?B?dmhVaHpWN2ViUVFocDA0UzdOTXhQQ3dUZk83SzNXYlpHeTJuN1U0NHRwNjds?= =?utf-8?B?NzBzc0c2RlZpN1RHRnJaZ1kzMHVNampNdEZubnFXU3o0TTNrRHZrb2laeWd3?= =?utf-8?B?TFFKaU0yckYwZ0FlRHI5VjJZK0JvU0tSMHNPdm4rb0QvZkdrOG5zYThyVTNB?= =?utf-8?B?RXZaV0ZFaWNEK2VSbHZPcmovSGk4blBOMDFaTVZRbjhaUzh3WXhIMU8yUk0r?= =?utf-8?B?QXlaUmZpWHUwL1lkZkkrRUFDYmJ6WGN1UVdzQmFIQmhjSXJJbWRoSEpKb1l0?= =?utf-8?B?cjdXa1FTVWY4S2lVT3FmcC9EY0ZIYzgwWW9yYlhzRFVyaDR6K1NhM3loSSs1?= =?utf-8?B?QnIyOGtJVytWQ2RkS0R1cGV5ZURtYnEwMmlzN21yNkNwazdrUW9wdllXbE5m?= =?utf-8?B?ZEluUXcvdVpDZld5czdsVEx1YzdoRnlFT0E3YUdLNVlwckJJTFhHQW4rWjd6?= =?utf-8?B?NG81YVFtNjNYWkJhTVc0MlpqTTVVQmJFb0lNK2diM0IwMVdJcW95c1lXN1hi?= =?utf-8?B?Ris0UlBrSXZCeGlzc3Jxa21KZ2JWOURBeEE2K1FCUEdTQ3ZiOExYQUZSSUY2?= =?utf-8?B?N1JPd3p2U0psb0F2NFV2cGVBc0loWm5wditvK2NGVUdZZ2FKbGFncytyemFB?= =?utf-8?B?ditZRUdiU0lwWXFzOVZXTDVLYUp6VHNWUWd6dHFwVVorWW1JamNGM2ZzUEtm?= =?utf-8?B?VVhsbXMvQ0Znc00rUk4vT0NRTGFzdENkeCt5bjh5NmJ5WVQwOHhXbURTSmN1?= =?utf-8?B?U3lMRmYwUjJkTm10SFNEcStXamRpU3R0Y3JJUUhqYldCR2pNejNpdDZ3TVZa?= =?utf-8?B?bGc4bFE2eGJheFlrU3owd2dPWlRwVVlEMlNPMHByQnVEZFlKaGpSSTNKYzNj?= =?utf-8?B?UXFqeElQdW4yM09OaWRRMTFNQlFBenJwS1hiRnI0UE9aUjhFN2NUa0grcWha?= =?utf-8?B?YSt4NWZXOHYrVTlHb0JuZHhETmVYY2lGZ3JFaHBGQlBQRG9KamwvVFZVZHlQ?= =?utf-8?B?VG1Md01TSmRpUXJML3IwN05VQVFhdnVNNjZwcjdwN3NCVUlGUjUwZGtlTm4w?= =?utf-8?B?dUM1ekp2ZC91V20xWkRiZFJXUjQvaW9wZndyUnBGa1pDMnJoeWxRa3RoUDhG?= =?utf-8?B?YmZiR2lyRkx6cWJqWU5ja0hIZXJmYXFrcnNuWUhtRzFJWG5WV1JndlNIYkhu?= =?utf-8?B?WUVucGxmRTlhSWx5dGRCUXQ1TEdaZ1JjbE96ZVhvdjExSzJNSVFFYTNZdFNJ?= =?utf-8?B?dHVlZ1lwVE5lRlpoa0kxK2UvWGIyU2JiTDRqeEg1RE9mMjY3dVVVemVUQVV6?= =?utf-8?B?Ky9QN0lTWlYrNEhmbVhERlpVdmNtT0h3OUhJZEpKZEd6TGVQWXlydm1xd2dV?= =?utf-8?B?ZFRzODBRODBrTVdaTnJJaVJ5bnJhb3pJV2VUMThsU0k2QlMyS2MrZFNJWkdR?= =?utf-8?B?QnZGbkVIUnJrQnBWMVBKMjdNNEtsMTlwYjZSajBTMUM4clBmWkFQTU8wemhU?= =?utf-8?B?dHR1THVkVTkycDREUmNabFRCWmJQelZuRzFvNjRLRThGc3llUXdydm9nSStD?= =?utf-8?B?MW95NEFmcWJyODFubExFL0tIem9vOGFuV0RqVVhibHd3Mng5Ukdnci9oTHYr?= =?utf-8?B?aHJGRmd3TkQ3elg1QU1PUjVVZjJEVmw5NmRldEgzYmdudnpicUQ5SDU3ZnlL?= =?utf-8?B?NVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8A46R0ZLYbqVX5QAPHss2eKNGCS2pSOEwYeNfEC3eNgAMq7SEjO2+6mDYVu208hl8cC+LtBWwJ0eu7PYeDAIdbnDYuMyfQbsqH5VTDHl9BLZ+No1YGBEKycbZQS/FA1dKQKuAOjWbJugZFt/kuzG14WoY+VPdQJG1NtM/bbtI2g86TWiU2O8qUN2DiRAmBxY4xBOpCqprjbcTzwCfLA+QusbKME4CYzGTrggF5dJm7syI2bbw8wb/kolH5IkUaG8QVi6LCHWG5eqL4Rt6U0nDj15fZjxb0wJ9MfsdRF4+m/CIaNbJTIWQFb4sWd+NIpHk4Rvwj0zY8/YDstuXnysJG1emIR1QP+AtGdZ1MA08CPbJhNZ/8/8ImfdW6WdhtaI72Ajvrfv4BxEmbV++AO9TzMUpGSkOBadZSGAlMW2b38ph618ShVJF3h94pDImatco/8jli+ymcIbZqzRHIkpil9KuDe+jSMzkOK0FM+jXOxD6joZ1hJbYD52mvVAoh2VzXGuO7Aq3XPrDYKAwi3uRMb78AxSkbHO8o2kMc2Xv1V8HJNLMgxI/66Y9q+zIa+7fJk97ky7yM5hH5RmAjRp7DJWb1wjFtVrc++EpTqM69Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 807300c9-8b41-415a-3248-08dc2112784c X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 21:37:19.4036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cby5maeHc0jVgCHJOQvsWGwz9TwhtS+X8Buxe6VlunEosAoa8crXKO6xUMTSBKiN4sfU5E8P+zp1zXl3bIH/T0qwtsBNPxvcAySkoN68Owg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4379 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-29_14,2024-01-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401290159 X-Proofpoint-ORIG-GUID: WXbko5dgxk3RP2geiIt4wn-6z_ZCofl3 X-Proofpoint-GUID: WXbko5dgxk3RP2geiIt4wn-6z_ZCofl3 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi Jose, > > On Mon, Jan 29, 2024 at 07:50:33PM +0100, Jose E. Marchesi wrote: >>=20 >> Ok today is not my day. >>=20 >> 1. This ought to be a [COMMITTED]. >>=20 >> 2. The patch I pushed vandalized bfd.texi with this unintended thunk, >> which I just have reverted. >>=20 >> diff --git a/bfd/doc/bfd.texi b/bfd/doc/bfd.texi >> index 60061d52b6e..e177100561f 100644 >> --- a/bfd/doc/bfd.texi >> +++ b/bfd/doc/bfd.texi >> @@ -199,7 +199,6 @@ IEEE-695. >> * typedef bfd:: >> * Error reporting:: >> * Initialization:: >> -* Threading:: >> * Miscellaneous:: >> * Memory Usage:: >> * Sections:: >>=20 >> My apoloGITes. > > Sorry for piling on your already bad day, but it seems that although > this fixed the binutils build, the gdb build still seems broken. When > sim is enabled you'll get: > > ../../binutils-gdb/sim/bpf/bpf-sim.c: In function =E2=80=98execute=E2=80= =99: > ../../binutils-gdb/sim/bpf/bpf-sim.c:946:10: error: =E2=80=98BPF_INSN_LDI= NDDW=E2=80=99 undeclared (first use in this function); did you mean =E2=80= =98BPF_INSN_LDINDW=E2=80=99? > 946 | case BPF_INSN_LDINDDW: > | ^~~~~~~~~~~~~~~~ > | BPF_INSN_LDINDW > ../../binutils-gdb/sim/bpf/bpf-sim.c:946:10: note: each undeclared identi= fier is reported only once for each function it appears in > ../../binutils-gdb/sim/bpf/bpf-sim.c:971:10: error: =E2=80=98BPF_INSN_LDA= BSDW=E2=80=99 undeclared (first use in this function); did you mean =E2=80= =98BPF_INSN_LDABSW=E2=80=99? > 971 | case BPF_INSN_LDABSDW: > | ^~~~~~~~~~~~~~~~ > | BPF_INSN_LDABSW > make[2]: *** [Makefile:4250: bpf/bpf-sim.o] Error 1 > > See the state of various builders with the above commit at: > https://builder.sourceware.org/buildbot/#/changes/41472 > > Could you take a look and update sim/bpf/bpf-sim.c ? Fixed by 920d9f0b39e9e8e42134c0317e772dbb93cdf8c8. I had a case of --disable-sim configurity. Thanks for the headsup! > > Thanks, > > Mark > >> > There are no legacy ldind nor ldabs BPF instructions with BPF_SIZE_DW. >> > For some reason we were (incorrectly) supporting these. This patch >> > updates the opcodes so the instructions get removed and modifies the >> > GAS manual and testsuite accordingly. >> > >> > See discussion at >> > https://lore.kernel.org/bpf/110aad7a-f8a3-46ed-9fda-2f8ee54dcb89@linux= .dev >> > >> > Tested in bpf-uknonwn-none target, x86-64-linux-gnu host. >> > >> > include/ChangeLog: >> > >> > 2024-01-29 Jose E. Marchesi >> > >> > * opcode/bpf.h (enum bpf_insn_id): Remove BPF_INSN_LDINDDW and >> > BPF_INSN_LDABSDW instructions. >> > >> > opcodes/ChangeLog: >> > >> > 2024-01-29 Jose E. Marchesi >> > >> > * bpf-opc.c (bpf_opcodes): Remove BPF_INSN_LDINDDW and >> > BPF_INSN_LDABSDW instructions. >> > >> > gas/ChangeLog: >> > >> > 2024-01-29 Jose E. Marchesi >> > >> > * doc/c-bpf.texi (BPF Instructions): There is no indirect 64-bit >> > load instruction. >> > (BPF Instructions): There is no absolute 64-bit load instruction. >> > * testsuite/gas/bpf/mem.s: Update test accordingly. >> > * testsuite/gas/bpf/mem-be-pseudoc.d: Likewise. >> > * testsuite/gas/bpf/mem-be.d: Likewise. >> > * testsuite/gas/bpf/mem-pseudoc.d: Likewise. >> > * testsuite/gas/bpf/mem-pseudoc.s: Likewise. >> > * testsuite/gas/bpf/mem.d: Likewise. >> > * testsuite/gas/bpf/mem.s: Likewise. >> > --- >> > bfd/doc/bfd.texi | 1 - >> > gas/ChangeLog | 13 ++++++++ >> > gas/doc/c-bpf.texi | 8 ----- >> > gas/testsuite/gas/bpf/mem-be-pseudoc.d | 43 ++++++++++++------------- >> > gas/testsuite/gas/bpf/mem-be.d | 44 ++++++++++++-------------= - >> > gas/testsuite/gas/bpf/mem-pseudoc.d | 43 ++++++++++++------------- >> > gas/testsuite/gas/bpf/mem-pseudoc.s | 3 -- >> > gas/testsuite/gas/bpf/mem.d | 44 ++++++++++++-------------= - >> > gas/testsuite/gas/bpf/mem.s | 2 -- >> > include/ChangeLog | 5 +++ >> > include/opcode/bpf.h | 4 +-- >> > opcodes/ChangeLog | 5 +++ >> > opcodes/bpf-opc.c | 4 --- >> > 13 files changed, 107 insertions(+), 112 deletions(-) >> > >> > diff --git a/bfd/doc/bfd.texi b/bfd/doc/bfd.texi >> > index 60061d52b6e..e177100561f 100644 >> > --- a/bfd/doc/bfd.texi >> > +++ b/bfd/doc/bfd.texi >> > @@ -199,7 +199,6 @@ IEEE-695. >> > * typedef bfd:: >> > * Error reporting:: >> > * Initialization:: >> > -* Threading:: >> > * Miscellaneous:: >> > * Memory Usage:: >> > * Sections:: >> > diff --git a/gas/ChangeLog b/gas/ChangeLog >> > index 7d390dbdce8..b1c8d09bf1b 100644 >> > --- a/gas/ChangeLog >> > +++ b/gas/ChangeLog >> > @@ -1,3 +1,16 @@ >> > +2024-01-29 Jose E. Marchesi >> > + >> > + * doc/c-bpf.texi (BPF Instructions): There is no indirect 64-bit >> > + load instruction. >> > + (BPF Instructions): There is no absolute 64-bit load instruction. >> > + * testsuite/gas/bpf/mem.s: Update test accordingly. >> > + * testsuite/gas/bpf/mem-be-pseudoc.d: Likewise. >> > + * testsuite/gas/bpf/mem-be.d: Likewise. >> > + * testsuite/gas/bpf/mem-pseudoc.d: Likewise. >> > + * testsuite/gas/bpf/mem-pseudoc.s: Likewise. >> > + * testsuite/gas/bpf/mem.d: Likewise. >> > + * testsuite/gas/bpf/mem.s: Likewise. >> > + >> > 2024-01-15 Nick Clifton >> > =20 >> > * configure: Regenerate. >> > diff --git a/gas/doc/c-bpf.texi b/gas/doc/c-bpf.texi >> > index db8cd1115fd..d99538f16a9 100644 >> > --- a/gas/doc/c-bpf.texi >> > +++ b/gas/doc/c-bpf.texi >> > @@ -451,10 +451,6 @@ tree for more information. >> > Absolute loads: >> > =20 >> > @table @code >> > -@item ldabsdw imm32 >> > -@itemx r0 =3D *(u64 *) skb[imm32] >> > -Absolute 64-bit load. >> > - >> > @item ldabsw imm32 >> > @itemx r0 =3D *(u32 *) skb[imm32] >> > Absolute 32-bit load. >> > @@ -471,10 +467,6 @@ Absolute 8-bit load. >> > Indirect loads: >> > =20 >> > @table @code >> > -@item ldinddw rs, imm32 >> > -@itemx r0 =3D *(u64 *) skb[rs + imm32] >> > -Indirect 64-bit load. >> > - >> > @item ldindw rs, imm32 >> > @itemx r0 =3D *(u32 *) skb[rs + imm32] >> > Indirect 32-bit load. >> > diff --git a/gas/testsuite/gas/bpf/mem-be-pseudoc.d b/gas/testsuite/ga= s/bpf/mem-be-pseudoc.d >> > index 3d40567223f..b7715c463a2 100644 >> > --- a/gas/testsuite/gas/bpf/mem-be-pseudoc.d >> > +++ b/gas/testsuite/gas/bpf/mem-be-pseudoc.d >> > @@ -11,26 +11,23 @@ Disassembly of section .text: >> > 0: 20 00 00 00 00 00 be ef r0=3D\*\(u32\*\)skb\[0xbeef\] >> > 8: 28 00 00 00 00 00 be ef r0=3D\*\(u16\*\)skb\[0xbeef\] >> > 10: 30 00 00 00 00 00 be ef r0=3D\*\(u8\*\)skb\[0xbeef\] >> > - 18: 38 00 00 00 00 00 be ef r0=3D\*\(u64\*\)skb\[0xbeef\] >> > - 20: 40 03 00 00 00 00 be ef r0=3D\*\(u32\*\)skb\[r3\+0xbeef\] >> > - 28: 48 05 00 00 00 00 be ef r0=3D\*\(u16\*\)skb\[r5\+0xbeef\] >> > - 30: 50 07 00 00 00 00 be ef r0=3D\*\(u8\*\)skb\[r7\+0xbeef\] >> > - 38: 58 09 00 00 00 00 be ef r0=3D\*\(u64\*\)skb\[r9\+0xbeef\] >> > - 40: 61 21 7e ef 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x7eef\) >> > - 48: 69 21 7e ef 00 00 00 00 r2=3D\*\(u16\*\)\(r1\+0x7eef\) >> > - 50: 71 21 7e ef 00 00 00 00 r2=3D\*\(u8\*\)\(r1\+0x7eef\) >> > - 58: 79 21 ff fe 00 00 00 00 r2=3D\*\(u64\*\)\(r1\+0xfffe\) >> > - 60: 63 12 7e ef 00 00 00 00 \*\(u32\*\)\(r1\+0x7eef\)=3Dr2 >> > - 68: 6b 12 7e ef 00 00 00 00 \*\(u16\*\)\(r1\+0x7eef\)=3Dr2 >> > - 70: 73 12 7e ef 00 00 00 00 \*\(u8\*\)\(r1\+0x7eef\)=3Dr2 >> > - 78: 7b 12 ff fe 00 00 00 00 \*\(u64\*\)\(r1\+0xfffe\)=3Dr2 >> > - 80: 72 10 7e ef 11 22 33 44 \*\(u8\*\)\(r1\+0x7eef\)=3D0x11223344 >> > - 88: 6a 10 7e ef 11 22 33 44 \*\(u16\*\)\(r1\+0x7eef\)=3D0x11223344 >> > - 90: 62 10 7e ef 11 22 33 44 \*\(u32\*\)\(r1\+0x7eef\)=3D0x11223344 >> > - 98: 7a 10 ff fe 11 22 33 44 \*\(u64\*\)\(r1\+0xfffe\)=3D0x11223344 >> > - a0: 81 21 7e ef 00 00 00 00 r2=3D\*\(s32\*\)\(r1\+0x7eef\) >> > - a8: 89 21 7e ef 00 00 00 00 r2=3D\*\(s16\*\)\(r1\+0x7eef\) >> > - b0: 91 21 7e ef 00 00 00 00 r2=3D\*\(s8\*\)\(r1\+0x7eef\) >> > - b8: 99 21 7e ef 00 00 00 00 r2=3D\*\(s64\*\)\(r1\+0x7eef\) >> > - c0: 58 05 00 00 00 00 00 00 r0=3D\*\(u64\*\)skb\[r5\+0x0\] >> > - c8: 61 21 00 00 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x0\) >> > + 18: 40 03 00 00 00 00 be ef r0=3D\*\(u32\*\)skb\[r3\+0xbeef\] >> > + 20: 48 05 00 00 00 00 be ef r0=3D\*\(u16\*\)skb\[r5\+0xbeef\] >> > + 28: 50 07 00 00 00 00 be ef r0=3D\*\(u8\*\)skb\[r7\+0xbeef\] >> > + 30: 61 21 7e ef 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x7eef\) >> > + 38: 69 21 7e ef 00 00 00 00 r2=3D\*\(u16\*\)\(r1\+0x7eef\) >> > + 40: 71 21 7e ef 00 00 00 00 r2=3D\*\(u8\*\)\(r1\+0x7eef\) >> > + 48: 79 21 ff fe 00 00 00 00 r2=3D\*\(u64\*\)\(r1\+0xfffe\) >> > + 50: 63 12 7e ef 00 00 00 00 \*\(u32\*\)\(r1\+0x7eef\)=3Dr2 >> > + 58: 6b 12 7e ef 00 00 00 00 \*\(u16\*\)\(r1\+0x7eef\)=3Dr2 >> > + 60: 73 12 7e ef 00 00 00 00 \*\(u8\*\)\(r1\+0x7eef\)=3Dr2 >> > + 68: 7b 12 ff fe 00 00 00 00 \*\(u64\*\)\(r1\+0xfffe\)=3Dr2 >> > + 70: 72 10 7e ef 11 22 33 44 \*\(u8\*\)\(r1\+0x7eef\)=3D0x11223344 >> > + 78: 6a 10 7e ef 11 22 33 44 \*\(u16\*\)\(r1\+0x7eef\)=3D0x11223344 >> > + 80: 62 10 7e ef 11 22 33 44 \*\(u32\*\)\(r1\+0x7eef\)=3D0x11223344 >> > + 88: 7a 10 ff fe 11 22 33 44 \*\(u64\*\)\(r1\+0xfffe\)=3D0x11223344 >> > + 90: 81 21 7e ef 00 00 00 00 r2=3D\*\(s32\*\)\(r1\+0x7eef\) >> > + 98: 89 21 7e ef 00 00 00 00 r2=3D\*\(s16\*\)\(r1\+0x7eef\) >> > + a0: 91 21 7e ef 00 00 00 00 r2=3D\*\(s8\*\)\(r1\+0x7eef\) >> > + a8: 99 21 7e ef 00 00 00 00 r2=3D\*\(s64\*\)\(r1\+0x7eef\) >> > + b0: 61 21 00 00 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x0\) >> > diff --git a/gas/testsuite/gas/bpf/mem-be.d b/gas/testsuite/gas/bpf/me= m-be.d >> > index cd7b35c60a3..fc71cbda9e1 100644 >> > --- a/gas/testsuite/gas/bpf/mem-be.d >> > +++ b/gas/testsuite/gas/bpf/mem-be.d >> > @@ -11,26 +11,24 @@ Disassembly of section .text: >> > 0: 20 00 00 00 00 00 be ef ldabsw 0xbeef >> > 8: 28 00 00 00 00 00 be ef ldabsh 0xbeef >> > 10: 30 00 00 00 00 00 be ef ldabsb 0xbeef >> > - 18: 38 00 00 00 00 00 be ef ldabsdw 0xbeef >> > - 20: 40 03 00 00 00 00 be ef ldindw %r3,0xbeef >> > - 28: 48 05 00 00 00 00 be ef ldindh %r5,0xbeef >> > - 30: 50 07 00 00 00 00 be ef ldindb %r7,0xbeef >> > - 38: 58 09 00 00 00 00 be ef ldinddw %r9,0xbeef >> > - 40: 61 21 7e ef 00 00 00 00 ldxw %r2,\[%r1\+0x7eef\] >> > - 48: 69 21 7e ef 00 00 00 00 ldxh %r2,\[%r1\+0x7eef\] >> > - 50: 71 21 7e ef 00 00 00 00 ldxb %r2,\[%r1\+0x7eef\] >> > - 58: 79 21 ff fe 00 00 00 00 ldxdw %r2,\[%r1\+0xfffe\] >> > - 60: 63 12 7e ef 00 00 00 00 stxw \[%r1\+0x7eef\],%r2 >> > - 68: 6b 12 7e ef 00 00 00 00 stxh \[%r1\+0x7eef\],%r2 >> > - 70: 73 12 7e ef 00 00 00 00 stxb \[%r1\+0x7eef\],%r2 >> > - 78: 7b 12 ff fe 00 00 00 00 stxdw \[%r1\+0xfffe\],%r2 >> > - 80: 72 10 7e ef 11 22 33 44 stb \[%r1\+0x7eef\],0x11223344 >> > - 88: 6a 10 7e ef 11 22 33 44 sth \[%r1\+0x7eef\],0x11223344 >> > - 90: 62 10 7e ef 11 22 33 44 stw \[%r1\+0x7eef\],0x11223344 >> > - 98: 7a 10 ff fe 11 22 33 44 stdw \[%r1\+0xfffe\],0x11223344 >> > - a0: 81 21 7e ef 00 00 00 00 ldxsw %r2,\[%r1\+0x7eef\] >> > - a8: 89 21 7e ef 00 00 00 00 ldxsh %r2,\[%r1\+0x7eef\] >> > - b0: 91 21 7e ef 00 00 00 00 ldxsb %r2,\[%r1\+0x7eef\] >> > - b8: 99 21 7e ef 00 00 00 00 ldxsdw %r2,\[%r1\+0x7eef\] >> > - c0: 79 21 00 00 00 00 00 00 ldxdw %r2,\[%r1\+0x0\] >> > - c8: 40 03 00 00 00 00 00 00 ldindw %r3,0x0 >> > + 18: 40 03 00 00 00 00 be ef ldindw %r3,0xbeef >> > + 20: 48 05 00 00 00 00 be ef ldindh %r5,0xbeef >> > + 28: 50 07 00 00 00 00 be ef ldindb %r7,0xbeef >> > + 30: 61 21 7e ef 00 00 00 00 ldxw %r2,\[%r1\+0x7eef\] >> > + 38: 69 21 7e ef 00 00 00 00 ldxh %r2,\[%r1\+0x7eef\] >> > + 40: 71 21 7e ef 00 00 00 00 ldxb %r2,\[%r1\+0x7eef\] >> > + 48: 79 21 ff fe 00 00 00 00 ldxdw %r2,\[%r1\+0xfffe\] >> > + 50: 63 12 7e ef 00 00 00 00 stxw \[%r1\+0x7eef\],%r2 >> > + 58: 6b 12 7e ef 00 00 00 00 stxh \[%r1\+0x7eef\],%r2 >> > + 60: 73 12 7e ef 00 00 00 00 stxb \[%r1\+0x7eef\],%r2 >> > + 68: 7b 12 ff fe 00 00 00 00 stxdw \[%r1\+0xfffe\],%r2 >> > + 70: 72 10 7e ef 11 22 33 44 stb \[%r1\+0x7eef\],0x11223344 >> > + 78: 6a 10 7e ef 11 22 33 44 sth \[%r1\+0x7eef\],0x11223344 >> > + 80: 62 10 7e ef 11 22 33 44 stw \[%r1\+0x7eef\],0x11223344 >> > + 88: 7a 10 ff fe 11 22 33 44 stdw \[%r1\+0xfffe\],0x11223344 >> > + 90: 81 21 7e ef 00 00 00 00 ldxsw %r2,\[%r1\+0x7eef\] >> > + 98: 89 21 7e ef 00 00 00 00 ldxsh %r2,\[%r1\+0x7eef\] >> > + a0: 91 21 7e ef 00 00 00 00 ldxsb %r2,\[%r1\+0x7eef\] >> > + a8: 99 21 7e ef 00 00 00 00 ldxsdw %r2,\[%r1\+0x7eef\] >> > + b0: 79 21 00 00 00 00 00 00 ldxdw %r2,\[%r1\+0x0\] >> > + b8: 40 03 00 00 00 00 00 00 ldindw %r3,0x0 >> > diff --git a/gas/testsuite/gas/bpf/mem-pseudoc.d b/gas/testsuite/gas/b= pf/mem-pseudoc.d >> > index 7c37c16b6b8..b704de51f8f 100644 >> > --- a/gas/testsuite/gas/bpf/mem-pseudoc.d >> > +++ b/gas/testsuite/gas/bpf/mem-pseudoc.d >> > @@ -11,26 +11,23 @@ Disassembly of section .text: >> > 0: 20 00 00 00 ef be 00 00 r0=3D\*\(u32\*\)skb\[0xbeef\] >> > 8: 28 00 00 00 ef be 00 00 r0=3D\*\(u16\*\)skb\[0xbeef\] >> > 10: 30 00 00 00 ef be 00 00 r0=3D\*\(u8\*\)skb\[0xbeef\] >> > - 18: 38 00 00 00 ef be 00 00 r0=3D\*\(u64\*\)skb\[0xbeef\] >> > - 20: 40 30 00 00 ef be 00 00 r0=3D\*\(u32\*\)skb\[r3\+0xbeef\] >> > - 28: 48 50 00 00 ef be 00 00 r0=3D\*\(u16\*\)skb\[r5\+0xbeef\] >> > - 30: 50 70 00 00 ef be 00 00 r0=3D\*\(u8\*\)skb\[r7\+0xbeef\] >> > - 38: 58 90 00 00 ef be 00 00 r0=3D\*\(u64\*\)skb\[r9\+0xbeef\] >> > - 40: 61 12 ef 7e 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x7eef\) >> > - 48: 69 12 ef 7e 00 00 00 00 r2=3D\*\(u16\*\)\(r1\+0x7eef\) >> > - 50: 71 12 ef 7e 00 00 00 00 r2=3D\*\(u8\*\)\(r1\+0x7eef\) >> > - 58: 79 12 fe ff 00 00 00 00 r2=3D\*\(u64\*\)\(r1\+0xfffe\) >> > - 60: 63 21 ef 7e 00 00 00 00 \*\(u32\*\)\(r1\+0x7eef\)=3Dr2 >> > - 68: 6b 21 ef 7e 00 00 00 00 \*\(u16\*\)\(r1\+0x7eef\)=3Dr2 >> > - 70: 73 21 ef 7e 00 00 00 00 \*\(u8\*\)\(r1\+0x7eef\)=3Dr2 >> > - 78: 7b 21 fe ff 00 00 00 00 \*\(u64\*\)\(r1\+0xfffe\)=3Dr2 >> > - 80: 72 01 ef 7e 44 33 22 11 \*\(u8\*\)\(r1\+0x7eef\)=3D0x11223344 >> > - 88: 6a 01 ef 7e 44 33 22 11 \*\(u16\*\)\(r1\+0x7eef\)=3D0x11223344 >> > - 90: 62 01 ef 7e 44 33 22 11 \*\(u32\*\)\(r1\+0x7eef\)=3D0x11223344 >> > - 98: 7a 01 fe ff 44 33 22 11 \*\(u64\*\)\(r1\+0xfffe\)=3D0x11223344 >> > - a0: 81 12 ef 7e 00 00 00 00 r2=3D\*\(s32\*\)\(r1\+0x7eef\) >> > - a8: 89 12 ef 7e 00 00 00 00 r2=3D\*\(s16\*\)\(r1\+0x7eef\) >> > - b0: 91 12 ef 7e 00 00 00 00 r2=3D\*\(s8\*\)\(r1\+0x7eef\) >> > - b8: 99 12 ef 7e 00 00 00 00 r2=3D\*\(s64\*\)\(r1\+0x7eef\) >> > - c0: 58 50 00 00 00 00 00 00 r0=3D\*\(u64\*\)skb\[r5\+0x0\] >> > - c8: 61 12 00 00 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x0\) >> > + 18: 40 30 00 00 ef be 00 00 r0=3D\*\(u32\*\)skb\[r3\+0xbeef\] >> > + 20: 48 50 00 00 ef be 00 00 r0=3D\*\(u16\*\)skb\[r5\+0xbeef\] >> > + 28: 50 70 00 00 ef be 00 00 r0=3D\*\(u8\*\)skb\[r7\+0xbeef\] >> > + 30: 61 12 ef 7e 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x7eef\) >> > + 38: 69 12 ef 7e 00 00 00 00 r2=3D\*\(u16\*\)\(r1\+0x7eef\) >> > + 40: 71 12 ef 7e 00 00 00 00 r2=3D\*\(u8\*\)\(r1\+0x7eef\) >> > + 48: 79 12 fe ff 00 00 00 00 r2=3D\*\(u64\*\)\(r1\+0xfffe\) >> > + 50: 63 21 ef 7e 00 00 00 00 \*\(u32\*\)\(r1\+0x7eef\)=3Dr2 >> > + 58: 6b 21 ef 7e 00 00 00 00 \*\(u16\*\)\(r1\+0x7eef\)=3Dr2 >> > + 60: 73 21 ef 7e 00 00 00 00 \*\(u8\*\)\(r1\+0x7eef\)=3Dr2 >> > + 68: 7b 21 fe ff 00 00 00 00 \*\(u64\*\)\(r1\+0xfffe\)=3Dr2 >> > + 70: 72 01 ef 7e 44 33 22 11 \*\(u8\*\)\(r1\+0x7eef\)=3D0x11223344 >> > + 78: 6a 01 ef 7e 44 33 22 11 \*\(u16\*\)\(r1\+0x7eef\)=3D0x11223344 >> > + 80: 62 01 ef 7e 44 33 22 11 \*\(u32\*\)\(r1\+0x7eef\)=3D0x11223344 >> > + 88: 7a 01 fe ff 44 33 22 11 \*\(u64\*\)\(r1\+0xfffe\)=3D0x11223344 >> > + 90: 81 12 ef 7e 00 00 00 00 r2=3D\*\(s32\*\)\(r1\+0x7eef\) >> > + 98: 89 12 ef 7e 00 00 00 00 r2=3D\*\(s16\*\)\(r1\+0x7eef\) >> > + a0: 91 12 ef 7e 00 00 00 00 r2=3D\*\(s8\*\)\(r1\+0x7eef\) >> > + a8: 99 12 ef 7e 00 00 00 00 r2=3D\*\(s64\*\)\(r1\+0x7eef\) >> > + b0: 61 12 00 00 00 00 00 00 r2=3D\*\(u32\*\)\(r1\+0x0\) >> > diff --git a/gas/testsuite/gas/bpf/mem-pseudoc.s b/gas/testsuite/gas/b= pf/mem-pseudoc.s >> > index 823083d498a..19907753916 100644 >> > --- a/gas/testsuite/gas/bpf/mem-pseudoc.s >> > +++ b/gas/testsuite/gas/bpf/mem-pseudoc.s >> > @@ -4,11 +4,9 @@ >> > r0 =3D *(u32 *)skb[48879] >> > r0 =3D *(u16 *)skb[48879] >> > r0 =3D *(u8 *)skb[48879] >> > - r0 =3D *(u64 *)skb[48879] >> > r0 =3D *(u32 *)skb[r3 + 0xbeef] >> > r0 =3D *(u16 *)skb[r5 + 0xbeef] >> > r0 =3D *(u8 *)skb[r7 + 0xbeef] >> > - r0 =3D *(u64 *)skb[r9 + 0xbeef] >> > r2 =3D *(u32 *)(r1 + 32495) >> > r2 =3D *(u16 *)(r1 + 32495) >> > r2 =3D *(u8 *)(r1 + 32495) >> > @@ -25,5 +23,4 @@ >> > r2 =3D *(s16*)(r1+0x7eef) >> > r2 =3D *(s8*)(r1+0x7eef) >> > r2 =3D *(s64*)(r1+0x7eef) >> > - r0 =3D *(u64 *)skb[r5 + 0] >> > r2 =3D *(u32 *)(r1 + 0) >> > diff --git a/gas/testsuite/gas/bpf/mem.d b/gas/testsuite/gas/bpf/mem.d >> > index 9a1e7095df0..e51ebb103fb 100644 >> > --- a/gas/testsuite/gas/bpf/mem.d >> > +++ b/gas/testsuite/gas/bpf/mem.d >> > @@ -11,26 +11,24 @@ Disassembly of section .text: >> > 0: 20 00 00 00 ef be 00 00 ldabsw 0xbeef >> > 8: 28 00 00 00 ef be 00 00 ldabsh 0xbeef >> > 10: 30 00 00 00 ef be 00 00 ldabsb 0xbeef >> > - 18: 38 00 00 00 ef be 00 00 ldabsdw 0xbeef >> > - 20: 40 30 00 00 ef be 00 00 ldindw %r3,0xbeef >> > - 28: 48 50 00 00 ef be 00 00 ldindh %r5,0xbeef >> > - 30: 50 70 00 00 ef be 00 00 ldindb %r7,0xbeef >> > - 38: 58 90 00 00 ef be 00 00 ldinddw %r9,0xbeef >> > - 40: 61 12 ef 7e 00 00 00 00 ldxw %r2,\[%r1\+0x7eef\] >> > - 48: 69 12 ef 7e 00 00 00 00 ldxh %r2,\[%r1\+0x7eef\] >> > - 50: 71 12 ef 7e 00 00 00 00 ldxb %r2,\[%r1\+0x7eef\] >> > - 58: 79 12 fe ff 00 00 00 00 ldxdw %r2,\[%r1\+0xfffe\] >> > - 60: 63 21 ef 7e 00 00 00 00 stxw \[%r1\+0x7eef\],%r2 >> > - 68: 6b 21 ef 7e 00 00 00 00 stxh \[%r1\+0x7eef\],%r2 >> > - 70: 73 21 ef 7e 00 00 00 00 stxb \[%r1\+0x7eef\],%r2 >> > - 78: 7b 21 fe ff 00 00 00 00 stxdw \[%r1\+0xfffe\],%r2 >> > - 80: 72 01 ef 7e 44 33 22 11 stb \[%r1\+0x7eef\],0x11223344 >> > - 88: 6a 01 ef 7e 44 33 22 11 sth \[%r1\+0x7eef\],0x11223344 >> > - 90: 62 01 ef 7e 44 33 22 11 stw \[%r1\+0x7eef\],0x11223344 >> > - 98: 7a 01 fe ff 44 33 22 11 stdw \[%r1\+0xfffe\],0x11223344 >> > - a0: 81 12 ef 7e 00 00 00 00 ldxsw %r2,\[%r1\+0x7eef\] >> > - a8: 89 12 ef 7e 00 00 00 00 ldxsh %r2,\[%r1\+0x7eef\] >> > - b0: 91 12 ef 7e 00 00 00 00 ldxsb %r2,\[%r1\+0x7eef\] >> > - b8: 99 12 ef 7e 00 00 00 00 ldxsdw %r2,\[%r1\+0x7eef\] >> > - c0: 79 12 00 00 00 00 00 00 ldxdw %r2,\[%r1\+0x0\] >> > - c8: 40 30 00 00 00 00 00 00 ldindw %r3,0x0 >> > + 18: 40 30 00 00 ef be 00 00 ldindw %r3,0xbeef >> > + 20: 48 50 00 00 ef be 00 00 ldindh %r5,0xbeef >> > + 28: 50 70 00 00 ef be 00 00 ldindb %r7,0xbeef >> > + 30: 61 12 ef 7e 00 00 00 00 ldxw %r2,\[%r1\+0x7eef\] >> > + 38: 69 12 ef 7e 00 00 00 00 ldxh %r2,\[%r1\+0x7eef\] >> > + 40: 71 12 ef 7e 00 00 00 00 ldxb %r2,\[%r1\+0x7eef\] >> > + 48: 79 12 fe ff 00 00 00 00 ldxdw %r2,\[%r1\+0xfffe\] >> > + 50: 63 21 ef 7e 00 00 00 00 stxw \[%r1\+0x7eef\],%r2 >> > + 58: 6b 21 ef 7e 00 00 00 00 stxh \[%r1\+0x7eef\],%r2 >> > + 60: 73 21 ef 7e 00 00 00 00 stxb \[%r1\+0x7eef\],%r2 >> > + 68: 7b 21 fe ff 00 00 00 00 stxdw \[%r1\+0xfffe\],%r2 >> > + 70: 72 01 ef 7e 44 33 22 11 stb \[%r1\+0x7eef\],0x11223344 >> > + 78: 6a 01 ef 7e 44 33 22 11 sth \[%r1\+0x7eef\],0x11223344 >> > + 80: 62 01 ef 7e 44 33 22 11 stw \[%r1\+0x7eef\],0x11223344 >> > + 88: 7a 01 fe ff 44 33 22 11 stdw \[%r1\+0xfffe\],0x11223344 >> > + 90: 81 12 ef 7e 00 00 00 00 ldxsw %r2,\[%r1\+0x7eef\] >> > + 98: 89 12 ef 7e 00 00 00 00 ldxsh %r2,\[%r1\+0x7eef\] >> > + a0: 91 12 ef 7e 00 00 00 00 ldxsb %r2,\[%r1\+0x7eef\] >> > + a8: 99 12 ef 7e 00 00 00 00 ldxsdw %r2,\[%r1\+0x7eef\] >> > + b0: 79 12 00 00 00 00 00 00 ldxdw %r2,\[%r1\+0x0\] >> > + b8: 40 30 00 00 00 00 00 00 ldindw %r3,0x0 >> > diff --git a/gas/testsuite/gas/bpf/mem.s b/gas/testsuite/gas/bpf/mem.s >> > index adeda473bb8..1a10b595af0 100644 >> > --- a/gas/testsuite/gas/bpf/mem.s >> > +++ b/gas/testsuite/gas/bpf/mem.s >> > @@ -5,11 +5,9 @@ >> > ldabsw 0xbeef >> > ldabsh 0xbeef >> > ldabsb 0xbeef >> > - ldabsdw 0xbeef >> > ldindw %r3, 0xbeef >> > ldindh %r5, 0xbeef >> > ldindb %r7, 0xbeef >> > - ldinddw %r9, 0xbeef >> > ldxw %r2, [%r1+0x7eef] >> > ldxh %r2, [%r1+0x7eef] >> > ldxb %r2, [%r1+0x7eef] >> > diff --git a/include/ChangeLog b/include/ChangeLog >> > index 1c9477a022e..4b667bfa307 100644 >> > --- a/include/ChangeLog >> > +++ b/include/ChangeLog >> > @@ -1,3 +1,8 @@ >> > +2024-01-29 Jose E. Marchesi >> > + >> > + * opcode/bpf.h (enum bpf_insn_id): Remove BPF_INSN_LDINDDW and >> > + BPF_INSN_LDABSDW instructions. >> > + >> > 2024-01-15 Nick Clifton >> > =20 >> > * 2.42 branch point. >> > diff --git a/include/opcode/bpf.h b/include/opcode/bpf.h >> > index 61f1ec8a079..df1e3bd0918 100644 >> > --- a/include/opcode/bpf.h >> > +++ b/include/opcode/bpf.h >> > @@ -188,9 +188,9 @@ enum bpf_insn_id >> > BPF_INSN_ENDLE16, BPF_INSN_ENDLE32, BPF_INSN_ENDLE64, >> > BPF_INSN_ENDBE16, BPF_INSN_ENDBE32, BPF_INSN_ENDBE64, >> > /* Absolute load instructions. */ >> > - BPF_INSN_LDABSB, BPF_INSN_LDABSH, BPF_INSN_LDABSW, BPF_INSN_LDABSDW= , >> > + BPF_INSN_LDABSB, BPF_INSN_LDABSH, BPF_INSN_LDABSW, >> > /* Indirect load instructions. */ >> > - BPF_INSN_LDINDB, BPF_INSN_LDINDH, BPF_INSN_LDINDW, BPF_INSN_LDINDDW= , >> > + BPF_INSN_LDINDB, BPF_INSN_LDINDH, BPF_INSN_LDINDW, >> > /* Generic load instructions (to register.) */ >> > BPF_INSN_LDXB, BPF_INSN_LDXH, BPF_INSN_LDXW, BPF_INSN_LDXDW, >> > /* Generic signed load instructions. */ >> > diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog >> > index a83b68e4a55..4bc815780fd 100644 >> > --- a/opcodes/ChangeLog >> > +++ b/opcodes/ChangeLog >> > @@ -1,3 +1,8 @@ >> > +2024-01-29 Jose E. Marchesi >> > + >> > + * bpf-opc.c (bpf_opcodes): Remove BPF_INSN_LDINDDW and >> > + BPF_INSN_LDABSDW instructions. >> > + >> > 2024-01-15 Nick Clifton >> > =20 >> > * configure: Regenerate. >> > diff --git a/opcodes/bpf-opc.c b/opcodes/bpf-opc.c >> > index 750d048aae3..19e096501a2 100644 >> > --- a/opcodes/bpf-opc.c >> > +++ b/opcodes/bpf-opc.c >> > @@ -198,8 +198,6 @@ const struct bpf_opcode bpf_opcodes[] =3D >> > BPF_V1, BPF_CODE, BPF_CLASS_LD|BPF_SIZE_H|BPF_MODE_IND}, >> > {BPF_INSN_LDINDW, "ldindw%W%sr , %i32", "r0 =3D * ( u32 * ) skb [ %= sr %I32 ]", >> > BPF_V1, BPF_CODE, BPF_CLASS_LD|BPF_SIZE_W|BPF_MODE_IND}, >> > - {BPF_INSN_LDINDDW, "ldinddw%W%sr , %i32", "r0 =3D * ( u64 * ) skb [= %sr %I32 ]", >> > - BPF_V1, BPF_CODE, BPF_CLASS_LD|BPF_SIZE_DW|BPF_MODE_IND}, >> > =20 >> > /* Absolute load instructions, designed to be used in socket filter= s. */ >> > {BPF_INSN_LDABSB, "ldabsb%W%i32", "r0 =3D * ( u8 * ) skb [ %i32 ]", >> > @@ -208,8 +206,6 @@ const struct bpf_opcode bpf_opcodes[] =3D >> > BPF_V1, BPF_CODE, BPF_CLASS_LD|BPF_SIZE_H|BPF_MODE_ABS}, >> > {BPF_INSN_LDABSW, "ldabsw%W%i32", "r0 =3D * ( u32 * ) skb [ %i32 ]"= , >> > BPF_V1, BPF_CODE, BPF_CLASS_LD|BPF_SIZE_W|BPF_MODE_ABS}, >> > - {BPF_INSN_LDABSDW, "ldabsdw%W%i32", "r0 =3D * ( u64 * ) skb [ %i32 = ]", >> > - BPF_V1, BPF_CODE, BPF_CLASS_LD|BPF_SIZE_DW|BPF_MODE_ABS}, >> > =20 >> > /* Generic load instructions (to register.) */ >> > {BPF_INSN_LDXB, "ldxb%W%dr , [ %sr %o16 ]", "%dr =3D * ( u8 * ) ( %= sr %o16 )",