From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 780ED3858D33 for ; Tue, 21 Nov 2023 18:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 780ED3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 780ED3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700592930; cv=pass; b=f/ZyXxSun3Tj6xZ73mdgFoGEXDA0MDl7kyqCBWAEvfapZikDvqZ+Bk0kwQjGSTpHOkeRcjosPaG7Q08C3GZyFxGbEmbxTAT/wRHkuP63Vi3ctl4FFLDOir9lhFbmqqd9oOsnxZUTmmgcJAnE5mGizrjHkHwF3zSW9WMBRzHravs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700592930; c=relaxed/simple; bh=vIta5nY1jjlWKdEAuVfauxhB9dnv7tXneHVjI2hVYIE=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=BUe7m+bZVNKv6u9GqmNT3hVCVlVROx5RsynRsOiixwVMQ+/0dTv9uC0ZN+RYNFzLMjeukm+YO9MYsNU85e+uYnxjbn1NH4P1MV9zkdLNQ8QEAcnQlNInJeJLgypVyGCE1iNQfoi30/9iKzffsP2ie4JJl7ZII7xADQ0Er26V4pI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALITW1k002598 for ; Tue, 21 Nov 2023 18:55:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=9mUaJcoXNIeILfqgC78JtqIcNgknbIiFjDyy4T97nc0=; b=AYZDCMUG3mQXz1fWizJijP1Khb03mjpu+UVhgUBm875BEteYUnRhM2akSGO6pGkYUrUT BCANpWTz1/S8B3fN162MNDR7rg6BYDzgbFFjNLskNSszCtYvjfXWewmukfvlfO/KFLMN o01n85IudMesWvVcrdDOqpGDx499b4EjecOa4oSbFVXXDZBI1RMeJf3jQZKXuvmDvItP 2Ve4nZWFDwYKB3KvvBPnxMSArj3q+Ekup23CjKYvm/8Ht5aYUvfU7Z+kyUIGIhYfKhE9 z+pljvgYIPzpDe2ZneysMw9eUe1N4ZgDiJpyZCDah2KRWmoPDL99OmDWYEplbqFVsR82 MQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uentvdu3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 21 Nov 2023 18:55:27 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALHM91M040733 for ; Tue, 21 Nov 2023 18:55:26 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3uekq78sv6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 21 Nov 2023 18:55:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1CxTIuJbhiczzJAPz94DnIuh4j1PeUsk6x6mdBsylGnMhKoBmrrYYUX0y19KJvLS59GCOwJWWEnxus0f9l7GLbpu56w/4chMHjrqWOpXUqixX84F2a5WyQBPzQn5xtaWaAVAOBVX1ZnGSs0Ry95pqOUA2MQqlj1JPK2EZPqZjxg2Bbu8VUAK7NHU6N3QqOH4BnjYx8+/kI2Fr4Tg/yrIq/uBzbu2edNy5RCRnWJmcCVX0NSziHDYp6jYWnVbrbVjiPkS1enqMEKy2WglMzQL6SkN0IDiperzh/o4LeoyVNf0sCrbM1CBC3rfbOSc2Qfx0yXjt5leR5dvmFXLhcJDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9mUaJcoXNIeILfqgC78JtqIcNgknbIiFjDyy4T97nc0=; b=dcAYXFvo5DeamsQYohyk1nmwhC0JOVPW0xTVJJtEMz9vOasdCUvbsqorSlBXuLMiGAFE117rpRD/oZ8XlkBkLEe+gcQJfIF8bNeXrNTgbJioOPJNxSJpg/tmwTQoc1bXU1Mu2TSj+oq/cSEuGR+B05ZN25KKYjr0/BhcBFT4BrtsdZRltU/RyiA/6uVZ4eqkOvKmFtX8rpB0TbRvrQpGJmNDvVu9kVqWZJQ2geCDy4Kdw4/3C+erXOIczoMtgNomkNdrsp+29FIg4U8uKzdb//weTqDin0tQDvLTyNOS2yYLdmxs0cdxAFKbaPKmItOVYhzq4PYc7oJrLQgj0njk/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mUaJcoXNIeILfqgC78JtqIcNgknbIiFjDyy4T97nc0=; b=TC5F80DeFPkedJCVxv8x4a7cX4GqbX5C69B49zXmJVZx0xDrZShNchD4N+Ri4sfc2CiCeyedx+67NpWsnQP4+/sJpJiENaTij4XyO+9y+1q7ckv+ohBYMddUbQO7SK6mUOMv+SPlGHuLXtRBtuNcXOt1TS/tXciMrfzsPLZ167k= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by PH7PR10MB6226.namprd10.prod.outlook.com (2603:10b6:510:1f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 18:55:23 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::fec4:3a58:6118:aab2]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::fec4:3a58:6118:aab2%6]) with mapi id 15.20.7002.028; Tue, 21 Nov 2023 18:55:23 +0000 References: <20231121173447.29928-1-cupertino.miranda@oracle.com> <87wmubknkt.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: "Jose E. Marchesi" Cc: binutils@sourceware.org, david.faust@oracle.com Subject: Re: [PATCH] bpf: Fixed register parsing disambiguating with possible symbol. In-reply-to: <87wmubknkt.fsf@oracle.com> Date: Tue, 21 Nov 2023 18:55:18 +0000 Message-ID: <87h6lfj5rd.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AS4P195CA0008.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:5e2::13) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|PH7PR10MB6226:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d8857d7-0af7-40d0-30df-08dbeac36a95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NmSabLcauaIPoU17fO7v0BdhUPcnqUGrZGQiFon8oq6f1aU9o0ccyFtaWNW6XAYUMAmJwV8Vv1preziPuZqGUCgRvpVjn8gohkyn+QL0EZE1IHPFunPmVDM/qKuKceowTsHmyZb+XjQhxgrUIbSv2INFbhFgefb6SqCIho/q1fYBECotXgLxjeq3+BRzbmBh5mTuXDR37fVyQHIb3chWlAiPkif4zSreuAc90kd1/DUlxbKKg8Etdqw3X4lCPhi5Zhj7DrI4jjSQ/m1r0jshfpniuPDdrANoNmy6a0Fwfy0kviZkYYf/RtSUMU/EW2GDbdc/7XlQM4hxGzJGgvGd41Eg2P9rxknfSD1HUo5VbzcEZ4wNDA7xJI4NWXy9GyAJ+eK910UMonw4vo2+KK2oAlgfMLtxe8n/B5rmIubieTNm03Di6Ko7kkjbxpTysQxlGXnp5zBr6oGXWldDWTQmtQ0fJIZ9RKUdsS0cko5lxvOwro6mectu2jJ9X7P2eN2deK+wBzz151MgDqreYSWh/6+HHzd8ox7rFOVhFhGIXsA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(366004)(39860400002)(346002)(396003)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(2906002)(6512007)(37006003)(478600001)(6486002)(2616005)(107886003)(66556008)(66946007)(66476007)(6636002)(316002)(6666004)(38100700002)(6506007)(83380400001)(4326008)(6862004)(8676002)(8936002)(44832011)(86362001)(5660300002)(41300700001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QIcMN+3n8IfULFwD9DvNW38vSXbgJVNQo1Ut9hbBsTxdlvhokbJ5yb6r4DER?= =?us-ascii?Q?V9vPQssAd3pTtbTIORI2ZJT004mPB1ErzdrIufOlqMrunveRiZfw3llX8LMA?= =?us-ascii?Q?zA08KggqC8C6YUBOl8YawMWfon/VCyKp/9YeXyL3eta6k+d4V2Z5qUjizQtG?= =?us-ascii?Q?ktbKbKdD0ql3rVhgRdq+1hnN3CANxIpbEcDJyAr7PZsuvRBdmztEMqHyETlC?= =?us-ascii?Q?WGO3jCjsvy41+B86C/3gKZgHIJeOdGk8ReK4ZzXNhkBEFHQKTWG1ezXx7VLp?= =?us-ascii?Q?Ygj774WLb9kYOh9jxqi7gv/ub+SOpuI3DX9uf2cSTL5R3NMYr9i0WbwgFr47?= =?us-ascii?Q?roVZVLebfXPQG7cwiJLAyQsWnO3ZgQuncs/7cdEXpaiazI3gdf915q0aZvGK?= =?us-ascii?Q?6feYpc1/H9NALynAt5RxWBzXl/5cj+cfyqaXywBVKfAYZHGuZlZYsDFeZQib?= =?us-ascii?Q?stfxIBaX3JDQORkQYZp4XVO2yS5Eq7ocCE36gX1R6cjjeq9CG7kf0pSaOxAd?= =?us-ascii?Q?jDL0x2GALgfs3kSMKacSGNYadbXAXRaAprTT6O3Chbz2OmUBYvp+aqBUc0AY?= =?us-ascii?Q?dMMh4CBycozFsOJaPQM6ZPj3+4IxOdUzsd1l+rI3YaWpdn1j57dwJmIurIbU?= =?us-ascii?Q?ZdSm8Lb4BIpBFnLXpie1vgjrCpPSS+LozP1sSt/M6zjLlUlx6vWGxLeFrJrO?= =?us-ascii?Q?ik+lZ+ESj88/4bzo6noIQjgxy94KYOGYgf1ORElWLVroeEZoVBjwC66gX/lN?= =?us-ascii?Q?cdKpMMzhJlpWXhAWym5vslt3NjqkFy1LZWgCBJfxcAj8pH9SmhSKNtiKYROc?= =?us-ascii?Q?21bzL42yqxmbcPO9Qfq6tWG5AWsNfkqvGMckgZOQsTsr8HflA6iLcYnYte97?= =?us-ascii?Q?B3caqrZY00gnB5YTc+yqT4HwzwaYh0khRdRz5rDRyvRGBonEjhA2XygwWTmA?= =?us-ascii?Q?2TBFS41FZBRToN12r8e6tNYlEk+QMwq1z2rB8+WPvhHBqxrs2VYcpyCDEd49?= =?us-ascii?Q?qxA6FNWtRRwKbL6g+8DXoHHfIWiBYxconbyGhZ4A/S9SN6eXqNIGr8+lGnj0?= =?us-ascii?Q?BXqCiTowcUK1gGqTQeoDh9kUieu2FXmmPOOjfLmyVb6w6iCrUPEPK6p0okxe?= =?us-ascii?Q?mBAH5TOKkNY33OidVkIFEvWyOy8WXdLBt77eUZCsCHS+jcwUa5ZMdcBuWMU4?= =?us-ascii?Q?kGlGPdxP+jXai3/86EpJyf/0J18q5FhykBHdDzmAyhHWiSYiJd18i+J0WjhO?= =?us-ascii?Q?noOqj/cMeftdvX0S38IzvV4K2OXEEumzWb7TM2ANZJ7gFu8kflwAPJ3PXoEV?= =?us-ascii?Q?LX54/Ac791jv21XrLKmG9mBSTfo3vPWy/OtfPs8jHhDyoJhHyh/AIpIu8cSK?= =?us-ascii?Q?7ERok+Z8HcqZFu6f6vKoPo3n0xWeB8h+bCFxKlpPtBn3rd6UccY6uCi3s5SA?= =?us-ascii?Q?xidkajQ6hSFus71cv4QdecUh6r9uYqhPhRgdLpRvbBFRbxLIqESdU6j+MUW/?= =?us-ascii?Q?p4n1GzoLB95r7WSVESI9Cm4NNoWI56g6ziurF6xO2phhkaw480Vl2VQzpNZI?= =?us-ascii?Q?aIHRiv2UL8FZORkMCaB6bcD57MBVezn971mJJUyzr5bEMTxC5iH604I5/7/y?= =?us-ascii?Q?9X8NuygEX3zw8sTPXBwCrxg=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8n12bM8nuobZG8eTQyjry5e3UpPDnsktqZOvnp8jcrzzbV+0yF8lJAP7niq/+11bmoH1yTX7+Bp9MkqreC2JiwVlKJJmeX2HCR6g751tter63erZa3p8Je1JjQFR+SdbdFufH6e0ko5taIQClk0j9ddUYyfNtnmvuQ17N7dGygtrC1rrnLZo5GBn209lfacq1muayMDBW0PVbIEsK8VzAggh+wWCiLplBRuqtBrZApjFvBAiP+dhl8zNTnqH1YwBWBVzeY6N6muPtWjwpvsNzxlLdYGsMthhm+FV98PVA9y6vnENcmduIerwKDACBfMaq2+eEQiQm9gxa3s1t/xidl2hUBFwfhJg0I4VUUl04uLgiuJgWvyZIDalR+yjrznP6Ri0vPkYVbj4jaPArbJX6KU9AXBp/kgY1j+In6EScqz7LEN/PNCOwTfAmG+bDve5A4F6fYFeh0DYH5AwIDuOd6vTj9CCL2XrdfcoeEQDWJS76xK1WXG4jL5q/Hi7ZM1tE3RwsNbBT8ypHGC/fn2O5xZU5nI7g2DLYKy3Dx9WW4D1jtRJBJXmSSQH/dsEwh48OCVOPx6dI5BPFDHOo9Wi8gNVQNEToX4PcwR7OtTaNrhFWD2fSNclceMO/KBar5BMehT8Q2ZG7SGCDfqycmeiQxwp8TKJ14lpV+fjUfUi2n3LF8nO4XHolL8Zutpl8JYGkEMLGeXPyDz6GrNawSfyIUrQ3gVYb0YsvN0/gbiL+Bo/w4QSIMmmG/glz3WVZFzyp61g5k9kZWHHuGRUHIngUA== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d8857d7-0af7-40d0-30df-08dbeac36a95 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 18:55:23.2571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z5AZXV2AqR1craufdkkF/7xHWym1X/N972t5TSFmoDfaT65ns76b6cDMU0CNRYAXZpa1O9kRtcRHo34/46Np9rSu35W/0oYzIlkQoBpnu7w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6226 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_10,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 mlxlogscore=923 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210148 X-Proofpoint-ORIG-GUID: e_ie66TClI7iDMRRvyYlu4rgCNGnXt3l X-Proofpoint-GUID: e_ie66TClI7iDMRRvyYlu4rgCNGnXt3l X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks! Committed! Jose E. Marchesi writes: > Hi Cuper. > The patch is OK. > Thanks! > >> This changes parse_bpf_register to detect possible symbols that start with valid >> register name, however due some following characters are not. >> Also changed the regs-for-symbols-pseudo.s, adding some entries that >> should not error if parser is properly detecting the symbol. >> --- >> gas/config/tc-bpf.c | 4 ++++ >> gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s | 3 +++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c >> index 45abc3c9578..b6b1db47427 100644 >> --- a/gas/config/tc-bpf.c >> +++ b/gas/config/tc-bpf.c >> @@ -1300,6 +1300,10 @@ parse_bpf_register (char *s, char rw, uint8_t *regno) >> s += 1; >> } >> >> + /* If we are still parsing a name, it is not a register. */ >> + if (is_part_of_name (*s)) >> + return NULL; >> + >> return s; >> } >> >> diff --git a/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s b/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s >> index 693787d5479..9b75f275285 100644 >> --- a/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s >> +++ b/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s >> @@ -2,3 +2,6 @@ >> r2 = r3 ll >> r2 = r3+1 ll >> r2 = 1+r3 ll >> + r2 = r2d2 ll >> + r2 = r2d2+1 ll >> + r2 = 1+r2d2 ll