From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 62E8E3858D32 for ; Mon, 3 Oct 2022 09:59:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62E8E3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664791162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K515qt6WdzbIeUZbc5IpvQdg58g9dE67DHWTs6aGzYY=; b=Sf7WrxqwWpNMczwBzfrs94zsTP5BVltW36HzH3dk1lG8BFNuP/HQ2zMHYTwWRy1rs8tPF8 K30hbJWTltM7dGJ6ao0nOF+WQaUCC00jTTjdw9gdPJv8OQyDKdSOvRr4oUMye4Q/JBRo1F gXMaVhTd3Ffe6ao7rLrDlySp/gwttq0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-158-9cFZsW86MQSULap2ZhEO1g-1; Mon, 03 Oct 2022 05:59:21 -0400 X-MC-Unique: 9cFZsW86MQSULap2ZhEO1g-1 Received: by mail-wm1-f71.google.com with SMTP id y15-20020a1c4b0f000000b003b47578405aso2761015wma.5 for ; Mon, 03 Oct 2022 02:59:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=K515qt6WdzbIeUZbc5IpvQdg58g9dE67DHWTs6aGzYY=; b=KI2rQHi3pY1dMnTYV9n85R5yhi3Z1HIBougXTcb9JAPMmwpO3g8/LgVE9T2UlBDRDz SEJL50lf3hSenaZbngPHMlWjiI91O78o6IVLHw1gZ0g86yMXeZR9AVGid3qA6LpxbQrq IKChFbDmZg/HnRrTFPTFC9Ar/wTHm5ZOSp7MrJS0xNzfxt2Qfx1aOHz/3P2woUE5+Mjp BL+Wjd6CGt6+NBoLOXHeGEBWohwC0fmM+Zv4GbNit7+0ENTyfafEHVUBYdeoDKSJWiyc we4td7PUTfr+l+rT+fXoZHqt8LkIbqVe4iri/RnuZJq73fpxqX44vs2sYa11sNRnxyYE QAFA== X-Gm-Message-State: ACrzQf2MNMU59dT2WkRRnQmDBW/ZezRES46B36TE3FdbTIEUpQhs5uvk RVmfG5jRxFQKV80at78JoM74Kh0h9c1Q1QqJcdhWUpcmon2jbQp/LZgctnoGWLOYPZejtpUnum0 eUy1ZerVs/WuGTYGg6NaOFjDucbWxRss46r33smr3I9/NDmx6c4CrIg7NvM14iEUAaMU2wQ== X-Received: by 2002:adf:a28e:0:b0:22a:7428:3b04 with SMTP id s14-20020adfa28e000000b0022a74283b04mr12807415wra.75.1664791159624; Mon, 03 Oct 2022 02:59:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7h2GRFb0x1rbP+yd9ExXh3utfNnHNRjHliUFJKq1Fvy04FVoEXedSGC5FYTduuMlfURTwDvA== X-Received: by 2002:adf:a28e:0:b0:22a:7428:3b04 with SMTP id s14-20020adfa28e000000b0022a74283b04mr12807404wra.75.1664791159399; Mon, 03 Oct 2022 02:59:19 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id y14-20020adfe6ce000000b0022c96d3b6f2sm11758968wrm.54.2022.10.03.02.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 02:59:19 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI via Binutils , Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Cc: binutils@sourceware.org Subject: Re: [PATCH v2 0/6] RISC-V: Fix disassembler types and styles In-Reply-To: References: Date: Mon, 03 Oct 2022 10:59:18 +0100 Message-ID: <87h70lgrd5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tsukasa OI via Binutils writes: > Hello, > > This patchset fixes various typing and styling errors on the RISC-V > disassembler. I can't approve binutils patches. I've taken a look through this series, and other than the minor typo I spotted, this all looks good to me. Thanks for doing this. Andrew > > Previous Patchsets: > (2022-07-13) > (2022-08-03) > Tracker on GitHub: > > > > [Changes: v1 -> v2] > > - Added PATCH 5-6/6 after T-Head extensions are merged. > - Slightly improved the commit messages? > > > [Styling] > - Print real immediates with the `immediate' style (PATCH 1/6) > - Print comma and tabs with the `text' style (PATCH 4/6) > - Print T-Head literal operand with `immediate' style (PATCH 6/6) > [Typing on printf] > - Fix wrong type for "%x" format specifier (PATCH 2/6) > - Fix minor but various typing issues on T-Head immediates (PATCH 5/6) > [Small Optimization] > - Use smallest portable types possible to print (PATCH 3/6) > > Thanks, > Tsukasa > > > > > Tsukasa OI (6): > RISC-V: Fix immediates to have "immediate" style > RISC-V: Fix printf argument types corresponding %x > RISC-V: Optimize riscv_disassemble_data printf > RISC-V: Print comma and tabs as the "text" style > RISC-V: Fix T-Head immediate types on printing > RISC-V: Print XTheadMemPair literal as "immediate" > > opcodes/riscv-dis.c | 71 +++++++++++++++++++++++++-------------------- > 1 file changed, 39 insertions(+), 32 deletions(-) > > > base-commit: c21736aed1d4877e090df60362413669dbdc391d > -- > 2.34.1