From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nickc@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id D1A433857404
 for <binutils@sourceware.org>; Wed, 18 May 2022 15:29:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1A433857404
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-163-afym76ryO3KgeteIa9XBJg-1; Wed, 18 May 2022 11:29:34 -0400
X-MC-Unique: afym76ryO3KgeteIa9XBJg-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com
 [10.11.54.1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3ADB82949BAB
 for <binutils@sourceware.org>; Wed, 18 May 2022 15:29:34 +0000 (UTC)
Received: from comet.redhat.com (unknown [10.39.195.122])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C3484400DE5E
 for <binutils@sourceware.org>; Wed, 18 May 2022 15:29:33 +0000 (UTC)
From: Nick Clifton <nickc@redhat.com>
To: binutils@sourceware.org
Date: Wed, 18 May 2022 16:29:31 +0100
Message-ID: <87h75m7tb8.fsf@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 KAM_BLANKSUBJECT, MISSING_SUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE,
 TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2022 15:29:36 -0000

Hi Guys,

  Compiling GOLD with Clang-14 produces a compile time warning about the
  current_byte variable being unused in int_encoding.cc:
  get_length_as_unsigned_LEB_128(), so I am checking in the obvious fix
  below.

Cheers
  Nick

gold/ChangeLog
2022-05-18  Nick Clifton  <nickc@redhat.com>

	* int_encoding.cc (get_length_as_unsigned_LEB_128): Remove
	current_length variable.
  
diff --git a/gold/int_encoding.cc b/gold/int_encoding.cc
index d27b2af4c21..196e0b3b509 100644
--- a/gold/int_encoding.cc
+++ b/gold/int_encoding.cc
@@ -119,12 +119,7 @@ get_length_as_unsigned_LEB_128(uint64_t value)
   size_t length = 0;
   do
     {
-      unsigned char current_byte = value & 0x7f;
       value >>= 7;
-      if (value != 0)
-        {
-          current_byte |= 0x80;
-        }
       length++;
     }
   while (value != 0);