From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: David Faust <david.faust@oracle.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] bpf: xBPF SDIV, SMOD instructions
Date: Fri, 18 Sep 2020 18:49:42 +0200 [thread overview]
Message-ID: <87h7rv113t.fsf@oracle.com> (raw)
In-Reply-To: <a7b463c0-da26-db3a-8f4e-882f3a816dce@oracle.com> (David Faust's message of "Fri, 18 Sep 2020 09:07:08 -0700")
Hi David.
>> Why not using define-alu-insn-bin and daib instead of defining an
>> additional pair of macros? We can pass the ISAs as arguments to
>> daib/daiu and thus avoid replicating logic ...
>>
>
> Long story short, I tried to do this originally but did it very poorly,
> and the result was not readable :)
>
> Revisiting today, I have realized what I was doing wrong. Here is a
> revised version of the patch following your suggestion to avoid the
> replicated logic.
Nice :)
This version LGTM. Thanks!
next prev parent reply other threads:[~2020-09-18 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 17:09 David Faust
2020-09-18 11:44 ` Jose E. Marchesi
2020-09-18 16:07 ` David Faust
2020-09-18 16:49 ` Jose E. Marchesi [this message]
2020-09-18 17:07 ` David Faust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7rv113t.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=binutils@sourceware.org \
--cc=david.faust@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).