From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Alan Modra <amodra@gmail.com>
Cc: "Jose E. Marchesi via Binutils" <binutils@sourceware.org>
Subject: Re: [PATCH V2 0/3] Improve insn endianness support in CGEN ports
Date: Thu, 04 Jun 2020 16:35:28 +0200 [thread overview]
Message-ID: <87h7vq291r.fsf@oracle.com> (raw)
In-Reply-To: <20200604132919.GR29024@bubble.grove.modra.org> (Alan Modra's message of "Thu, 4 Jun 2020 22:59:19 +0930")
>
> If there are no further comments, I would like to install this series.
> OK for master?
>
>
> [Changes from V1:
> - Rebased to latest master.
> - Typo fixed in ChangeLog entry.
> - Use the latest cgen to regenerate files.
> - Use insn_endian in both gas/cgen.c and gas/config/tc-mep.c]
Looks OK to commit. The only comment I have is that the use of
cgen_put_insn_value in tc-bpf.c:md_apply_fix seems like using too big
a hammer to me. But that predated this patch. I think
where[1] = target_big_endian ? 0x01 : 0x10;
would do the same as what you have there now (and would save me
wondering why the patch used gas_cgen_cpu_desc->endian over
gas_cgen_cpu_desc->insn_endian, before I realised the code is poking a
single byte value).
I pushed the CGEN patch to cgen, the binutils series, and an extra patch
following your suggestion for simplifying md_apply_fix.
Thanks!
next prev parent reply other threads:[~2020-06-04 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 14:23 Jose E. Marchesi
2020-06-02 14:23 ` [PATCH V2 1/3] opcodes: support insn endianness in cgen_cpu_open Jose E. Marchesi
2020-06-02 14:23 ` [PATCH V2 2/3] opcodes: discriminate endianness and insn-endianness in CGEN ports Jose E. Marchesi
2020-06-02 14:23 ` [PATCH V2 3/3] cpu, gas, opcodes: remove no longer needed workaround from the BPF port Jose E. Marchesi
2020-06-04 9:42 ` [PATCH V2 0/3] Improve insn endianness support in CGEN ports Jose E. Marchesi
2020-06-04 13:29 ` Alan Modra
2020-06-04 14:35 ` Jose E. Marchesi [this message]
2020-06-05 3:26 ` Alan Modra
2020-06-05 6:55 ` Alan Modra
2020-06-05 7:03 ` Alan Modra
2020-06-05 14:10 ` Jose E. Marchesi
2020-06-05 15:51 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7vq291r.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).