From: Richard Sandiford <rdsandiford@googlemail.com>
To: binutils@sourceware.org
Subject: Fix VxWorks breakage from my earlier MIPS GOT changes
Date: Sun, 19 Sep 2010 10:06:00 -0000 [thread overview]
Message-ID: <87hbhm59os.fsf@firetop.home> (raw)
My patches (from a while back) to use GGA_RELOC_ONLY was SVR4-specific,
so broke the VxWorks testsuite. This patch adds the missing !is_vxworks
check.
Tested on mips-wrs-vxworks and applied.
Richard
bfd/
* elfxx-mips.c (allocate_dynrelocs): Don't add relocation symbols
to the global GOT on VxWorks.
Index: bfd/elfxx-mips.c
===================================================================
--- bfd/elfxx-mips.c 2010-09-19 10:28:59.000000000 +0100
+++ bfd/elfxx-mips.c 2010-09-19 10:34:45.000000000 +0100
@@ -8172,9 +8172,14 @@ allocate_dynrelocs (struct elf_link_hash
if (do_copy)
{
/* Even though we don't directly need a GOT entry for this symbol,
- a symbol must have a dynamic symbol table index greater that
- DT_MIPS_GOTSYM if there are dynamic relocations against it. */
- if (hmips->global_got_area > GGA_RELOC_ONLY)
+ the SVR4 psABI requires it to have a dynamic symbol table
+ index greater that DT_MIPS_GOTSYM if there are dynamic
+ relocations against it.
+
+ VxWorks does not enforce the same mapping between the GOT
+ and the symbol table, so the same requirement does not
+ apply there. */
+ if (!htab->is_vxworks && hmips->global_got_area > GGA_RELOC_ONLY)
hmips->global_got_area = GGA_RELOC_ONLY;
mips_elf_allocate_dynamic_relocations
reply other threads:[~2010-09-19 10:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbhm59os.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).