From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 00DB9384CB95 for ; Thu, 15 Feb 2024 15:32:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00DB9384CB95 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00DB9384CB95 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708011178; cv=pass; b=e3aFf/GuOeqx8qvBQQUBLlCvsJIJiYijoRPDniSnUy9pqn/yMLIpzVls0t2Jl8ZIg/CN3awqwDLCpnc9s5TBlEqM7wJ5ILu3DhgQ4ue/EH0Ozc9pWnWFdKIuXluiLlDGiGhNzJN2x2yVj3LtifpUNJd6HnfO8osNmgl0fgv+P9g= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708011178; c=relaxed/simple; bh=6VAJUIkOadKCYhnB6yxLi4qAJPC3i+BUkgrrwJFZm2Q=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=qeTVEvr/D+SX4sFenY3j98Gq3DrxM/M3D7gNILi7Hgo1K9S3NBUVIrX/bOkJoFbXr8DKxpNvS6RspFipkVxg5k4YK2dTKFGUVmFa0F5oPDkROUIrBjnZswGu8ROcQyUtyKwFpUcLfDp6l2PxaJ9Alc0C1f8m+ewBg2+2abO2Gng= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FFT4cL022495; Thu, 15 Feb 2024 15:32:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=o8+hhGfS4HwOnF5eIy28t/g9YVkpxwxgDFhoUpCD48c=; b=OtlMN24fsp4GTFwdtmS6+tlCiP5vDRIZpRs0LWiys8QO55uvzmn+wghXdBw+bCudSxYq PbbI0XDn1/L0VOYNHObwlhj6jNCBRLN+al2xydosb5QP35LU6A7LkA2Ei8b6IxPmkWUQ O0jlSd3uoOCzZeCZWqOqAofmN/DZcWce2+eZGaU0MTD/EJ7oGysLZCWwYoIlnU3H4s2k iG0dy9vTEsTLNxsGv6IbzQ3wVmih1qjZ4CuOTNdCohU/ZeUATcImZ4EapNjS+CsX2tvt 9dBFHfcJ2XoZ861ETO93Jmx9lmQu8idQ67CFcStSt++RlaFyJhT/Pf5bEFyn7sk97Tqi jA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w92db2g9t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 15:32:52 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41FF3B8K015212; Thu, 15 Feb 2024 15:32:52 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w5ykap4c3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 15:32:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=evsgHosIp2PCDazArALWf/S0koTKWxqbTSVab70ZEK9IgQjU4I0u08CSCSGpBC/JPe3zgeR2+n7qXOoStV5BJi4ah06KpUaxP1R7bIIDTYAG7C59LTuZmNq4hXkuUPbh5yAfiAhET6/fb1yan1pt54Ep0lgfDz9zGnJxa8qVOqoc5kHnul9Y1UaIwQULDYXvxhtIMdeBjdJUdw0lmCN268qexcHifEbZostFLfgrvzmvdsJ1xNQZkk2EZ0rdKiQP+2FIuDv/Jmjd+36D3d/HXPyPadfEbKcBo9h/KdjsQnqNPI3F3TJ9d/T0pHu3VvOIwlB7oIcqesvgOr9gQl5Exw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o8+hhGfS4HwOnF5eIy28t/g9YVkpxwxgDFhoUpCD48c=; b=UqIbgNgDReefrx24JowIXiPmnHTmDMXE7xtap8WZD9pF5SQAVDSz73VxKVhgptX1ZSYu1ivXvwf9VDGkd/LUnilSyVYEF8oSXzrEJRM0sLYAl3xJqTFhK6RndmJVq173djsxlIu/XUfXbGnFebn9j3L7Egsgr8wNuYyGfGkiZ9v+nev72hu4XcWFZviRlpUVGqLEYXXRm1BuQlfjH0uHFBnyBdTBZ7XfcQo0G+9f/2HG5Yzc1A/ihpfC97mpNrdONGXndix72myfNFRxvaAq3a4uiQN24gR2WcKvXSTVQWc3Oe1T9z7nDP7ZnXsbS0Hvp8+U37CGVkAyFO492uRxZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o8+hhGfS4HwOnF5eIy28t/g9YVkpxwxgDFhoUpCD48c=; b=SHjG8RLGS2cSNBFR2Tx0NthU1/gxguDXUgWhqg1YcT1IgwaHV4hgOaZYVp9AHFuD7GPgaG1PhQ2TEF3xv5tPvuMj1NSG6/8qfpLZFyJsCyb+y4Na7W+gczLa5C9ZvQYBogTOQLRNE+F56l08Bfn19EfaVi4Lp5EoEgT03meR+zs= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by PH0PR10MB5817.namprd10.prod.outlook.com (2603:10b6:510:12a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39; Thu, 15 Feb 2024 15:32:49 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::cafd:c8d6:e2c3:3a1%4]) with mapi id 15.20.7292.029; Thu, 15 Feb 2024 15:32:49 +0000 From: "Jose E. Marchesi" To: Will Hawkins Cc: Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 In-Reply-To: (Will Hawkins's message of "Wed, 14 Feb 2024 11:19:44 -0500") References: <20240212174209.620310-1-hawkinsw@obs.cr> <20240212174209.620310-2-hawkinsw@obs.cr> <82116e8c-390b-4389-8d04-744839785f2c@redhat.com> <87jzn7nwhe.fsf@oracle.com> <87h6ibkopa.fsf@oracle.com> Date: Thu, 15 Feb 2024 16:32:44 +0100 Message-ID: <87il2pivz7.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::14) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|PH0PR10MB5817:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e469c02-d55e-4c18-e4c1-08dc2e3b5db1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qHuyNvCA2DpcVLaEDSc6DFM20FklvVFP+tPVi1t2gIEs5IrHs+HdmPPkd+yZuWgciGCuIeOtt83S3gsYtDyH7Wqw4ArVc4T64pIITczQxkfdB4UcRz+qMJVhGN7jeEagcecaAFKW8lTO9NcefM2+2gdMkJZgcUMu4pOn4peWEIdAg7J5ZCuB9CSdi7hdD1pJQhA1qngXcKyE7HsOAg3yY1PhuxpnTarI2Nn6L6tmV9BrZH9NIzXua7nbcQuay5bxApQyKBBQXpLu9EUxbWMCZsF53e5qCIiYPSb7h+HKZkmsLekQniULSL4d2WTAEKitqRWuu4Za5FE/WdbEGsTFXPeOhNu+e330BdEiB1Fz+6JSLaD5DOFxt7hMw5VW7pjU+dK/p6QxeSbuOq31BI4WkOK0kIXbJo46LvA6Hc4haRaaKLuErbWzgx46THuvV1D1x/MTc6oOyCaRH2ICd07nDBmVeKsRVdAvcBAkabOpFA32pa/YJfvG6V3r6WVmSWdgqnhSqQReQ2sONVvcfWEFH/PubZB3ea5mqYqY+0J0TFxbleNbvikb4Ga9nB8uNBM5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(376002)(39860400002)(136003)(366004)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(2906002)(5660300002)(4326008)(83380400001)(38100700002)(478600001)(53546011)(26005)(6512007)(2616005)(6506007)(36756003)(6666004)(66574015)(66946007)(66476007)(86362001)(66556008)(6916009)(8936002)(316002)(8676002)(6486002)(66899024)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0h3TjdwdzNsVndBS2psUEhWdkk0Nlh6Qmt1V0UyTHlacDJIZWRDWlZpMDk5?= =?utf-8?B?RVp3ZktBMFVNcDNPNURaeENOdlFPZklRRDJCcnRJeGpJMEl5Y1k4bTQ2V0ly?= =?utf-8?B?K1E5aWM4K1hSZnNMQWtyVzBFQ3JHT2twSW9URmZrak8rTXhUcWNqLyt4aStz?= =?utf-8?B?dEl0ZGdkSW1vUGxMRFdUWGFBdEQvYWMwa0ZPa29IWmc5Y2Npb2dLcTZ5eDc1?= =?utf-8?B?QlhMRHkzQytMNld4cy93M1lucHp0cmk2R2Y0cndjTTRZWjFBSXZLYVkwWnBa?= =?utf-8?B?RFUxWFZpUjN1Y2p1RW9LNitGaXFmZCtOVWM0L3VSNlovUlBFbktMNlV6OHk5?= =?utf-8?B?VDB6K21DNUdCUlkrcU16WWd5RUUyd0ZRTTFwSGlCeXlKTWIzTXl3SHRnTm1v?= =?utf-8?B?RG92ODFqSWg2RXZ6SnhVeXlhT0xqK1pGSTZJZ1FJa21oOWJrQ3p6dUhEeUZK?= =?utf-8?B?VENZYSsrelBXTHk4WXdqMWFzMExNL2w1NTdMTFAwNS9ZYzRIS2VLQzJyK2pE?= =?utf-8?B?NkFCcWVNQytqckhTN1gzMHUvcjN2Unk4QzFaZkd5U0wvQ25mK2FhY3IzNERM?= =?utf-8?B?N25ubEZuTmwzWHhyZTc4NTR2M29RZVU3emk5bVFHMVpIWmt3eVJGMlNVemZC?= =?utf-8?B?RHpKR3QzRGdsS2F6N0V2MmkrcVkyZGpwNzZDSE1KaFovd0VTWCtHN2gzMml6?= =?utf-8?B?K1c1NUt4VzJuQWluZWU5V3FPUnRBK05MQStWWnpoSnY5VjgwUFlqM1IyWWpt?= =?utf-8?B?OEFKTHNYMldlKzBiejZ2ektYOFBaZHJNMGY4Wm1aNExmM2hEcWJWMjE5V1ZJ?= =?utf-8?B?aE9vVElNcTkvVGJDZjkrTTkyenF2RFBOdjZEY1l4TmRrR2Q1KzZLdzNjcEMx?= =?utf-8?B?Uk1hY2Q2MFRLbDExV2p2Z0RVNDA5Wk9hR1huRE9xZnVSRnZFWGU4UGRsUlJq?= =?utf-8?B?aE1hd2NvSDl1NHY0cVRuUldMbUk3c1lZMmxQSUpFZURZbGUwRUVMM216SGN3?= =?utf-8?B?ZzR0NmFWODJHSnIwVERuamdvaS9mWnB6SWRkUlZkN3l3ZFlxbnNrQjhISWZv?= =?utf-8?B?bHNlTmM0RWE0WXUxbGMzREJ2MWZhbUZOYkNmMXpaN3BsZXAremhqekxzbEZJ?= =?utf-8?B?eXY4ckwxMzVxTFRHMmFIa1BZLzk1b1ZHMzRBazFXRGxnSnUycGxOdURxaWl0?= =?utf-8?B?aUpYamdTb2t5c0R5OHlPak0zMm1IbSs0cnJzcWNMYURTeGNWV1pENktydDV6?= =?utf-8?B?Q3YvY1krby9TM205ZHpBR0R4R0VjQ25mVmFVc0t1bVlYMFRlSjV4dmRNMjQy?= =?utf-8?B?QjVrNkxLS2JHaWV0VW1wL0NVVzQ4TncrWkRtSXlUY05ISU9GamNGRC9UczhI?= =?utf-8?B?M2xnVXZ1VTREMjBQeWVPYkswaW1TTlM2ZFBaVDVzYUJLK2I3VmxkZ2ZRN3R2?= =?utf-8?B?bWFSQmQ5SFVaSkhlKzdzTXcrNmhBUURVNnFRbkRLeTdpaGJjSkRWS3NheDdZ?= =?utf-8?B?L3JhaDVpcGV3QVdpRnZDQWZqNjFiUm9iUndyNWZ6dy93WDNEMnl2WWh3VjIx?= =?utf-8?B?T1JGdlBVdWhXdm9GcTVzb0xlODVCYUtITUlueWdWQ1NtLzdKVms0eTA0OS9N?= =?utf-8?B?bkJLOGYybjV4VFllelFQZjJKUlcrODRCay8zM21peFdEUk5adnFpbmdWNWtK?= =?utf-8?B?SXhDaEFpL1BBMFU0V3BjSlF0QVUzWE9HY1k4QWlPRjBBblVWUTRRRXJ2TWE3?= =?utf-8?B?a0dsMWtkdGdYR1dHaUpNeE90YUhydVgrVC8wZGI1eHl1VmNERldqNUxIMWE0?= =?utf-8?B?Z280QUF6by9KUnA0QVkxdjZOemtJQTRpN2UvVVpsZ25SZklIK01aMU1FNUdY?= =?utf-8?B?OWIxWElab0d4a0pjSzA1TkE5RDcxNStYcUZ4NzhtTk12NU5uUnlaWFRLYXly?= =?utf-8?B?TzJuRy9qVkdKU3ZNc016ek9rdFZEemJLdktVSzdVdXdKQjBBUlBJY1l2dDYx?= =?utf-8?B?UUpkdkNuVDRHc2FDWFBualJJNkJrQ0VkdG5KdmFaMW9IUG5ScmdEM2lMbUZn?= =?utf-8?B?bEVpVGhNaEJSZm05UXJDWUFCUUd6STM1L0I5S09LTDVpQVpkVEFGa0FWZklh?= =?utf-8?B?NHhFcU9jUjJQcjVjaTRBNTJNV251UUVsbksyZHZaMjdlNVdwU1EveFZnSElG?= =?utf-8?B?M3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TVO7H4FFuAFpqLWtzcFY5Gh8j6jmX+xCSEkBMoRIM8qLisPg5J1DnuFs+ACU4iGm5sMGrgb2XJAjnopq24MANQ+TEGqC3eKDO+M12PsRnhU5cP6nKQ0WOHPbljT4Z44cSbPEhNibfUfbKetpIJNaqRSiMspWJGKikhbUIcvXIP2ZXuB7Vy4QZJD6oOz4/+gxbeQ5hgonJkIJxUAOh5zqOYYq8hh6Z0wSIDLHNAVW/Kdg+4UnbOn/GNNJdNX2D5nlqpWhm0PpoXbTT3RrdfHVhq1SKzbRuGQHjOyok4ELpyVqk7oIkICY5BDkbpkB672Eom9XE64OsNySHbxEHJWzvQOxlwnQ1kPrrLRL3rF1aMXRpQfUbC/ghKeYDlWf9riWMEDA9vK3GApA5GZI4PHYQ0WqC534VDM/aXbU8L2A7LxYAmQUfHii26xBDwIVRK6CHRTlEvnhZ1Z9PHAK+mEHycTiQ8jLFCptd8Uh7ZXp1X6KegLuz1MJHtI702JBqzz9tonyZgzNEQEJKrFbrxHuLw3rwEJ4uSsV5wWTYTuptWZXgxiBSR9xvixNsxD/KcBPgybtb769kVepelHrxHzJxE82IZu3cufW4lP6qCFhsss= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e469c02-d55e-4c18-e4c1-08dc2e3b5db1 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 15:32:49.1505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J5Qv0nDQXrjcISc17SXgZXkri8LZiDB9C7Ni6iMpQG7/4AV+B+ZIjzgmBuKjMkl4+b/T564Yip9xI894/vLkltGJY3NS0hxRGP0LunVS5p4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5817 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_14,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150125 X-Proofpoint-GUID: mv9pzX6wp9tSu5TalVbEpRykMqyPe4LI X-Proofpoint-ORIG-GUID: mv9pzX6wp9tSu5TalVbEpRykMqyPe4LI X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Wed, Feb 14, 2024 at 11:14=E2=80=AFAM Jose E. Marchesi > wrote: >> >> >> > On Wed, Feb 14, 2024 at 5:58=E2=80=AFAM Jose E. Marchesi >> > wrote: >> >> >> >> >> >> > First, as I said yesterday in my direct message to you, thank you f= or >> >> > making binutils such a pleasant place to contribute to FOSS. You ha= ve >> >> > no idea what that means to contributors like me! >> >> > >> >> > Second, thank you for this helpful critique. I really appreciated >> >> > reading your feedback and will reply inline below (including with a= n >> >> > offer for a patch unrelated to callx that may clean up some of the >> >> > non-constant uses throughout the bpf-specific code). >> >> > >> >> > Third, there is good news: The heavy lifting of this patch is large= ly >> >> > "overcome by events" -- clang/llvm developers are changing their >> >> > encoding of the callx instruction to more closely match what gcc do= es. >> >> > In fact, v3 of this patch will look much more like v1 than v2. >> >> >> >> Hi Will. >> >> >> >> It seems to me that all we need binutils-wise is to enable the callx >> >> instruction with BPF >=3D v1. No other changes are necessary as far = as I >> >> can see, other than adjusting the testsuite accordingly. >> > >> > It should be making its way across the Internet to you now! >> >> Thanks :) >> >> > The only thing ... it will probably cause a build error until a >> > corresponding patch in the simulator lands that takes into >> > consideration the new enum value. >> > >> > I am happy to handle that however you like! >> >> No problem. I will tackle the simulator patch in the GDB list and apply >> both at almost the same time so the buildbots do not get (too) upset. > > Thanks!! It's been fun working on this. And, as I offered to Nick last > night, I am more than happy to take on a little project to do a > cleanup of the code. Just let me know if you would be open to that! By all means, and than you. Improvements are always very welcome :) BTW, I would ask you to not include a separated cover letter for single patches. This makes it easier to reply and quote to both the description of the patch and its contents. > > Will > >> >> > Sorry for the delay! >> > Will >> > >> > >> >> >> >> Thanks!