From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4C9F63858D37 for ; Fri, 28 Apr 2023 08:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C9F63858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682669314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=GIi5bpgPLn4gA/XgQ3NcWLBalhLPQhnU9X6fvnwtonc=; b=IbLIDTK0L2KXBjQc9szZHNe0ryJU1RZ/KDXMHSXl4QeufD9/fqnpbUiJ5EIpv88pZeyov8 J/5x7NYE6e+O/lvVqfxqLkRUqxVtbqU4J/D6yYpeVwrMQ+Z5rZ1Kv2UFYprf/TcGZIDd+P Lj1RkYo2OrRkPGHf/hR71R37F9ESlt4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-uYGKugImPba0eC6pw1uBwQ-1; Fri, 28 Apr 2023 04:08:30 -0400 X-MC-Unique: uYGKugImPba0eC6pw1uBwQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B5EA10AF7C1; Fri, 28 Apr 2023 08:08:30 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C415440C6EC4; Fri, 28 Apr 2023 08:08:29 +0000 (UTC) From: Florian Weimer To: Indu Bhagat Cc: binutils@sourceware.org Subject: Missing alignment in SFrame spec Date: Fri, 28 Apr 2023 10:08:27 +0200 Message-ID: <87ildgbf9g.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The SFrame specification does not say anything explict about alignment. It uses ATTRIBUTE_PACKED, which strongly suggests alignment 1, but looking at the structures themselves, I think what you actually want is 4-byte alignment. Thanks, Florian