From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A37513857C45 for ; Sat, 25 Feb 2023 10:23:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A37513857C45 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677320638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KfW6S0iqjN49e60H/LlJyaU78f4ZR/G1wCCSkRBGANs=; b=XRLqRfXLIupDT7VZDytBgcxGDfpU17UMvLSTPw7EvXmcLVLTYu9K9lu/dRxp6rj8pCvCbu pa3zcaHXfI5PI/5TzHkjouuKLsurdbmuvV3hSjlx9PqQ73Z225Artsw8qRBrqmMMZw7idK a4KEibOUPKJotFT//3nF9ZaT2iYs8QA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-222-070OMr4dO1qFutixgOOPhw-1; Sat, 25 Feb 2023 05:23:56 -0500 X-MC-Unique: 070OMr4dO1qFutixgOOPhw-1 Received: by mail-wm1-f71.google.com with SMTP id az39-20020a05600c602700b003e97eb80524so2471979wmb.4 for ; Sat, 25 Feb 2023 02:23:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677320635; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KfW6S0iqjN49e60H/LlJyaU78f4ZR/G1wCCSkRBGANs=; b=tYTcwS4eRztkvI27LlyMP9iPms6T0Msz3ZZ+EnW8EB0xHrIZTG0/RzINbFyiFvA3Gp i1nvUbKoYRqCMYYlIF9GMIqROF+i/O2rCbH7UKVq9JpEq+OOOvr2nwFJfosO47BaPkm4 DQ9c4HncaZyUPOLk+howcfVz8cBIo6vDnw7xlJIj1CjZnhFVick7XD8v2TgNna9zt7tY 0lkQUzkTFxsBn82bp2029Zr4Ly5kCWxmeg47c9dOYKe8JF8m2+9ZJH5qjK/REtHzrCAh U6ts8+8aBZ+N6oTdeTh2pP39GQUmnRoL9zJXicN9vEOnHsqC5DTqmfcdy6jV0IC93DRs Zn7Q== X-Gm-Message-State: AO0yUKWBzsVKtj5Btn/dy2XDiv1OHoT+jSHE060Rgurib8Gq3i8jganI nJOQwqcVBCJhH/jGQVjOs6iYIw8gTk9eoZNeGXU5ZEWJ2MygWG/U35r8qesbMTuHcUZw+Ened7M 1TH6fVgNmp5cVLiDc6Qi0sUM= X-Received: by 2002:a5d:5387:0:b0:2c5:455b:4cd2 with SMTP id d7-20020a5d5387000000b002c5455b4cd2mr18287824wrv.57.1677320635679; Sat, 25 Feb 2023 02:23:55 -0800 (PST) X-Google-Smtp-Source: AK7set9QMOO9i08IoUJw2umTXYbD/V8Z6NxXqdwzQ8ibfKPUgwv57857X9O1qLEsfR5gRgeuzvH13Q== X-Received: by 2002:a5d:5387:0:b0:2c5:455b:4cd2 with SMTP id d7-20020a5d5387000000b002c5455b4cd2mr18287814wrv.57.1677320635371; Sat, 25 Feb 2023 02:23:55 -0800 (PST) Received: from localhost (92.40.219.187.threembb.co.uk. [92.40.219.187]) by smtp.gmail.com with ESMTPSA id i20-20020a5d5234000000b002c5493a17efsm1399871wra.25.2023.02.25.02.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 02:23:55 -0800 (PST) From: Andrew Burgess To: Andreas Schwab , binutils@sourceware.org Subject: [PUSHED] Enable styling for GDB (Was: [PATCH] opcodes: style m68k disassembler output) In-Reply-To: <877cwere3q.fsf@igel.home> References: <877cwere3q.fsf@igel.home> Date: Sat, 25 Feb 2023 10:23:53 +0000 Message-ID: <87ilfqjb5y.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andreas, Thanks for adding styling for m68k. I pushed the patch below as obvious; this enables use of your new styling within GDB. Hope this is OK. Thanks, Andrew --- commit 82341e9798202fa94b801b1428a8bf68dc80149a Author: Andrew Burgess Date: Sat Feb 25 10:16:34 2023 +0000 opcodes/m68k: enable libopcodes styling for GDB The following commit added libopcodes styling for m68k: commit c22ff449275c91e4842bb10c650e83c572580f65 Date: Tue Feb 14 18:07:19 2023 +0100 opcodes: style m68k disassembler output but didn't set disassemble_info::created_styled_output in disassemble.c, which is needed in order for GDB to start using the libopcodes based styling. This commit fixes this small oversight. GDB now styles correctly. diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c index ff8cb87f599..93052e75088 100644 --- a/opcodes/disassemble.c +++ b/opcodes/disassemble.c @@ -652,6 +652,11 @@ disassemble_init_for_target (struct disassemble_info * info) info->skip_zeroes = 32; break; #endif +#ifdef ARCH_m68k + case bfd_arch_m68k: + info->created_styled_output = true; + break; +#endif #ifdef ARCH_mep case bfd_arch_mep: info->skip_zeroes = 256;