From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 9B5B73857351 for ; Wed, 2 Nov 2022 19:07:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B5B73857351 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A2J4lbY006129; Wed, 2 Nov 2022 19:07:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=Y2zjH2yGSN7bWUAksAly66jMO+UrybCdvcAdGQSHaDE=; b=gMLkASYlYP4RjrYAwhjwR61/stXBPGsC+ZlqcjFlCx4Dyx/MHQrfG7VPFznM0yVP28E1 OTW+2fbmSh30cxmHpfJnIjtL9hd7Vl+E0K388ianrBXf45sE8esFzwFdev8HwLTYTLNh //EULfjPSaXiB62XAFxhsc1m0HtU2vXjb9o4LpVbxuniRA5zsrA94JxtGIc+Espe726u 0JGSfslws8AqajhawfYDeotq0UtspCHM57yMSZH1D23jh0P1uX8YLkYsrpGG3I7lK37I M9liYjUXty0nE+ZF0QDbjqERpQcCvKjhzUwUuT363sdg8dESXNLN5nLo5ZXzUTf2Z0Fh ww== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kgv2ajm81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Nov 2022 19:07:23 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A2IHiCw029677; Wed, 2 Nov 2022 19:07:23 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2170.outbound.protection.outlook.com [104.47.56.170]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kgtm5ub8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Nov 2022 19:07:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYYZZ/8/xmfMgNXZ6r97VpiHiwnxzViJB+BgvLF6bpsyGsZRZJB989FHUZh7qyR4k6bwb6HvPIZOM4pQtQlTQaCTtUQmw6Ea6nbn/iJmn33M9lybPz59Iynej+kY3BSRskqFgBDR1QWlhtNuONz5Wn4rBAX6pe5pCKUX7M9bp4PxNvSv4B/smrp+jtnT7+tq1aGX0g7JCMgik0/uqVVYWQya4I9DjhzCYyB2q2nQOarejtoIZVKgWtwuF6itg30PqSg1qgVmGmdd8k+dnotZL32ltbPn6iCy57aIoQ7DI66CKp9RKZyeTwTgZyN5qz3gc4KTkM+UKftWnQLVf6pSfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y2zjH2yGSN7bWUAksAly66jMO+UrybCdvcAdGQSHaDE=; b=l8x9GHq+h3annF5yobZmqcBRJMiIEIR3+mXVZoDJuR0YKsPI+4M53olmEd8OTDRZeUIprf8/n8wtBLg7cDwlpWYIE918LP/10G92mOD6cQ1Ty05ODkGyJIgbpWSrNu8LxtMQSCGkPyqOxNDGhxhyYm+VEMl8Icombt0f5c0mInoO2B8DCb5aDS071qyhrF2vJqXPicEWLFgHlxqJWBBa2YuCZXymun4pPONeQgD1tUXB8NXBrBdpb2dUF6FMa/Ov7p+Kfne5kZgN6lXcMuqg2XIN+Q+xsQ9YllJ3krP451n7Zgc/ufwEqRfE0/LgiugmepEI/zIeVIe3JbUND/Z29Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y2zjH2yGSN7bWUAksAly66jMO+UrybCdvcAdGQSHaDE=; b=gI2aMdw4P+dMsDF3csDs+nZeIQv+ol7B84vhaxeKiWcstif2RxdDnm3H1pLYNiKvuw9qfteus1RzG6dBub2lBVw62XPPNQk4JBn86Iid6UVgh+C+2sk5SgiISuV5d8sY9W5f36iRxZlaZwo82IocpLURnbDtpLXwUU7hi8DB340= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by DM4PR10MB6230.namprd10.prod.outlook.com (2603:10b6:8:8d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 19:07:21 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049%5]) with mapi id 15.20.5791.020; Wed, 2 Nov 2022 19:07:21 +0000 From: "Jose E. Marchesi" To: Mike Frysinger Cc: binutils@sourceware.org Subject: Re: [PATCH, V3 10/15] gdb: sim: buildsystem changes to accommodate libsframe References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-11-indu.bhagat@oracle.com> <0f7e9a96-61fb-22a2-f71e-f3bead83579e@oracle.com> Date: Wed, 02 Nov 2022 20:11:27 +0100 In-Reply-To: (Mike Frysinger via Binutils's message of "Wed, 2 Nov 2022 20:47:46 +0545") Message-ID: <87iljxuq74.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: AM0PR07CA0021.eurprd07.prod.outlook.com (2603:10a6:208:ac::34) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|DM4PR10MB6230:EE_ X-MS-Office365-Filtering-Correlation-Id: e372c577-96df-40a1-19ab-08dabd0577db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lr1NtSht2/IaB3cnqKl/w50VP3CjCGAEASjydGY69dgI0nYM5mQUsDDm5+SrjLtDJ2l6d22SOGJBVNnnPe/nwKSueiNV1pfY7B9bqn3kWgpdYKsVFNaz5Nb7riMMXrMQNI2eYA5cpEHmdtSM8HBYZWk/GmUe/QptX8Qw0YGSMdLygkY7AbwSNVcsYi8cGeHka9MJo4pWrmLs8y4j8OFtrWX/Vja9KERGcEuXbrdTPvqwAKRys7uSBExnAS4PYwTpzi3ramXFZZ/NkSqoRDjRa1sKyIch6d9XnFD6PeczuRFqcSJZNVmLMRYnCKqmuAXBbt/WVuuwNVNvXJ7ZaY2gQShp6ZkrK8a6c9wJ0Dy5PB+GH26Z1pgFJQ8Zpwqa+VqfZGyD6MOBuwoZT1nqnBsMHLJMdZTuuG9b2YQ9W6Bi99XvNSJKU5xUmRBBcGF7yu5l/XscWYVqD8kip79X+KAuOUAHTjGh2iyPEkGma6ysPN2TndynQf9+FCh9bw9VwbaQKHA6z4F5aP3etkE4xdgD/HXLWbZoLvztZHfu/lOOhJ0TpDfOA5T4Ueu6qBTSFdL8amWFf1XCDL3cVsOme1ps8h0OJksKHBiv67VXUUQMxNwxaMRCAgWHm/aROkqKB4pF4psJSg2jcyAJjH+5FCpsOHY/nvRJxkTPIvEEAA9G70+h+4Ny1Y5Uqgu9wKNFoajwMuTGAUdRCjMHlx05XIqLjg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199015)(83380400001)(5660300002)(2616005)(2906002)(6486002)(6916009)(36756003)(316002)(26005)(38100700002)(86362001)(478600001)(8936002)(6512007)(8676002)(41300700001)(186003)(66476007)(4326008)(6506007)(53546011)(66556008)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p/BgSPqSUbUWaD0saBwH/iwJnz4oK7XW14P4n86zTH4gPvRPAgfpr7FixYdw?= =?us-ascii?Q?und9jfKI+oXw/bVniCPSlBTYbdRlxzZ4G6yH9HfEti7e2fssZJH8155PddMp?= =?us-ascii?Q?S1f5Six6GRSUdH757uKSbHjieR3CmBPCaVHSowjR2YpLJmZAS9Dh+wPP/FW3?= =?us-ascii?Q?Yy29UMEL1s2M4sLu9NktQtvpzOlsZP3Iclc7htTVL3sZ/StaBAt6rmhJnLWA?= =?us-ascii?Q?/2hGe7nOcUZbZL/4BAo/33w2H38REo1dQZuAvhP/Ofz+jFVYmbtyqSMHk1I6?= =?us-ascii?Q?z/yNCTHFaM9IxmukVuBCzIbd3XwjW9b1+bUuHTPjzaXlJN5p10NJaQDpkLd8?= =?us-ascii?Q?IP5YpZN2vF7ZW0ZlwS5tHntX4q43siCvsYVAtVXDQmf4Zhmoq4M6cutAkrsU?= =?us-ascii?Q?aqsOQ8SuyncbWUOR0bZlSpobBhTYItvE3XpMW5s8AzKkW80ZKDWTBQYRbsbP?= =?us-ascii?Q?FJUqD22XCmA59pczz4wZ7R83teuKSjBxXaAQ4DR7hIoAVozsP5XBbOvcjUj7?= =?us-ascii?Q?Gbap1AUG8fEFjQp0jRhi/NEFB/PfTm9KoT1NnsFQG7W50NiXKpBbbeRzLbON?= =?us-ascii?Q?FKHNDWBlh9Azt/xDrcct4o0LjUEu5kz7w9JwRs0tdJanEsB/BGKK1hcLz0DY?= =?us-ascii?Q?DhRGwuvAj825QXI0PFGm2TvKcteQ/Lh6NUUwBPOzbUEG/bZYcN/sxSUrVHKw?= =?us-ascii?Q?Gsk1cZBr1T3/uQRqpcp3RjhIWXhH+d/3LvW87vLszYmDlThPytsJi9tsXwQO?= =?us-ascii?Q?Mt3kmKi6Q0Qi391pT4ED0UvSUE/MGEsi6jOKh1mUOtTSrY2YCUrE0wqtEZ0p?= =?us-ascii?Q?2K8lN+sHC7Q1vMjoK3oojf+o+PNknvKVzgC09nnQGh/GRiuOD3aF/NyfUG+4?= =?us-ascii?Q?pT0TokSTeqwhz1y6Bus0CywFPcVKmiQrY2MqT0WEBA2wFBPpLSipOtatcI5G?= =?us-ascii?Q?pF7cO9i5x4kwyTHOQ01nzV2075RLneoYF40R3Ha9F1M+UWl25DBKNTAH2V37?= =?us-ascii?Q?K4SzNgnqJX35+qLxJJNSqHZ5JCoCzFXWpkdneYs5zP3Qpry9TZ/TQT7iz2Ko?= =?us-ascii?Q?Tha9VM390y0zpSbnl0MfLHDXtzPR7ITcjMUeDItwq/fygwcuKDwijyXIQIAo?= =?us-ascii?Q?YnrpIDLrUx/kN/A+ks4HHJnmwiv4EvwNs1uy2nb3EMIS52IamCRuNoN8HA8k?= =?us-ascii?Q?bipu+ofkpmgadrqfN3CKkIC8OfDeQkhGyt9xK7ArvN30CitJwg75pcfR8+pX?= =?us-ascii?Q?+ZIt/+fXuL7FodtSh/c/i9TBYsROb6RZdJPYGQmg+ldR8ZZYrwotepPnun9X?= =?us-ascii?Q?7wuxFVOzhwyLSXY8wElHcHlPqC6nrsQjHl2BUcfga0G0qzbcwVUi28wA3DF6?= =?us-ascii?Q?4NBJPMoSkVOgzMsf7/gqvcNqg/Gu1T+55YilaXwPZpvPr7FULcvvVz9/gZv4?= =?us-ascii?Q?FKy5rk4DF0RMIuZDIY+p9PyfBCmRTq1ncNRnGMbDfJdefEuss2XvPsgQDCAc?= =?us-ascii?Q?rd7gc94SqdwMej/FcORuou4UcNtI8n38+KdvpU17Hc1FW00lrNjhQAjEf3J4?= =?us-ascii?Q?CQBdn1Zouu12O6BQs+2YobADH1zKMXjCbxB4+KShDHVbdId+0/w9YAFpP0E5?= =?us-ascii?Q?1w=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e372c577-96df-40a1-19ab-08dabd0577db X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 19:07:21.2648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UYIjj0wIchf5Vb4CGnvQivc+PXlPTsMtxzwHgm4mBW7J2FD5AmhSKFA9ubh2F1NXnPnszkryfScmTwurN2AwXU/ozym1b06fbUSWfh0hfbg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6230 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_14,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020125 X-Proofpoint-ORIG-GUID: jchZQof9l61_DBFAfGcL6lU98a7z7F0l X-Proofpoint-GUID: jchZQof9l61_DBFAfGcL6lU98a7z7F0l X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mike, Indu. >> > On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: >> >> [Changes in V3] >> >> - Additional diff in sim/ppc/Makefile.in to accommodate libsframe. >> >> This is needed to ensure --enable-targets=all continues to build. >> >> - Addressed review comments by Mike Frysinger. >> > >> > this doesn't seem to actually address my comments. you're still poking >> > the internals of libtool by accessing files under .libs/. >> >> gdb does not use libtool yet. > > you have access to the source. you can change these things. > > also, gdb & sim are sep projects. I see gdb/configure.ac uses the same strategy in order to locate the in-tree libbacktrace.a and libctf: if test "${enable_libbacktrace}" = "yes"; then LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/" LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used.]) else LIBBACKTRACE_INC= LIBBACKTRACE_LIB= fi [...] if test x${enable_static} = xno; then LIBCTF="-Wl,--rpath,../libctf/.libs ../libctf/.libs/libctf.so" CTF_DEPS="../libctf/.libs/libctf.so" else LIBCTF="../libctf/.libs/libctf.a" CTF_DEPS="$LIBCTF" fi With corresponding substitutions in gdb/Makefile.in. I agree it would be better to have GDB libtoolized so it could refer to the .la libraries directly thus avoiding internals, but could that be done in a separated patch set, also covering the other cases? In the meanwhile, Indu could change her patch in order to look for libsframe.so in gdb/configure.ac instead of gdb/Makefile.in, as it is done for the other libs. Then we libtoolize. WDYT? >> I see that opcodes/Makefile.am bfd/Makefile.am each create a >> opcodes/libopcodes.a and bfd/libbfd.a by copying over from the >> respective artifact from the .libs/ at build-time. > > this forces static linking of libraries that are possibly available as > shared ones which isn't really what we want