From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73802 invoked by alias); 3 May 2019 19:33:29 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 73792 invoked by uid 89); 3 May 2019 19:33:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy=responding, Excellent, day X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 19:33:28 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x43JIUap079631; Fri, 3 May 2019 19:33:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=eyNGffUUK/FnRdk6NyPT5nVrIrasV4FMKCBWFmwNYU8=; b=WUYwXddvK4hOg/oClFLMpyw6oVeK1r/U4WGS1BNGTC+LaiNSp4K4SV/6B7VmC4rjBg3a FJNmr2gBKcX1iHcaPoFBjNG5IkTIFXYREumPryUJlCyZulaLqJ+TzQAf2+EDj55SPo9z MekFcolq7xYGYIGSq6V8bjH2PxqRThMC44KkR0uzXloj4D1Qw3cSRvJ4KV0KQHlHsHsF OtNHEUjkuHllWJ4TJSl4nyHm1tikXhte5e1BkON8YxyPbVrPBiMxc8C3V8RvYPhf5iCp FAH9qRKcx1iv2ltvRT0OjUlcpN/yAsIli9yw6oJmwaxn8r9YGNTDPM8LHw1v5mprSLK9 BA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2s6xj00ttb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 May 2019 19:33:17 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x43JViFK137270; Fri, 3 May 2019 19:33:17 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2s7p8agrnq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 May 2019 19:33:17 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x43JXGxE023264; Fri, 3 May 2019 19:33:16 GMT Received: from loom (/81.187.191.129) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 May 2019 12:33:16 -0700 From: Nick Alcock To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH 06/19] libctf: hashing References: <20190430225706.159422-1-nick.alcock@oracle.com> <20190430225706.159422-7-nick.alcock@oracle.com> <0460e204-6113-3dfc-b3b7-dfae809b6f4b@redhat.com> Date: Fri, 03 May 2019 19:33:00 -0000 In-Reply-To: <0460e204-6113-3dfc-b3b7-dfae809b6f4b@redhat.com> (Nick Clifton's message of "Thu, 2 May 2019 17:16:12 +0100") Message-ID: <87imuruydh.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00120.txt.bz2 On 2 May 2019, Nick Clifton uttered the following: > Hi Nick, > >> In the binutils implementation, these are both fairly thin wrappers >> around libiberty hashtab. > > I could not think of anything useful to say about this patch, so this > is just a comment to let you know that I have looked over it. I think Thank you for this! Excellent reviews: I'm responding only slowly because of the volume of changes your comments have generated. :) 15 files changed, 345 insertions(+), 85 deletions(-) so far... I can only hope that, one day many years from now, I can review code I've never seen before as well as this.