From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 73F863858C55 for ; Sun, 3 Mar 2024 15:11:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73F863858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 73F863858C55 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709478667; cv=pass; b=sLHkVCDDzptjn1JWN1lVuQdhALLh2rQbBb838fbi9fPi0LIuWT890x/60i8ENVYFBGluoLZ0498XlU6W/CI/PgphXSzvpfYNkOX3D4w1ODHkOjZ6G/5cU7dUs3SiwVNaFowIGb7n2dUuFoz+WgLFP13TuwfJLxV8NRoEodTcRM0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709478667; c=relaxed/simple; bh=VtpJrnDLcx1kfmAvb1sQ1pktdYKSh87Kj/Ixn2/Ehd4=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=bo0chdS7MQtn21Uc6V1TKZsEpMDNAEYO0z+17FNH0NXFtGTM1spCEu60AIYv9TUHJ8wnRGKouuRLInxNaMARlRWbuIAs7KUzNP8d7NtfBj2ZGhcVVGD6+afYJPmJbwQRoJq2kekYz6F6NXXVI6lrcVR7aTP9jI74blLfFlqOnXU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4233shLp002185; Sun, 3 Mar 2024 15:10:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-11-20; bh=D5jdadZAaGfT36lo4YvYT166unuIQ2BtagWK9dljQOU=; b=mvzGonoHoLc/KKtZR3gD8EX/zcTowQBxu2pCdiDDCyTnUUl/4JqUWJen1ZzfkCvF+46b gwE4ocXO3mdyYPLabssaKEWXeKYoIY3OcnxFHT59rM4qk0yIC6GLFb/47KPRuY1TpOMb 2oUZUIVFXa5aHUiwGui4Lt9guGPuNtZa2KOgdEo4PHO1tD91LYdjp4DNjAoCDe0Kys52 6yELSUG4VG+L3dkQwERIU8ptXOdlaHFQAMpuFpPrig7A/jwfE5VQJ5S1lj/+yjHEwHEu JCAJRqTfwFw0XV3vA/U0K77/ViCSDW4Y+MAiNnoAsOBWKZpDt8+f1yDYhcCHuUZxWM5E Mg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wkvnuswgc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 03 Mar 2024 15:10:53 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 423EAPBV015659; Sun, 3 Mar 2024 15:10:52 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wktj50w42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 03 Mar 2024 15:10:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ibtQKoxFQN6boMoJfpxO5gTz8T7+TILv+3IcVx2o5vM4//ZdlVBz8Lp5D9MJ0jrbKVtAhM5IY5JUF68uyd1F1HgaDnwxGJn4BudBLL4Xtz+ijKjS0iXzMfrqTK6Qszv++hfm3cyCMjBgs0gB7qi+Co2utvfpCUg239IJqAPWUTwMD8cBG2sfQONL9wJTJ1rt5EGvbHa6pP9EhV5KoFVjP9pZpvK41AA2q2KXQjTdK5hJhP/7WXaBUbNOFs//ayqtiGXZmb8y1SphUl8IysGxkTJwARwP2iqps1MR9hP7eTy/GSWOVx/A41l0REd+r7AzNr+EwZr6rYnHZJ/dhp2+zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D5jdadZAaGfT36lo4YvYT166unuIQ2BtagWK9dljQOU=; b=Pyl8iq9wAYnaAkX6C7t32gFw18m0IZ4nYXsAwT5nsrc2VeWNMgHbevoDQfGnGiMQLQ6OrT0CQoyh7von9ghW2v7YMPUYioZlADud5Kgw2DuDiOzAHiSLiLTz6n/BiIVPyE4hbVDFeu5aKgIFd3Op+OWHNzFx474y1aG+bLbAA2ZGcCcsr7HZCI0FQiCWTxUFP1W/ANU6Eq1pt5yfBDQKpYaIWwD1deOf3BMVukJnV5slFUrP3QXjNIxtGB7kDO1cQdNxyNgIlDK+XmA/EC9Iu7k4UmBWiMfZdZIjGToBkW3Gm/SW+Cr+cpuk1rpa56L7LpC5bMFYYDyb+bmIQjs/DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D5jdadZAaGfT36lo4YvYT166unuIQ2BtagWK9dljQOU=; b=e25JJbDaomfDBM1wvE2HSaz6pxKRCfojn9cRT4w2F0uGU78ySFYoFX12gK9H0YvrS8XxoBTctpUNkkZoO9mQOEx3QeOZ0rDwQrbHD7OwXVVsjR9DaZYTdNySCxIE/aBlUPc7GGlABGMKiRsZeQN4IlavYyt7IX6mlYr/YFjmm+w= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by CO1PR10MB4435.namprd10.prod.outlook.com (2603:10b6:303:6c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Sun, 3 Mar 2024 15:10:50 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7339.035; Sun, 3 Mar 2024 15:10:50 +0000 From: Nick Alcock To: Nicholas Vinson Cc: binutils@sourceware.org, Sam Jones Subject: Re: [PATCH 2/3] libctf: Add comment for conditionally def'd sym References: Emacs: it's all fun and games, until somebody tries to edit a file. Date: Sun, 03 Mar 2024 15:10:46 +0000 In-Reply-To: (Nicholas Vinson's message of "Sat, 2 Mar 2024 00:00:00 -0500") Message-ID: <87jzmjl5ah.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P123CA0082.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::15) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|CO1PR10MB4435:EE_ X-MS-Office365-Filtering-Correlation-Id: 34e577d1-d864-4a92-4cfd-08dc3b941c9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EStpEa927gOREKaMGy+wFDTMo0osoX8rBDHbdcXt2COxGPBGlq4Yz9Yl+/fIvR0BgWYnyT9aSrIUjIMv9IPF3ZZJLNmkglNG4Oxlpgyj/xd6Ag6Eh2mw00TGPSI8ue9kx9P2WdCiEBSy6XQCHwqOw3F+8AFQKlHPhP6LMcntBeq5WXEEaabnsbq4SOeKZ0EZ7SGRs/oA9myCPPUePRKADGkDdIKi68QhcvcsQ3f8G5Yi3qmfB0XJ/4w/M6gpacZ+BGk2l7vcTgQ2hYoVVBUDsVZMco5wUnPtmpx9uQXudZJ7IuCPdUqfoyQtjAXUUsjNUPAXm4BimNXflvWIv2x3OUEN21dzzj2e+E/CAKR7GlOJ5gpfeYnXxysr5aqzp+G5qZP53DFKCBHMvwD3XRgdKn6T36QpusxcHNRdSvKQwsjgOFJ2wYNsZmZlndNRJ2BvMjfIacD00+a490OfNC39k+jBTQcrtrUiYqfJKvd0+ceSFMx2vYjAuLR9SUBmqa+hZZv5TGUJVfRn3hFoGN8PSgmXG8ypZqLUsVR9xzUZBgJa+YF4nkKFBOVPBDnB8abBEA095jMvPEmn1X1zQiO3itlX0cF2pk2mcdn2Ct//zKD2PjKw/eXID0wDBMJIDY8QyVhvJ4CBh7axVgwdooo/M2bL0IhFMCyfqTQ2ivuleVk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR10MB6608.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gFuxbm5GloqBhFQTXhongKn0pwv9ubNKD9HmhznWw/eRaoPo67mZmdDgmjOy?= =?us-ascii?Q?waPFjCqhkrVB7VAyipgf3SwyMr85Ry9IEe7GdpLZ+9ZMTs/nTIOCdv+Ygv9d?= =?us-ascii?Q?qy0ogpR+714pk8IaE6xakZWK7IM1EmxtZl64iRfI8bTOClkMAdn9JjcvTo5z?= =?us-ascii?Q?ON7ZM1h01MFAcZAWcnxAuVWrrDy/cH+PTz0vw2JcyAaRLYtxkGMkKRf5J4XY?= =?us-ascii?Q?BxA01ofglpLDlJNGBcCJ5wrwCPpDIXOdR7Nm5rTws7/FFkmtjoj09fjE4uOJ?= =?us-ascii?Q?XqHA95ggkziE67GYCvtVoaS1f2XO1wjAlMIVyB+TTJSJexSROzMzyPdN9fTl?= =?us-ascii?Q?ahhIZRcsojD88z4e0jWWgXpbsNXduIsQdkkFQD7HVEMchokEOWg4kfHzq4gK?= =?us-ascii?Q?imEg2n8RYyygDPADq2cjuQheWtbJL7f+wT2h5NnPbR2npw5rjqhIx2IDhjKA?= =?us-ascii?Q?RvcPfZqK94aQFFN7en6a1dCYcK8ufVC161HGDICVzBCmTRSYzI0NiZBgxaUq?= =?us-ascii?Q?aqQiRwAVlFmVm0aKLGmtIV7nBxvdyHEeeTGELpnt9xObDSxLOfYwbZ5VAA0Z?= =?us-ascii?Q?8qhHjg7KQ3cT5ardAcaFIFLMz9eKyJZ0pUoGmW02AdvTRPf9PWXZ+lDK3Pj4?= =?us-ascii?Q?ZJQNzXwPuw/1cyrqkhMXo4DMO2kXzcqOhC77lDozSbTaRuC7RnmUbTPyQK31?= =?us-ascii?Q?F/09q9snG6yEmasrjkeb70ju7XqgYJX5My30XXnQkgeQxuABwPM0kxiqDJzq?= =?us-ascii?Q?5H9qiyGtMFWQxqiG4yJMGcTRvX65EwjFjImHIuHGg3w5ot5y0toGSzAToKlc?= =?us-ascii?Q?RxEzOKyKk7ZMxHJvLk0RSNPs5Izw+QebTGm8xgPdawppwSQbc8zvzEJETOd9?= =?us-ascii?Q?BFopLNUUZ44K+0YFKN99WB2/ZjeQo7FOjud7Tt0qT2o2mzFpFKyhQe6LARPi?= =?us-ascii?Q?5zC7cPg0tsZgp0qSHMrbIfR3U4stMV+K7CuNwRENqTgyvG0yp3ZzbLOZNkbV?= =?us-ascii?Q?pWcCrJ93SiVjXZGjXu1aYuhCC7th9J8L6iYlpdgMe2okRvBjWJ3j23c1qJx2?= =?us-ascii?Q?SF5oZ9Ttl8KuvB5JwNMScRfqXlllbdefKRjLFee1aUcBqgTAuBKek9ldc35k?= =?us-ascii?Q?+A10cqtTLF/pkuwRaplo60D4D4E6rqNg2AA9eLtoQc1/aipXlDiU5NOdhKOJ?= =?us-ascii?Q?knFC3C2HpVRg+d9tMPEL2bR/T0/RRIJTbrrKFhAYJTk2ugHvgG6ge9SivgKz?= =?us-ascii?Q?eu9NwKCMSmcaAKWtsxE9JLiF7SwqhU1NQ5b3boJnMzHMaNebVkFWtThwMjPH?= =?us-ascii?Q?2rQD4HpYN+cTsH/WgOnX1HoB15tOpL7k+/s3a9Q4B9xa7RbJ5NegEQqpltBQ?= =?us-ascii?Q?pItrr7y0/mPbB6AKyAFVdFfeu1GktQa/Hs6sUmpwz2kUac6OlVw72XbKtNMi?= =?us-ascii?Q?jhfJRkvDKYXOxbNMP0oLdfvNMD+G01keoZCQ+3xdqVb9O45aw4myrT10lc/9?= =?us-ascii?Q?DZ0T2p8xsFi0urFI8Qk956sCIO3B30TaXjJ83B45/D0a6QbJzeIJBCx/Y9Ap?= =?us-ascii?Q?bdKovdcEYMGtHiL/Uz09p/GSNndS8zQ4AUn+p+u6jh0yaCwL0bQhM5fIhQDC?= =?us-ascii?Q?GA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HixlBVExepCXAVi0S0DijBmZBRFm1Ca9t8ObFDxVHHR8n3TvFQ6a6TwT/MiaeH4AyLjxbYG5JRwm+2plP5G1OpMxqZqRR96Ol66jB9KDz/nliV3grPC/R6XBJhduApmHXX/4JdVmPbNr/WU0zHZ5AqcZS+CM3mdAQULnuw0IQRn5lZoStTOz7PrCbv4fqaH5STGjPWLohx60vlTuVXQynK2g/Hs+aWtRvT8znXqC9e1vzOdw/O2eVgwGR0nLktrFmgct+FDzgHk4sHIFxdDErLsXx1oU0eOCfYQtAKxn5D1ckBt5UxeELlZPZ2TAqhLiGJ/eCMOyaZPxw5zpRko8twBtSH14KVxJJqBHwjkRR0brOpS5QvI2BWFUBG1FsYPVYxJP1LJdxaQC7YeyxoqlXZCJfZwIEqRGPv6m2A8rRn4ymtfMpo76TxmF4CnCi9yGUGB1KohOpzZH+WestXtptlF+1oX7EbTsphUxjP4JYqDSZkNda72/cxUCXxXkmCJ8p/HVw13n2cyhOa7NVG7o5XjYqg49z6fToCUok/WcXx8d0aPXK0+/2Q17nkQ28hmVLX0M8V0aRH1NYbk765VmIIB1oZhtmYeho5kW7Yc7PNo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e577d1-d864-4a92-4cfd-08dc3b941c9f X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2024 15:10:50.4204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J4MjwMJV4i8EdKKNn6tQ22v1UWUR6WUL1hrqrNbuxgasQJZ4HJpmMih5rvpVbADrUUfyLCfPcwTj3vsLWeb7/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4435 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-03_06,2024-03-01_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxlogscore=912 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403030127 X-Proofpoint-ORIG-GUID: lOKaZGRNAhf_wnxScDByvdcSnKg3NKz3 X-Proofpoint-GUID: lOKaZGRNAhf_wnxScDByvdcSnKg3NKz3 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2 Mar 2024, Nicholas Vinson uttered the following: > diff --git a/libctf/configure.ac b/libctf/configure.ac > index e4e430615bd..0494a537e78 100644 > --- a/libctf/configure.ac > +++ b/libctf/configure.ac > @@ -258,7 +258,8 @@ AC_CACHE_CHECK([for linker versioning flags], [ac_cv_libctf_version_script], > CFLAGS="$CFLAGS -fPIC" > AC_LINK_IFELSE([AC_LANG_SOURCE([[int ctf_foo (void) { return 0; } > int main (void) { return ctf_foo(); }]])], > - [ac_cv_libctf_version_script="-Wl,--version-script='$srcdir/libctf.ver'"], > + [ac_cv_libctf_version_script="-Wl,--version-script" > + decommented_version_script=t], > []) > LDFLAGS="$old_LDFLAGS" Not quite. The stanza you changed there is meant for GNU ld, which supports both undefined symbols in version scripts and /* comments */ and needs none of this hackery. We have a three-case case statement here, with the final last-ditch attempt being -export-symbols-regex=, and we need to add another case for "no -B local, doesn't like nonexistent symbols, supports --version-script". Something like the below, perhaps. (Caveat: when I test with LLVM 17 and LDFLAGS="-fuse-ld=lld -Wl,--no-undefined-version" there is no failure to link libctf with trunk binutils, though ld building does fail: ld.lld: error: undefined symbol: ldlex_backup >>> referenced by ldgram.y:860 (../../ld/ldgram.y:860) >>> ldgram.o:(yyparse) >>> referenced by ldgram.y:1125 (../../ld/ldgram.y:1125) >>> ldgram.o:(yyparse) >>> referenced by ldgram.y:1146 (../../ld/ldgram.y:1146) >>> ldgram.o:(yyparse) >>> referenced 1 more times ld.lld: error: undefined symbol: ldlex_wild so this is not really tested and all I can really say is that clang and lld are still happy to link. Don't trust what I wrote here, please test it out -- and obviously it still needs things like the removal of the ctf_label_set symbols that genuinely don't exist, as well. That patch is fine.) diff --git a/libctf/configure.ac b/libctf/configure.ac index e4e430615bd..28f63792826 100644 --- a/libctf/configure.ac +++ b/libctf/configure.ac @@ -251,7 +251,7 @@ AC_SUBST(HAVE_TCL_TRY) # Use a version script, if possible, or an -export-symbols-regex otherwise. decommented_version_script= AC_CACHE_CHECK([for linker versioning flags], [ac_cv_libctf_version_script], - [echo 'FOO { global: mai*; local: ctf_fo*; };' > conftest.ver + [echo 'FOO { global: mai*; nonexistent; local: ctf_fo*; };' > conftest.ver old_LDFLAGS="$LDFLAGS" old_CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS -shared -Wl,--version-script=conftest.ver" @@ -262,7 +262,10 @@ AC_CACHE_CHECK([for linker versioning flags], [ac_cv_libctf_version_script], []) LDFLAGS="$old_LDFLAGS" + # Solaris: -B local, nonexistent symbols prohibited: use preprocessed + # version scripts if test -z "$ac_cv_libctf_version_script"; then + echo 'FOO { global: mai*; local: ctf_fo*; };' > conftest.ver LDFLAGS="$LDFLAGS -shared -Wl,-B,local -Wl,-z,gnu-version-script=conftest.ver" AC_LINK_IFELSE([AC_LANG_SOURCE([[int ctf_foo (void) { return 0; } int main (void) { return ctf_foo(); }]])], @@ -273,6 +276,19 @@ AC_CACHE_CHECK([for linker versioning flags], [ac_cv_libctf_version_script], fi CFLAGS="$old_CFLAGS" + # LLD with --no-undefined-version on by default: no -B local, nonexistent + # symbols prohibited: same solution as Solaris + if test -z "$ac_cv_libctf_version_script"; then + LDFLAGS="$LDFLAGS -shared -Wl,--version-script=conftest.ver" + AC_LINK_IFELSE([AC_LANG_SOURCE([[int ctf_foo (void) { return 0; } + int main (void) { return ctf_foo(); }]])], + [ac_cv_libctf_version_script="-Wl,--version-script" + decommented_version_script=t], + []) + LDFLAGS="$old_LDFLAGS" + fi + CFLAGS="$old_CFLAGS" + if test -z "$ac_cv_libctf_version_script"; then ac_cv_libctf_version_script='-export-symbols-regex ctf_.*' fi diff --git a/libctf/libctf.ver b/libctf/libctf.ver index c59847d012b..474852c2c84 100644 --- a/libctf/libctf.ver +++ b/libctf/libctf.ver @@ -139,7 +139,6 @@ LIBCTF_1.0 { ctf_arc_write; ctf_arc_write_fd; - ctf_arc_open; ctf_arc_bufopen; ctf_arc_close; ctf_arc_open_by_name; @@ -165,6 +164,7 @@ LIBCTF_1.0 { ctf_link_shuffle_syms; ctf_link_write; + ctf_arc_open; /* libctf only. */ ctf_fdopen; /* libctf only. */ ctf_open; /* libctf only. */ ctf_bfdopen; /* libctf only. */ base-commit: 90f8d97c8efa75f7f019b868eca9c626bc35203d -- 2.43.0.272.gce700b77fd