From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 7D5243858C54 for ; Tue, 17 Oct 2023 19:41:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D5243858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D5243858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697571669; cv=pass; b=P3IlPL7IJwNfpgRFFrI8sU4oSYrPmqR2K8KXhBBoNck+t40xkxt8sLNzNM1QwO0+tPbhlB4/B/itBvZ1026nsiaKMQjyiyHOiqX5NRa/El7PXvCfBPZt9rZTxVT4ewCLS+JSMF0G0W2HQGt7uaXl5M3rMs9zhntGSfsn9cajLww= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697571669; c=relaxed/simple; bh=te8ekzVQjeaSJ+FCacE8YR+NrIFsPMqy2T+7JBhjWEY=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=ZXAXPwO7AcG5kfiZCvWKttWKbngco3kc/B7A+d7BuuryMGcOg6DxuIJ83wRgxu3CbJMSyMiyEMdR/uqQUiNGcXO5ULKSfgeeMYTi5STndB2G+M18znfHCgSznbd2WkBbXtIfE4WN4JOWbrg2JaU7gWPnD8s7eB9jIkdJ+x0vKh8= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39HIx64b026412; Tue, 17 Oct 2023 19:41:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=te8ekzVQjeaSJ+FCacE8YR+NrIFsPMqy2T+7JBhjWEY=; b=gg6OfHzJeBDZeHN6C4kVfbiNDyczApRVfrJuVXX4x1iZpIY12vKvi1vJgA82+mdm8/TX hNwcpJ+ns6LfcrmB5ybEyG6v74vUaCL2gKG12uYWnV+8qkFh9g4hTheqCEGwaYf4/jxz FiXvMtjpSrUZaflRsenWB4+ytwlMIz1PQHfjoFSsJSgpQ048qUVAhNJUrRR6lYdPIZwh VZh5+UJ1L1wiFpqnSDque9+Hvf0veonCogXzNT7ao0KtJpRfYeB6xjolOj3qqGOG7yiL c4qy4aOTI/Y0489V9AGdmuAnT5+iE+uhKt4nahk55UiSrzQtibnEFS7luwYUhuq2tNmQ gg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tqk1bnyqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 19:41:05 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39HIVrPx027127; Tue, 17 Oct 2023 19:41:04 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3trg54aqah-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 19:41:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aaJdTyWDeG2hYldSOjZldpEtez55J4MipwNONaGg83Un7dxErA1NQ0eddrBn+9GI/a6DRZzJoM8GyPDkg2uw0JFalyNaJVYI/CHEdlfbQYoO4qtFcUOCfSIOgFDMpblfhqv5WUkYaP3f/NRDQAYIxI9CLPDrnNe1kclutBkAsJMn3Sj2fO8f0S1eR2qz+Nin1YPNjAcMPE262cyGSPcWT6WzlzRYTBTJKsnt/xhuZw4OiN+x3YGTAuN8PTryVcmL+Rm/g2nhGWM5r87/nVVyYqJpuMr/wz5Aj9iOWZ91O85RlUwL+OtsPpniWPqUVUM8TNFwMV0809clZJH292zidg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=te8ekzVQjeaSJ+FCacE8YR+NrIFsPMqy2T+7JBhjWEY=; b=lnJiyhoMt9a1xQbAbb5XzVP7SIFex3BDrYGITnPazXCjSdo0jlfOpEXv9SB+98UOc2hOHfUghsPhmjcJQ6UFy3Bz2ZF3XQ/EAFFvxfpqL5Wxho0thVuRas/G4m87kDhw8ZaU9lgSMyTQDxbAO6qoutXPOpNiNytO9nqVH0w6ec+2z2AoGE4CaLtl9V1XoI7MTnct+3svWrlSmh1meivaWvS9aBpanJYjQXjpRLFjQvgBGqpq1H43Rxdn+wugE8yJP45xqBBqVMnKvYuj5L0/nMRKCiRheTPrFJXzAKxcLF88qnWMXocJZj6wv+LBRqHm5yQZWqXSrkjjivgfdBGxGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=te8ekzVQjeaSJ+FCacE8YR+NrIFsPMqy2T+7JBhjWEY=; b=NxNXVD77uqmWC1z6goXW28UAWesb+18CA2LAw5pCWX2iAcslbNLvQkUpU82AyLhucGKJC/QMR1OjgSLRJWTKFUgzTNDfhhUXbP0zUnLhEEGzU/lai0ijRIoNmqPQcl8DrTTqagH43ZHDC3lm1IfQGpgNkkiG8sEDT9QbIlnKgiY= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by SJ0PR10MB5834.namprd10.prod.outlook.com (2603:10b6:a03:3ee::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.47; Tue, 17 Oct 2023 19:41:02 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::19ff:c8cb:d04d:8b5a]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::19ff:c8cb:d04d:8b5a%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 19:41:02 +0000 From: Nick Alcock To: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON Cc: , Subject: Re: [PATCH] libctf: Return CTF_ERR in ctf_type_resolve_unsliced PR 30836 References: <20231017185438.407796-1-torbjorn.svensson@foss.st.com> Emacs: if SIGINT doesn't work, try a tranquilizer. Date: Tue, 17 Oct 2023 20:40:58 +0100 In-Reply-To: <20231017185438.407796-1-torbjorn.svensson@foss.st.com> (=?utf-8?Q?=22Torbj=C3=B6rn?= SVENSSON"'s message of "Tue, 17 Oct 2023 20:54:39 +0200") Message-ID: <87jzrl82b9.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0162.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::23) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|SJ0PR10MB5834:EE_ X-MS-Office365-Filtering-Correlation-Id: e2743595-7d3e-433a-9ef7-08dbcf48feb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uB01ufYiJnPV8KfsDQ5aACXRvwbKN7iBDDM3s6w8WACCM/4nY1HkLCCBzYG7EOybh3+MtMAVRvqaWvNOs5MsPuOVrgvNBEjQPXvU8LWB60Fr7MPzugdt+Cm1fqtOGnMTsCmWNsFvlwShgEHoHXhQ0o/pxSJxYfgx/PIaWNfc05nl8Evvx9MO8Wdhh1/Gx2yF2Y+riieXVUvttsbLxWHt31grmAgY+yv88qRUhIIg/ULyij6fQ1vU7lO18EKHL76fvT6h1W61nPShfD4p6nn18LvfzOruJidYc7CJAk2e8DvPpp7ni3ojACVJHERwmA0t5JPmeYVjVFwX++OtKe+WJivCWajgxwBYut+G/qSq638Yv6ro52zEJdKEKN8/1jlnn8mwXP4o/EiAEWIZfAQC4IxpIphRDRAe5V/jfQwJtvvBaEO458dp2aCI97AmzktnJGydgWPn5+IDWhp4g1iAPpeNjcYe1vHI5zcq/EA7Xftr1zRoy6IpOMwf77vDv+8CSAO3Z44ibtwAw1lomhkOzybtqCn3bzg3LRHo6eq6tD5bLBr6gKtsW2qxIQXIm4ik X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(39860400002)(366004)(396003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(36756003)(66946007)(66556008)(41300700001)(54906003)(38100700002)(86362001)(6512007)(6486002)(6916009)(66476007)(6666004)(4744005)(6506007)(107886003)(9686003)(478600001)(2906002)(5660300002)(316002)(8676002)(8936002)(44832011)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFNsTjB5R3FSQXBYbkh3blRTZ2FLYmF0alFQUWtjYVBvQnR2RWo1eXdNcGo0?= =?utf-8?B?T1gyUWpKOEVETjJycWU5TXlTdzBSbmVzWnBuNEtlT2Z2ZnFGZml1K1JBNVpz?= =?utf-8?B?ZjZneE9neDNjNGlyUGsxSnhOS1VzNHZ2a0srRTlqd2NXNm5LQkg5YklyM04x?= =?utf-8?B?UTEzKzFCTGYvYlAxcFJxY280eURHcE9ET2ZQdFhYSXEwUm5qNnEwelBneEd5?= =?utf-8?B?MEUxNUNHdVBxTWh3eXNWN3I2MS9tZUJ3WitVaXdMWUN3SWJLbERSRmlXQzlQ?= =?utf-8?B?V3VWUVE1TWFDdU1qc1F2VWM4aERYTlY3T2V5d1BnMm9aaHViRzZFUDBway9S?= =?utf-8?B?Yis2WS9oYkU2Rk9Mait5WFkvUGdJVDdrMGZOdzB2RGVBSGxSVldMLzFmeG5i?= =?utf-8?B?MytKTk00aUFZMG5rUDlZYk5UZ0dQNlRQWDZNOHorb0x2Z3VrU09vT3FKNENP?= =?utf-8?B?dVErMHcvUzhiYjB3NU50ZjdUbCtaQWp3VGlqSEluZWRZRnVnMkp5czU2dUhG?= =?utf-8?B?anI2T0ltTW4wVDVHMlRIaSt0S01EdGphTlRpNENGSXhxN2tSUkJzVW9CUkNq?= =?utf-8?B?Q3hrSllpZGhHU3dWS3lrd2I3UGp2L2U3cWNEdHVvQ1hlYU1UdlRITkR0aGND?= =?utf-8?B?dVA2WUtxQ2FHY0g1aXI4Y2tUVlM3QUxXUVczVGwyQ21sak10YTR3NFBRVi90?= =?utf-8?B?eDAzQURZRDVMZ2xhbTlmaHNFMlNKa1c4dzhEeTlCYVJjR2hiNUpkUklXYWtH?= =?utf-8?B?c2JHekF6L3lOYTVxNmN2SnR1am1tMUFCZmtOcmZxK3ZxaFJPZlJjT24vZW0y?= =?utf-8?B?b0hxczZRK1NRdFVoOHgraXlHSGcvMUpBMExId0FJTXNNVzNRRFdGTEpkdkRw?= =?utf-8?B?YVJnckFVeS9aUytBcUFsR2RtUEIvdW1JUkl2Sk15MSs2OHRudDhzZTNlYWdF?= =?utf-8?B?cGxFaDk0SHBpdFl0RFRsK0xwQk9obXNWMTlYM01GVHdXMEQyS1Q0OTU4emRj?= =?utf-8?B?bDJiU1V5bzNjbXJ1Q2E2bGtrRXRQRHlKdU9FUk9xeUxqOExtQXYwbnJjaXpi?= =?utf-8?B?a3pSc3N2a0pUTmh6VDJmTDliQWVOU1N2ck9HQWFoWXhPdGVEeGxoUENucmVX?= =?utf-8?B?WnQyaTBhWXlLcXFMRGpYWENPLzlKVFZuQXNxdmR2OCt5Yzc5QVV4dTdZUzYr?= =?utf-8?B?WlBSVEZjbnU3b0tPN0V0Uy9obDlMNDJTSWJQUHJDNC9kSnd1VmE2U0puemhS?= =?utf-8?B?UEIva28zMTc3cUVsbjgvV2ZhVXp3L0FsS21jSlUveGV3NUdZMU5ORWtqWWh1?= =?utf-8?B?aHlPcTYvRVBlYnVhT0d6QVZNY0ppR1lrdkI2ZEV3dVdWeDh0KzZ0ZnFMak1O?= =?utf-8?B?eThJTUVMYkhCeHIxMDgrU0dPWm1oNDZTN1lXR2hpVmdGV2Y5ZlB5QzZpNGlL?= =?utf-8?B?cmtuV2wvN0ZZUFFPWGtCL1ArWUcwVFJwUk1FSTdVNjVZdmhWOHYwcGpPRHFi?= =?utf-8?B?L1NEYnA0OCtLc3hUZHc1MkI4ajFBQWQ4TDV0S2dFb0lIVnZpQ1R6ZHdPU25I?= =?utf-8?B?eVp4Uk0yVkNxaGJ5VDRjblNxcTE5Nms0TG5mQ2RDVkJvNmptZDA3S3JFdkU2?= =?utf-8?B?ck1WVHJwU2ZzbjU3VXUveHY0L0VMM0ZkdFRKRHlXa24zN2xaQndXYy90M2Fn?= =?utf-8?B?eTJKajA0ZHNyWCtYTXdBbkFHV2tyMFczV243bmhodUxCS1JhZlN5MnpvQ1JO?= =?utf-8?B?dHZQamJ6M1ZTY0FzbVVKWC9PemU4UzcrTkVHRy91cTZ3bUJWSlhwbjV4emx5?= =?utf-8?B?OXNGMU14K2RPdUwyZjR1M1JSbXFyVkFLZENPb2ExWk9mSnNhemZjemxwS1JZ?= =?utf-8?B?ek9HMndtYlZlOTJ0RXNuMGtqTXlUUFFQaWRUMGNqZU4yZjNzbkh0Vy9qc1Bv?= =?utf-8?B?SDFsZG1ObHJaS0hqU3pBSlEzRmhJU1NrdVIrc3dtYTlqaE9VVjJaTEF2V3lV?= =?utf-8?B?cTNrcFZ1Y0czZzBiMWsvc0JDVmQvVU94OExYY2FNeGdwT2JBWVVJWUlFZGV1?= =?utf-8?B?ZGVBalNrdXd1L082WVZWOWk2WUVieFk2RytIM2Z4a3F6UU83NkF0dzRmZW02?= =?utf-8?B?UCtEV25CUTZKT0FFc3laTEdmQUU5QjJmMEJZbmhvOWh0TUNUZytQc1RocHdW?= =?utf-8?B?U0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oOesPNqK+SmSeSAkpQe/tyAOTRmpcyNujZkKE/2mNYudK6O2yiUG8jLFF03XkTJlyy+QcCoZcCgYgA1L2EDx8Cu8WzfFgNg/lq/zmktJvtRrW/FvBE1NGbH6yNa1UAArF6EgnNYV3R9rmJgC65iimmmx873KWgP8dDXPcY91JBhw8ZZ8Cw6RL4uJW0Beo+xaiknA1DE3ynHz5TrhNkN6UC6vcurDtPWrfZslWrORzp2CyXkjDforYbH81NDoV/G5gwOo5U1mzNq/sEbiLe4yCiCAdfKG65FiBewaSPId83fiz5U8d2uGGoKNu8Yt5SbHn57v9OqLCFooOs2zT1vM7GdxiPozO8GdXmeX/U1/4Cu2RuwlI1N44Ke4Mjir88n/M31/Vfqj+GRY63bqW8Z/UiqKefx29ze3Q6LMJYHug3/9A4P9Bq4BLqPv18E6UnRQSKri4W7cloyOJqL5aqRRuFeoCFr6595HXLmpwKurzntPqPyGDArGjmbq3f4a+WIlZkOPTb+ZY1ug+qKnBqZZC2RrfLepsiD2rVc1bCKgQJKpKuWuYfyD3Ohq66dGJsrGlvxOAYIjROpsr0e1iMJQhT3omHhJClDptJsk05BmebUy5BdoiZnZZHDOJYr19iCAgmdVSaxFfEbPUgxNx3CHa1ZFC2qPHFp5OTdUg/UtiL+BMwTmOl87FtaBiqywMSIl14Llgwh05re8Gm46SCCicGUHsiwVKg2W9huKBtyrdDJt/c/uXzevt56oLWlJAO5lMedclhZjSIxaI/b9STLurHCWYKIa8LWrV6mvhqdjmpA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2743595-7d3e-433a-9ef7-08dbcf48feb0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 19:41:02.1997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E6fadJUfilO79rE1Kv6fuywRb71nAQH1MrlSrztuGEXCzDQHiIGjlsaGr0pBXSOO2xwNuf/XSVcoBsVlpMIuOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5834 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-17_03,2023-10-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=839 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310170167 X-Proofpoint-GUID: GEhBrU2aoikZ6HZITUZwWfbo83gikWiK X-Proofpoint-ORIG-GUID: GEhBrU2aoikZ6HZITUZwWfbo83gikWiK X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17 Oct 2023, Torbj=C3=B6rn SVENSSON uttered the following: > There were one more place where the incorrect return value was used. > > @Nick: Ok for trunk? :) By all means: push away. Dead obvious too, right above a correct one, and I still overlooked it. (I just checked for further instances of this in ctf-types.c and could see none.)