From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3A7303858D32 for ; Mon, 3 Oct 2022 09:57:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A7303858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664791040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RgkNjorjza8IKE+FV1HPUXK3WllIxF79rXvCfSjvOr8=; b=Wj7rMctUcDfCzd2GGS7dcTBCfRmUO8LpyQyvgIvM4EAgHhsvu73S2c063A6892PCxKpcih ZamM91wxs1wS8xwHygx1nvCMGxc0lngnlW4bsUHY7WdmaXAtXI4t2f1qMnSEiCl1ooZbFx GTRlIyOquMXGi90kPwj9Ivzm0j44yVo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-590-FHnInSTbNjG4vrV5JnSK2g-1; Mon, 03 Oct 2022 05:57:20 -0400 X-MC-Unique: FHnInSTbNjG4vrV5JnSK2g-1 Received: by mail-wr1-f69.google.com with SMTP id k30-20020adfb35e000000b0022e04708c18so1524846wrd.22 for ; Mon, 03 Oct 2022 02:57:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=RgkNjorjza8IKE+FV1HPUXK3WllIxF79rXvCfSjvOr8=; b=m1eJhLqfOXEzg7uFtXTIr8CqznxIUDFJDarSC0KxJNfH8tGUXmRKVgAdXiWpQDfETK lpOhcIR4P9fJ4GwujXUspNEeCYBXjqNW+yJ7C1cO6XNVI+c5s0Z01wF+kbeANhe2E4CZ RZ/0OJwcQwwSGxAl39pw+xVmeQf4DT+LsS7WAgwQMtionEofhh1mmVeAIkaFcyu3ROW2 jERaZzgADdMWR6gjeALKMkRztfrQ8gr2qxtblgtlsjAHmyZamiIVRKsdVCJEDew+3kRN 3P/Iuoe/gMlu93l7QvnvuZ/ETRI31hgzGiuNSxmdMoWUUNokIYqZUfmvwq3FOogGfA9r QrLA== X-Gm-Message-State: ACrzQf0RTv1MiiAFY4quuQJ4U3XCxFRbid6fqSh3/AfGBE1J4G8wvTH6 rF6Mpl0cB2qgHdS/L9jHBc7NzQdQYNG9lTBbsRjfqpcGRtkLXnqVy1Ufz2c84LlNgrvOjLFtL/D iC4W6CwwZ8zYm0GUD5JRreEZeaEi2ngVsCdzcXWW0hJHF0rrzsOATj5WmhfQVRhLcupHVoQ== X-Received: by 2002:a5d:6410:0:b0:22e:3530:184e with SMTP id z16-20020a5d6410000000b0022e3530184emr3885947wru.183.1664791038403; Mon, 03 Oct 2022 02:57:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5QszGb4FQqrFp5kxLySHvlJqJiE4HNKv3o2+nissucgY0Luxe+ZuUb+lZx22Xh/HwajworQg== X-Received: by 2002:a5d:6410:0:b0:22e:3530:184e with SMTP id z16-20020a5d6410000000b0022e3530184emr3885935wru.183.1664791038071; Mon, 03 Oct 2022 02:57:18 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id r2-20020a05600c2c4200b003b3365b38f9sm11099992wmg.10.2022.10.03.02.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 02:57:17 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI via Binutils , Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Cc: binutils@sourceware.org Subject: Re: [PATCH v2 5/6] RISC-V: Fix T-Head immediate types on printing In-Reply-To: References: Date: Mon, 03 Oct 2022 10:57:16 +0100 Message-ID: <87k05hgrgj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tsukasa OI via Binutils writes: > This commit fixes three minor typing-related issues for > T-Head immediate values. > > 1. The format string %i is renamed to %d (which is more common). > 2. Signed type must be specified when printing with %d. > 3. unsigned/signed int it not portable enough for max 32-bit immediates. typo: `it` should be `is`. Thanks, Andrew > Instead, we should use unsigned/signed long. > The format string is changed accordingly. > > opcodes/ChangeLog: > > * riscv-dis.c (print_insn_args): Fix T-Head immediate types on > printing. > --- > opcodes/riscv-dis.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c > index 1c75317fad1..df2a6f4e131 100644 > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -596,11 +596,11 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info > oparg--; > > if (!sign) > - print (info->stream, dis_style_immediate, "%u", > - (unsigned)EXTRACT_U_IMM (n, s, l)); > + print (info->stream, dis_style_immediate, "%lu", > + (unsigned long)EXTRACT_U_IMM (n, s, l)); > else > - print (info->stream, dis_style_immediate, "%i", > - (unsigned)EXTRACT_S_IMM (n, s, l)); > + print (info->stream, dis_style_immediate, "%ld", > + (signed long)EXTRACT_S_IMM (n, s, l)); > break; > default: > goto undefined_modifier; > -- > 2.34.1