From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 7D53E3858001 for ; Wed, 5 Jan 2022 17:39:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D53E3858001 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 205FYKhX020698; Wed, 5 Jan 2022 17:39:18 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dc3st5gay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jan 2022 17:39:18 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 205HW58X110030; Wed, 5 Jan 2022 17:39:17 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by userp3030.oracle.com with ESMTP id 3dac2yqa92-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jan 2022 17:39:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WAplYzVl9rRnhPww+X+Z1HK/J/nJ9W76IyAhlnsh6372H3nvVznKdT5mmycDaujyOewOaUs2GNuQ4IGWEOlr4rGHo2A0Kn8TNNvmZtpvlIK7ZFNnuH0RAT//zRHcvJ+iD9KlzQCiUJA/+tqFWYVMs4ZwQjs8jH2ZECLSltcJ68dr461mHzdL9/+Fbke8PDMtUF+2r0x+IBdXjk3gYZBgWCtzo/IAqkyAnek8RR7wGDepu1MMG3X3lH+mhkgkw2RHQQL0XoOzbBEKC4iHAjCImhuvdW+aNNJtBiyo1t8eEOWawMMo45KoB8No1kSxQAckWI1VTTcyxU5MxW5Z6uGGRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKrY2v1WQj8IZc+6B8hF4mhfowMm8SMGc9q5NwQ9ECo=; b=a5nI8TjaDl0fOmuZVPCwoowvRw7hr9090Uw+R5GBsK7juIIxUFyj4pe0DsaaluQuBBiGj3PShwjTj+r0mMS9pkPFhS5hQyyb3ByFRYgcIVqe1gU4Z4PAtLOeEZoYpHYF4ASb8ZLOIP+dDcxpEl3F+K+n5hKr7uP/6p3K65wGbbKMb2v6GkdIpIRVzg11eCtkqlKJFOvvgTre+4/XfToltnfxO/LZAeIGNl6aFOE0saPX69m24c8A5UDdl5z4ZWUcfp/jzqVBLeS3Q/iq0TFElN1nrFFuEdzu77P2RfMXxYJqDrUcCdvDqUGfam3ql+7BjEsE9xtDWuS2IxhQPtueAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4715.namprd10.prod.outlook.com (2603:10b6:806:fb::10) by SA2PR10MB4410.namprd10.prod.outlook.com (2603:10b6:806:fb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.16; Wed, 5 Jan 2022 17:39:14 +0000 Received: from SA2PR10MB4715.namprd10.prod.outlook.com ([fe80::48dc:4f17:a853:50a0]) by SA2PR10MB4715.namprd10.prod.outlook.com ([fe80::48dc:4f17:a853:50a0%8]) with mapi id 15.20.4867.007; Wed, 5 Jan 2022 17:39:14 +0000 From: Nick Alcock To: Nelson Chu Cc: jiawei , Binutils , Kito Cheng , Jim Wilson , Palmer Dabbelt , cmuellner@ventanamicro.com, Philipp Tomsich , =?utf-8?B?V2VpIFd1ICjlkLQ=?= =?utf-8?B?5LyfKQ==?= , sinan@isrc.iscas.ac.cn, shihua@iscas.ac.cn, yulong@nj.iscas.ac.cn, Nick Alcock Subject: Re: [PATCH 1/1] Fix ld error due to lto shared not support. References: <20211221092859.1642264-1-jiawei@iscas.ac.cn> <20211221092859.1642264-2-jiawei@iscas.ac.cn> Emacs: don't try this at home, kids! Date: Wed, 05 Jan 2022 17:39:06 +0000 In-Reply-To: (Nelson Chu's message of "Wed, 22 Dec 2021 20:20:39 +0800") Message-ID: <87k0fegk05.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::13) To SA2PR10MB4715.namprd10.prod.outlook.com (2603:10b6:806:fb::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f035452f-68fa-4eb7-ee74-08d9d0724a3c X-MS-TrafficTypeDiagnostic: SA2PR10MB4410:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: suJ/3FQPsP2/AwwhZ5068xQnIuzoQNWSMxemTIAP2RVNJOfHptcbXJhcs9IinResYAMxuaURNsZLZx5zTYO5I26BqKVLJjZAF3DrmMzApO0swHFAp2e3B7LTAeUljz/HnWLCbFxEItJo5xQiZlM+AV45vBB+GBbkF+nHXw1EbGGF3sbjDEW125l2MfT+4UUVnDlGo6PwpKO7N3+4tnYdQ4kGkPXXorHzHnfIwtXSc+VJqvooIgW9LI1sry5fqjvwDaRrc5/CVWGsOWF0K2xgOEURG0JPLgHHC/s87hzuM684aYQArnQ27q7rAN/pCh95WatpFhEClM6xDri+jfzIystVpNo4FKIijrdoWU6gbfq2t+vKTEDZSgZWRxPKR9DCllQBBRI0cwfoGKtgz6TbMOqu/uGTnOoBPDQsMmhdZ8t1kFEDTogpCpAiyRCsdsfPx8mr8r7mvjjSGoHqJcf7Pk9u58aHIRvyxP/uCAvITqomBbSFlPsiIPuJgCYtcwC7uK2xyCWK8wFML1w+VTRmfgih/NyYX9m4G8hghqvg7jj5C7pKQFLYc8UjPUDlYlcIxLAEKzoV06zwjUxgSKGnR7wY8X/PGKz6pskMr7E6Y7P6prG2E8mq1cVms/kY7Xk7dOIQodoG4nLLtW8kXQVooA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4715.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(52116002)(6512007)(508600001)(9686003)(4326008)(5660300002)(54906003)(6666004)(6916009)(83380400001)(7416002)(6506007)(53546011)(66946007)(66556008)(44832011)(8936002)(86362001)(107886003)(316002)(66476007)(6486002)(2906002)(186003)(36756003)(38100700002)(8676002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lfk1IEfpVKmi3mGNX+PCpar3TsY13edIFhVNhVRhnkb6VewReyOvoAbyySeQ?= =?us-ascii?Q?Pek5DxQNQFk+EJAF6jge3rZyHFqQMyuMIvW7XYPRargpyYlxVfi7NCg5UZhi?= =?us-ascii?Q?WQbvEsPp9/NEQrye2vIn+gmBrKlURwFHIieePpcbmXzop+c7eFhXL7Iprmij?= =?us-ascii?Q?xsf+twolg6qJ9V44yUqLhgzjEV/eZeuYd6k2bUE/rRMF9j6Alfay2VDvKvb6?= =?us-ascii?Q?7JP4m4H8q5fgD61INKYqTW4ovUCpMZBX9lbpVi66di5w3ruY/YGVVMm1ZCgy?= =?us-ascii?Q?TIE+4eG3B2ygLNYPDVkuCNQ+Jpaw18p1b7c8IrvgLdkZhot4i7TDUA90+KzB?= =?us-ascii?Q?WJasCRfrmLHaGespQNxr22w4C6zQOGIyaAOkwjy2aV32si5RPK4MQ/57O/rL?= =?us-ascii?Q?YKPq9Z2Kl58yp/1QzuzmaQzBZ0+4gwc14MPS+Qd5yq5OUxPm/qdV7BOxT35f?= =?us-ascii?Q?xFBNkfNuadKEN4uDjuEFTGXkK/d+d4u5GNk9sWWjbXm6+JbEg59Ix6FyqjbK?= =?us-ascii?Q?9+woMvAo3yKr4zu2JU0yTftSRo1xJlwyBvFs00lnEoYyYPeHmHd406gqG/HE?= =?us-ascii?Q?3oVCrexWYIt48hUsHZWSW5lDN8rPSzqdzX7ZL41jH+LGHunCz40NG00g1UVC?= =?us-ascii?Q?IGLihS/JYmHDLosjdO90ehF0JeVlhHCBBdvOkOzM0VoPhJjsL2jzCe9Ex98U?= =?us-ascii?Q?UeWUFdl0iSqBMa0nm9aDho/t1Pw4OJkgBRdLmCyHiovs3GQaQKzFbD3220QW?= =?us-ascii?Q?Ogc95Ukl+seduh8pJMlK4/oXgQGxTNrhHe/01P9+G4PEJJD2E+1hMmjZFOuD?= =?us-ascii?Q?4FOJfRcO1/Je7MSWH/oE0REH0VTyhIYmrqzvrbiN0esIxpZDH3w2I9klNDNg?= =?us-ascii?Q?+fHfbX6TKS1Y8erCVkdmT9lqT26oimpbWdUcA7EtOjMWM0Fovm5v83TLsLOs?= =?us-ascii?Q?hrNDi3U0PdHIl9Wclh4bVFnmhGZ+794YOJ4lhI73Wfl/x39NTk3Yg93dd9Bp?= =?us-ascii?Q?tquF0xsqqDEZk5JBOzF1XJdolGffCh7IHwL64iPgnnQsQYve2Kch1a4xcAQG?= =?us-ascii?Q?4fyzt+bVFC3xx4WPunWgeuUK/LUYHVhvMeBTXFOzqt2xsptVdGS0OwfObMfh?= =?us-ascii?Q?+9ZoG4YkApMpGiydh8cLpk8gtNzOxrFUf8B4YRFF0WjGRScytyzrxH3oSlQA?= =?us-ascii?Q?MkcusXTyu4p7hp69/qlPhP5yjKLw6/M9tITadw/tZL7GqvTG0ltVDWVRYmCI?= =?us-ascii?Q?/W4OspNnpohqSmNaPSO5u8KJm9Oc+MEgHInBuaanDRt0KrDzkeMB0dPJgO8z?= =?us-ascii?Q?J1pB9REsaGKWGL4nFXQ/0qm0W971Fn91RSdKJnVo4qnCB6fSWLRrRcmTfCPU?= =?us-ascii?Q?IL03RxJc5EhYSrrVOsRsWoCVRQmhYvcjzb0ITtlOXaO/kKbN3x4T8CE4w9Ta?= =?us-ascii?Q?aOFDsBCIu8suwkr1iV2FHQJPb1dLDYM5R3F1g/YACnGhlx3HrMHjREyBW7CA?= =?us-ascii?Q?mkA0RzFukCxnBZxtWjL/A9PU5H2gazQBNbOCJnVSHRmMVft4r9DZ1zbzHdN1?= =?us-ascii?Q?aeoX6KPzyTbcoXDuB1KxVWlJT5Qij38VPnTlfu4oK0iRxngcj2KBp0JdqA3W?= =?us-ascii?Q?9Jrr3xWPlq1On6/phQdzHrmv6GLBFJWpJSksMXrvBJaJ?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f035452f-68fa-4eb7-ee74-08d9d0724a3c X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4715.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 17:39:14.3429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lhXB/euUUR6GtlxCOjA9Muii3k7HjYMaWAb5qe/zVTNRC3EvjRZg3mBEeBYpSAiSPmq4hP/h5akBCOq4SEljmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4410 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10218 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=960 mlxscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201050116 X-Proofpoint-GUID: 139RjXeNtKrDkl_Z-feHEucUQg6zDMhB X-Proofpoint-ORIG-GUID: 139RjXeNtKrDkl_Z-feHEucUQg6zDMhB X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2022 17:39:45 -0000 On 22 Dec 2021, Nelson Chu verbalised: > Added Nick Alcock in the cc list :) Thanks! > On Tue, Dec 21, 2021 at 5:29 PM jiawei wrote: > I notice that there are 41 ld-ctf testcases, and all of them need > -shared option, so we probably can just add the following check in the > ctf.exp, > > if ![check_shared_lib_support] { > return 0 > } > > So that we don't run these testcases when the ld doesn't support the > -shared option, and you don't need to modify the whole 41 testcases. Sure! Many of them (but not all) would be just as happy with -Wl,-Bdynamic, but that seems likely to be less widely available than -shared... >> ld/testsuite/ld-plugin/lto.exp | 2 +- >> 42 files changed, 43 insertions(+), 2 deletions(-) >> diff --git a/ld/testsuite/ld-ctf/array.d b/ld/testsuite/ld-ctf/array.d >> index 0fe675e2c5d..7a02de49ef9 100644 >> --- a/ld/testsuite/ld-ctf/array.d >> +++ b/ld/testsuite/ld-ctf/array.d >> @@ -2,8 +2,9 @@ >> #source: array-char.c >> #source: array-int.c >> #objdump: --ctf >> -#ld: -shared --ctf-variables --hash-style=sysv >> +#ld: --ctf-variables --hash-style=sysv ... did you mean to do this? (A bunch of tests in the libctf testsuite may need similar changes.) -- NULL && (void)