From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 502023858027 for ; Thu, 17 Feb 2022 16:17:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 502023858027 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-491-pkQCLEd7NVaF4genjrxJHg-1; Thu, 17 Feb 2022 11:17:03 -0500 X-MC-Unique: pkQCLEd7NVaF4genjrxJHg-1 Received: by mail-wr1-f70.google.com with SMTP id s5-20020adfbc05000000b001e7af4f2231so2513394wrg.3 for ; Thu, 17 Feb 2022 08:17:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=i3pCvdu/oreIRnkUZ0ME6fWl+3mH871zkVUgwBRx6fk=; b=JcVlPxm4CFMnPWYB8z6LbbgM34BTs8G0YK7Yhio6kG225Zv1MXayCSnv1MA2s6J8ce VcbqkGekMZGEJQTiTt82cmVKPDIlABEmP4uoFdbCwBnraZdf5B6959xNAVY58ow+MlSQ W1Z1e6Fr3WhGWYgGTQUoYaIyYbC4iFBMXoXHhoDVqP05lcbmW9CerGlQ7MaZ5IuV9GSu l4BTYqoXsSGtrkOP37n+5RuS+6SRUws3WE4EKYVci9RysbXmTj0o1as4HwMzO+fq7s3K t//U4U+ERb1MvJtg/2dBFdLh9Mxet7CofORpI9ToGKsu+lTniIeaXZKihhpe0v9rooTU rHFQ== X-Gm-Message-State: AOAM533Gbv60+Ge17n39/ZFye26BUxeoXzG4FGmheHpv/N+1ki+bdkM6 unNzvEq4/U3cgSY4twPABcqBoRZ9e2hDJoe88mhutR2OmO9TCrUFVK2vVcgY/xyEC0LuSLzvmgw ohszUV0wQ1ule+nefCg== X-Received: by 2002:a05:6000:2a5:b0:1e8:d9dc:f369 with SMTP id l5-20020a05600002a500b001e8d9dcf369mr2325786wry.589.1645114622066; Thu, 17 Feb 2022 08:17:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxD2Z+Fy28yVNhxMTo+BhpvM9iItxbukVf3X97p1KOvnTrOLkXiYavBDDRJSBP8G/ZA95u9Yg== X-Received: by 2002:a05:6000:2a5:b0:1e8:d9dc:f369 with SMTP id l5-20020a05600002a500b001e8d9dcf369mr2325774wry.589.1645114621845; Thu, 17 Feb 2022 08:17:01 -0800 (PST) Received: from localhost (host86-134-151-224.range86-134.btcentralplus.com. [86.134.151.224]) by smtp.gmail.com with ESMTPSA id t187sm1626500wma.22.2022.02.17.08.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 08:17:01 -0800 (PST) From: Andrew Burgess To: Nelson Chu Cc: Binutils Subject: Re: [PATCH 0/3] disassembler syntax highlighting in objdump (via libopcodes) In-Reply-To: References: Date: Thu, 17 Feb 2022 16:17:00 +0000 Message-ID: <87ley9eadf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 16:17:06 -0000 Nelson Chu writes: > Hi Andrew, > > I get gas/testsuite/gas/riscv/insn testcase fail after applying the > series of patches. Here is the reduced case, > > $ cat tmp.s > .word 0x68c58543 > fmadd.s fa0,fa1,fa2,fa3,rne > .insn r MADD, 0, 0, a0, a1, a2, a3 > .insn 0x68c58543 > > All these are the same instruction encoding - fmadd.s, but the first > ".word" will be marked and dumped as data rather than instruction. We > are used to get the following dump result, > > $ /scratch/nelsonc/build-upstream/rv64gc-elf/build-install/bin/riscv64-unknown-elf-objdump > -d tmp.o > > 0000000000000000 <.text>: > 0: 68c58543 .word 0x68c58543 > 4: 68c58543 fmadd.s fa0,fa1,fa2,fa3,rne > 8: 68c58543 fmadd.s fa0,fa1,fa2,fa3,rne > c: 68c58543 fmadd.s fa0,fa1,fa2,fa3,rne > > But now with the patches, I will get segmentation fault when trying to > dump fmadd.s as instruction, > > $ /scratch/nelsonc/build-upstream/rv64gc-elf/build-install/bin/riscv64-unknown-elf-objdump > -d tmp.o > > 0000000000000000 <.text>: > 0: 68c58543 .word 0x68c58543 > Segmentation fault (core dumped) > > Is it possible if you could help to see what happened? Thanks! Sorry about that. I'll get this fixed and post an updated version. Thanks, Andrew