From: Richard Sandiford <richard.sandiford@arm.com>
To: "Richard Earnshaw \(lists\)" <Richard.Earnshaw@arm.com>
Cc: binutils@sourceware.org
Subject: Re: [AArch64][SVE 32/32] Add SVE tests
Date: Tue, 30 Aug 2016 21:23:00 -0000 [thread overview]
Message-ID: <87lgze6jeh.fsf@e105548-lin.cambridge.arm.com> (raw)
In-Reply-To: <e7469e39-49d0-a77b-02b4-2e3dd3d6f318@arm.com> (Richard Earnshaw's message of "Thu, 25 Aug 2016 16:23:01 +0100")
"Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com> writes:
> On 23/08/16 10:31, Richard Sandiford wrote:
>> This patch adds new tests for SVE. It also extends diagnostic.[sl] with
>> checks for some inappropriate uses of MUL and MUL VL in base AArch64
>> instructions.
>>
>> OK to install?
>>
>> Thanks,
>> Richard
>>
>>
>> gas/testsuite/
>> * gas/aarch64/diagnostic.s, gas/aarch64/diagnostic.l: Add tests for
>> invalid uses of MUL VL and MUL in base AArch64 instructions.
>> * gas/aarch64/sve-add.s, gas/aarch64/sve-add.d, gas/aarch64/sve-dup.s,
>> gas/aarch64/sve-dup.d, gas/aarch64/sve-invalid.s,
>> gas/aarch64/sve-invalid.d, gas/aarch64/sve-invalid.l,
>> gas/aarch64/sve-reg-diagnostic.s, gas/aarch64/sve-reg-diagnostic.d,
>> gas/aarch64/sve-reg-diagnostic.l, gas/aarch64/sve.s,
>> gas/aarch64/sve.d: New tests.
>>
>
> I noticed while quickly going over this patch that there are some more
> cases where error messages use 'should' when 'must' is more appropriate.
> Can we please ensure that these are fixed as well.
Apart from the one you noticed in patch 27 (which I'll fix), these
come from pre-existing messages that are automatically extended to new
operand types. Is it OK to change them as a follow-on patch? If so,
I'll do it for all messages, rather than just touch the ones that
affect SVE.
Thanks,
Richard
next prev parent reply other threads:[~2016-08-30 21:23 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:05 [AArch64][SVE 00/32] Add support for the ARMv8-A Scalable Vector Extension Richard Sandiford
2016-08-23 9:06 ` [AArch64][SVE 01/32] Remove parse_neon_operand_type Richard Sandiford
2016-08-23 14:28 ` Richard Earnshaw (lists)
2016-08-23 9:06 ` [AArch64][SVE 02/32] Avoid hard-coded limit in indented_print Richard Sandiford
2016-08-23 14:35 ` Richard Earnshaw (lists)
2016-08-23 9:07 ` [AArch64][SVE 03/32] Rename neon_el_type to vector_el_type Richard Sandiford
2016-08-23 14:36 ` Richard Earnshaw (lists)
2016-08-23 9:07 ` [AArch64][SVE 04/32] Rename neon_type_el to vector_type_el Richard Sandiford
2016-08-23 14:37 ` Richard Earnshaw (lists)
2016-08-23 9:08 ` [AArch64][SVE 05/32] Rename parse_neon_type_for_operand Richard Sandiford
2016-08-23 14:37 ` Richard Earnshaw (lists)
2016-08-23 9:08 ` [AArch64][SVE 06/32] Generalise parse_neon_reg_list Richard Sandiford
2016-08-23 14:39 ` Richard Earnshaw (lists)
2016-08-23 9:09 ` [AArch64][SVE 07/32] Replace hard-coded uses of REG_TYPE_R_Z_BHSDQ_V Richard Sandiford
2016-08-25 10:36 ` Richard Earnshaw (lists)
2016-08-23 9:10 ` [AArch64][SVE 08/32] Generalise aarch64_double_precision_fmovable Richard Sandiford
2016-08-25 13:17 ` Richard Earnshaw (lists)
2016-08-23 9:11 ` [AArch64][SVE 09/32] Improve error messages for invalid floats Richard Sandiford
2016-08-25 13:19 ` Richard Earnshaw (lists)
2016-08-23 9:11 ` [AArch64][SVE 10/32] Move range check out of parse_aarch64_imm_float Richard Sandiford
2016-08-25 13:20 ` Richard Earnshaw (lists)
2016-08-23 9:12 ` [AArch64][SVE 11/32] Tweak aarch64_reg_parse_32_64 interface Richard Sandiford
2016-08-25 13:27 ` Richard Earnshaw (lists)
2016-09-16 11:51 ` Richard Sandiford
2016-09-20 10:47 ` Richard Earnshaw (lists)
2016-08-23 9:13 ` [AArch64][SVE 12/32] Make more use of bfd_boolean Richard Sandiford
2016-08-25 13:39 ` Richard Earnshaw (lists)
2016-09-16 11:56 ` Richard Sandiford
2016-09-20 12:39 ` Richard Earnshaw (lists)
2016-08-23 9:14 ` [AArch64][SVE 13/32] Add an F_STRICT flag Richard Sandiford
2016-08-25 13:45 ` Richard Earnshaw (lists)
2016-08-23 9:15 ` [AArch64][SVE 15/32] Add {insert,extract}_all_fields helpers Richard Sandiford
2016-08-25 13:50 ` Richard Earnshaw (lists)
2016-08-23 9:15 ` [AArch64][SVE 14/32] Make aarch64_logical_immediate_p take an element size Richard Sandiford
2016-08-25 13:48 ` Richard Earnshaw (lists)
2016-08-23 9:16 ` [AArch64][SVE 18/32] Tidy definition of aarch64-opc.c:int_reg Richard Sandiford
2016-08-25 13:55 ` Richard Earnshaw (lists)
2016-08-23 9:16 ` [AArch64][SVE 17/32] Add a prefix parameter to print_register_list Richard Sandiford
2016-08-25 13:53 ` Richard Earnshaw (lists)
2016-08-23 9:16 ` [AArch64][SVE 16/32] Use specific insert/extract methods for fpimm Richard Sandiford
2016-08-25 13:52 ` Richard Earnshaw (lists)
2016-08-23 9:17 ` [AArch64][SVE 19/32] Refactor address-printing code Richard Sandiford
2016-08-25 13:57 ` Richard Earnshaw (lists)
2016-08-23 9:18 ` [AArch64][SVE 21/32] Add Zn and Pn registers Richard Sandiford
2016-08-25 14:07 ` Richard Earnshaw (lists)
2016-08-23 9:18 ` [AArch64][SVE 20/32] Add support for tied operands Richard Sandiford
2016-08-25 13:59 ` Richard Earnshaw (lists)
2016-08-23 9:19 ` [AArch64][SVE 22/32] Add qualifiers for merging and zeroing predication Richard Sandiford
2016-08-25 14:08 ` Richard Earnshaw (lists)
2016-08-23 9:20 ` [AArch64][SVE 23/32] Add SVE pattern and prfop operands Richard Sandiford
2016-08-25 14:12 ` Richard Earnshaw (lists)
2016-08-23 9:21 ` [AArch64][SVE 24/32] Add AARCH64_OPND_SVE_PATTERN_SCALED Richard Sandiford
2016-08-25 14:28 ` Richard Earnshaw (lists)
2016-08-23 9:21 ` [AArch64][SVE 25/32] Add support for SVE addressing modes Richard Sandiford
2016-08-25 14:38 ` Richard Earnshaw (lists)
2016-09-16 12:06 ` Richard Sandiford
2016-09-20 13:40 ` Richard Earnshaw (lists)
2016-08-23 9:23 ` [AArch64][SVE 26/32] Add SVE MUL VL " Richard Sandiford
2016-08-25 14:44 ` Richard Earnshaw (lists)
2016-09-16 12:10 ` Richard Sandiford
2016-09-20 13:51 ` Richard Earnshaw (lists)
2016-08-23 9:24 ` [AArch64][SVE 27/32] Add SVE integer immediate operands Richard Sandiford
2016-08-25 14:51 ` Richard Earnshaw (lists)
2016-08-23 9:25 ` [AArch64][SVE 29/32] Add new SVE core & FP register operands Richard Sandiford
2016-08-25 15:01 ` Richard Earnshaw (lists)
2016-08-23 9:25 ` [AArch64][SVE 28/32] Add SVE FP immediate operands Richard Sandiford
2016-08-25 14:59 ` Richard Earnshaw (lists)
2016-08-23 9:26 ` [AArch64][SVE 30/32] Add SVE instruction classes Richard Sandiford
2016-08-25 15:07 ` Richard Earnshaw (lists)
2016-08-23 9:29 ` [AArch64][SVE 31/32] Add SVE instructions Richard Sandiford
2016-08-25 15:18 ` Richard Earnshaw (lists)
2016-08-23 9:31 ` [AArch64][SVE 32/32] Add SVE tests Richard Sandiford
2016-08-25 15:23 ` Richard Earnshaw (lists)
2016-08-30 21:23 ` Richard Sandiford [this message]
2016-08-31 9:47 ` Richard Earnshaw (lists)
2016-08-30 13:04 ` [AArch64][SVE 00/32] Add support for the ARMv8-A Scalable Vector Extension Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgze6jeh.fsf@e105548-lin.cambridge.arm.com \
--to=richard.sandiford@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).