From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88842 invoked by alias); 30 Aug 2016 21:23:33 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 86486 invoked by uid 89); 30 Aug 2016 21:23:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:l, sk:Richard, sk:richard, U*Richard.Earnshaw X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Aug 2016 21:23:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2BFBD349; Tue, 30 Aug 2016 14:23:21 -0700 (PDT) Received: from localhost (e105548-lin.manchester.arm.com [10.45.32.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 641623F220; Tue, 30 Aug 2016 14:23:20 -0700 (PDT) From: Richard Sandiford To: "Richard Earnshaw \(lists\)" Mail-Followup-To: "Richard Earnshaw \(lists\)" ,binutils@sourceware.org, richard.sandiford@arm.com Cc: binutils@sourceware.org Subject: Re: [AArch64][SVE 32/32] Add SVE tests References: <874m6b6ekq.fsf@e105548-lin.cambridge.arm.com> <878tvnzvae.fsf@e105548-lin.cambridge.arm.com> Date: Tue, 30 Aug 2016 21:23:00 -0000 In-Reply-To: (Richard Earnshaw's message of "Thu, 25 Aug 2016 16:23:01 +0100") Message-ID: <87lgze6jeh.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-08/txt/msg00330.txt.bz2 "Richard Earnshaw (lists)" writes: > On 23/08/16 10:31, Richard Sandiford wrote: >> This patch adds new tests for SVE. It also extends diagnostic.[sl] with >> checks for some inappropriate uses of MUL and MUL VL in base AArch64 >> instructions. >> >> OK to install? >> >> Thanks, >> Richard >> >> >> gas/testsuite/ >> * gas/aarch64/diagnostic.s, gas/aarch64/diagnostic.l: Add tests for >> invalid uses of MUL VL and MUL in base AArch64 instructions. >> * gas/aarch64/sve-add.s, gas/aarch64/sve-add.d, gas/aarch64/sve-dup.s, >> gas/aarch64/sve-dup.d, gas/aarch64/sve-invalid.s, >> gas/aarch64/sve-invalid.d, gas/aarch64/sve-invalid.l, >> gas/aarch64/sve-reg-diagnostic.s, gas/aarch64/sve-reg-diagnostic.d, >> gas/aarch64/sve-reg-diagnostic.l, gas/aarch64/sve.s, >> gas/aarch64/sve.d: New tests. >> > > I noticed while quickly going over this patch that there are some more > cases where error messages use 'should' when 'must' is more appropriate. > Can we please ensure that these are fixed as well. Apart from the one you noticed in patch 27 (which I'll fix), these come from pre-existing messages that are automatically extended to new operand types. Is it OK to change them as a follow-on patch? If so, I'll do it for all messages, rather than just touch the ones that affect SVE. Thanks, Richard