From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3C8F73858D28 for ; Fri, 6 Jan 2023 13:52:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C8F73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 306ANsLb022524 for ; Fri, 6 Jan 2023 13:52:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=fougb7zajbILIWsI/l3X3YQW4xKivwQLvVsIcjA1NIE=; b=tewOZ1a9DyIv29nJkm2+4Loqhf2Wt1+MmcatJ93qN+tiPxBDPObJ43P3wLgi2jUSsHt6 fq4UdSn4AnCDa3mWqZvgND7gdQ5xEX373zEHA2mDEzfKQtQeDWtryECJOOa7/ImOw484 K/4wJ8HYi00wSZsGQH36qCrtRpD0H7W6LzMVgRxde/NJhtXgnYDuDVd+9fc1X/0DK0eT Av++jrlFI0V43t49B4pSv91B6814ML+dnzE1Qy2CoiQDrLWfQZBFTF7qbaxt1rtjmSKg 6ZgSGDtZAcr458QD5P1bCL8tuFxE9q3soqsZK3SPt3gy3CRW6jYXOa8eMlvRTLginftV hw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtbv334rh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Jan 2023 13:52:27 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 306DkNFf040446 for ; Fri, 6 Jan 2023 13:52:26 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mwxkg6d65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Jan 2023 13:52:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jir41EpCxnJWTpe925a0n1TS5NCTfdkrRnDBY4xrOXVzi4L8hBK34v6qa+DoRBVm8YOjmItH0LktCoRk01bhu0d2W79cIIt9z0fAa6O9s6agNFCoii80qCtiXARH9z9EzO/2FZj4maPngfbng+KlUCODWtMt4hG11C584sufnBDARQeRhw2vRWENxsqxlRIC7YfurRW+rZvSs2xaGRpP3u/G7llvD8thfkzzQkIKijcMwS3rSF8RUcM/pm67fQo6xsqXxZBhDTJEM2lV5fnk/AHV7ziCnIwZx+bTLqhPh9MO11HVqos016edARuwr7Y2XpM3B3Ky8Ai6wI/cx+anBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fougb7zajbILIWsI/l3X3YQW4xKivwQLvVsIcjA1NIE=; b=CEG9nt+4GeoTemkIDeXGd6V9PBBx1xJkkiW92p0ijKfkpzOtzaaBtjCHZ/Jc0zfdPDcX77QQMPG2BLJfe/xiRX6AV4kjWqhSwWC5PCyk092TCO4OeworyG4B2wLd2XAMcXkAqb38HZmkaz+rsvWqDsTchnLrvXus1Gl3Q2vMis6F8zG6vYRm3g9hMtDfVJSyS0cmGA1OMoBOvvBqCkKPUryMYYCvcU2HtCs8NPmgw7kaoNUae4UMDK+A440BnSdxChEM7OLXqt3gvgepxOQLtWr5U7iHxvqM2rGIWUFzv4q9r3pzVpJx4rLJ9ygkiltnrCG6y9OiNY4LsRuqb8qURw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fougb7zajbILIWsI/l3X3YQW4xKivwQLvVsIcjA1NIE=; b=UjnAgBMXXvNbtJBb8RN8v020fnXKFpnuv3OPj1eeEz1I+9W/GPdQQGzEjL42s6ZZh3sTJgS5kljP79xYmz5X/Kn8VOzdQEZzW5M5P+orm4hbZOB/WvrL25MKY65LmlpUoPQ2al9yEr0ztpwShZ3e/A6XKhlsC9iTCG5bXNMYCe8= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BL3PR10MB6187.namprd10.prod.outlook.com (2603:10b6:208:3be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 13:52:24 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ebe9:b7c9:82ae:d256]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ebe9:b7c9:82ae:d256%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 13:52:24 +0000 From: "Jose E. Marchesi" To: "Guillermo E. Martinez" Cc: binutils@sourceware.org Subject: Re: [PATCH] bpf: fix error conversion from long unsigned int to unsigned int [-Werror=overflow] References: <20230106075816.387489-1-guillermo.e.martinez@oracle.com> Date: Fri, 06 Jan 2023 14:56:32 +0100 In-Reply-To: <20230106075816.387489-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez's message of "Fri, 6 Jan 2023 01:58:16 -0600") Message-ID: <87mt6vg41b.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::21) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|BL3PR10MB6187:EE_ X-MS-Office365-Filtering-Correlation-Id: 34974b18-603f-4e32-c515-08daefed3d59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XCRno0zd3kH/Ci9f5mLwKaAHjhqiziiAGaUHzUwa1Z2DSswqV5Sxke122MU74Lf6xEJXHAjoA/6OiGUo91HrBjWDIucLYm0aEj8A7hO4LK9zqzll0VSXldsFvMzt2Xr68ZzpjLW/2PL7bMiVOM9Ud6cC9+e2IOvKh1avuewd3iW1LZvNgsSFMRdtqCcZz7uvaDW+5frw4C+7oPhjlFDqZN6BgqglUpXJlfdbrYJfqWm/RJHuFSNcHdbEJoEn8Y7F5qBd2KHBU3D70THXxCrMg7XY7oS1fE5LUO/dMv988iOT4rg0EGXXut9ZV8bp7921OZr2J42ZqLt/vtElkvi05ix9zL0AJvJ8W51+z9SLYybmIbkM8N2JwEkvdsF6aBAoc61x/y5F4J7+eBH0UmNAC1GMYCX0CGGSVr3CjzpUG1IMhPBOSiN0iti8OgOt6pmJKKeWtHun/PcPTDiyD5hHXl0w14gpVoAxHlCbvTc3MBOuYzSXc1AQ+yjvj4Vayg/B2EI02fGD1Jvtx6Xck3cGguBr9nbkIyDwMqXQRAGaL4TGsQveassIfKy543AXPWMieNMHIpB23d2KK7NoVeAnu13YRDz8+WkEqlHSIWcrJ+bD3D5oIpeqpVGiPEVW64gE5npcNE7nV0bIuN8cxgmvgw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199015)(41300700001)(6862004)(5660300002)(8676002)(66476007)(316002)(66556008)(6666004)(66946007)(478600001)(4326008)(8936002)(2906002)(37006003)(6636002)(6506007)(6486002)(38100700002)(186003)(2616005)(26005)(6512007)(4744005)(36756003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fcVfEEKsDoSTPFiXN3bwSdtTQfYnAbrZV9YtVHYIPW57M5lY8H9WoDzfBqh8?= =?us-ascii?Q?hwDcjsJ2sjxj81W/uoxFje3UhH1vjqTI5Ia4jF7hdN85Bl5/HTk4L8b8PCLm?= =?us-ascii?Q?O3B8zRaP0ybNi4/OZ2p/ysaSOU0HQqwYbnz7fuRisOYmeb27Xicn4xi/GLmg?= =?us-ascii?Q?GoUUw69rtOGf6W3IOFKS92liqogHdqrq2MRpZz58RnLEqsOd+wzOQ2LeWcSP?= =?us-ascii?Q?1K0UVqZSo0YjGzkzSfMEjpu+DnpL1feBoNwmjGRHcLpRkzfyIumpeucLqTQH?= =?us-ascii?Q?o1c43ViJmg6hq/AAgSIFGfu2xlT+3hNRZqMW2VWzrNDRjEi/CHShOYkpAD8X?= =?us-ascii?Q?Cd8Od/jdf06bB3Qd32OH4P2/ESV+ghHS0iBH0MJ+JZOFDpBy8SjelnZlWfU0?= =?us-ascii?Q?0JPzpzQe5Mo+x3soIpccmcoV4aM4GPfFc6cAtjEu0V0UnpAQkp04nm/Mt8am?= =?us-ascii?Q?TgZOwVraJWKPlVuBvTkegd+p8xgsRlhArhP44Ke7TDoUEiPogC+rmf8LD1fB?= =?us-ascii?Q?dvaBqXaaVFtJXSuThkeI/HtTx9MHodJ7dE2ni9DevS5uXz4BGxqxvwXUgW0Q?= =?us-ascii?Q?8NyEFLbq64Q420xgoQwONGfunTPC4g+YjUHgkBVzgBV0VJvIfP6Bn3FuNQFo?= =?us-ascii?Q?T2V44yngA9aEOICrWMgeHAH6HZC57hkH+4DOphN/mr1WoznXBmJ0lpuKsh4f?= =?us-ascii?Q?VS5r4MUGaK4939ObVThWhJL9PEGZR3j0VcbqJOaLMYErOPN74mtBc+N8p7wR?= =?us-ascii?Q?NHa9iK1swqPgJADypFzdR9i0hIwdLRZ3iuNiT6OHaiN7yaz94QmWzGHOUU2w?= =?us-ascii?Q?1s2+Ir2Oh8XFlQmrsgdukyLIWGEcKvmRdo56MjMNoyGp98ZXlKvrio1R/Q/K?= =?us-ascii?Q?RxPL0TSv+FmFUbNX6Jlc/WO4hbrjrnGYgE1fK+FEFrBUp0BqXxwBDOMRIGGF?= =?us-ascii?Q?kt8eIXI7pRrScI4LMSKlkT/DafLEa1FiRwpWNien7NL8VRYXlUcemFFExZTZ?= =?us-ascii?Q?JnnHxPGRDiQOKVXJspMod6r0DqSvZF2AVf7msg/129T8ueL5HFry47F7Yx7K?= =?us-ascii?Q?Bhybe7eB88D95Lez5/NLIFl9EcqNwcfp/JcCMpOGG+7vyqCW5fw8da3Gqqhh?= =?us-ascii?Q?vKEHt1TmhCrFYDt7FcaqPAD1/u1vK9FAniDjUNIbkACq12+r7g1UdSkh0kCs?= =?us-ascii?Q?Nda//BNoSb3VgCY7baSH3P74q+Syl6fVCxm+YJNuhN0CUnktby0uZu1nckSd?= =?us-ascii?Q?5PPdXYPlEf+eNuno6ON9J1CXGWakXBjCasShLo0N2fNzXItL4YUdHbUm9HlP?= =?us-ascii?Q?t30AKO4TJ8MGePsCVQzoO7iP9uRYIN+DDzvl8A0e8NCI+B2PByHHh4a46dp6?= =?us-ascii?Q?9d/oSK5/v7aKER3TkZao2caS73mAo9obQ56Z+SCu2FYTI9USZ3XiJampLkUT?= =?us-ascii?Q?InrVuzupvYWYTDG1hFPwH2eDVi1JSYOiagGvTv72AxNQ1Tij33rRkCz6+xl9?= =?us-ascii?Q?8avFKty/ChDpU2Tj6qKOLYkEW5JGPeIPDi1tnF/7BV3ebZrUqsiJ/gQxQ2sJ?= =?us-ascii?Q?RnwoIN3EAz8rc4Z8738zLncmuEsKnnv48D3deZ554/BIT+gZGcsGSBVxMuOD?= =?us-ascii?Q?HA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LX6AAt//3e1/tU3axcUevT6THtjjQ2hrtEXy2V2pL764rGcUWIMpPYiBaE8XOKpABnK3Pj4lz2qf9bxqKl8+CLEjGnoS5CJ9ihSM4/gH3C7JJTzCfiPQz15e+r3RyY8q5YInbPANm5ncia6mQTkipHor2fBlmakS2NmkrhklbZOisd+fwbDhi1fLQh92cs9TjgBxO2o5CHDNhyfZnowWQDo3p58LgcOFg/Y05qSCdZdw32cusOX9TXInA2R/ojtWfxTHN+6pU2EzIvMSYhwHiCBtmH3kLd1PDi7E/StUWuCObb95XKFhTl7yOE3iP4w+EBzGlY/tcVz8QyPTkkPCRovnqAtBepiqlgMd16ulQ8Qp0zAKExFsxxloXsDlTXsVgnDt6RjJN9bQnVGZsIOF4TmZjAam7jx/VoZvJrQ8cd9XVKSuGq2W6wAVYwK82u+HmerIfzn4+STQHnoV2c6o6LQI2F4R/VQ04jfVNfzgHCQz8tT3+eO02+maFouKbt9RgW+ybLkO4LmhbZkmYkytdukUT8R892qFgnBWmHmE+IIyHfCbxdutZu7RYrjvrguJQmiNPDZFGt5BPiAtmHzHcfVz0tY+6rAG3YQCI6bGhfl98F+KQIg3t8JyMY8MhcL57enb4yDbJba7XbyEPUosphRAmb20tNRt2J2o/p2pYANinsEdPL2IlLxg5u7I3nkMn5fBNXkbDfNnTBJZq77zzOAlzF1uhG82pHLYfpBifrnWV5+FkVM8M4hz8pR5vNpy X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34974b18-603f-4e32-c515-08daefed3d59 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 13:52:24.3489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZiIiTUjYgD/OpHNbxLqPROiN/HiTqnQE9/FS4gBHMx8hyUQKOQhCSX2+uMi4a4UMKJMPzIaV49qjUmUa0/UkLBOGtqAslpGTxE6k565Z5Bo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6187 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_08,2023-01-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=969 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060109 X-Proofpoint-GUID: aeQA47Es0YmZiuGbzndJQuRzwAeqO40- X-Proofpoint-ORIG-GUID: aeQA47Es0YmZiuGbzndJQuRzwAeqO40- X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Guillermo. > cpu/ > * bpf.cpu (define-call-insn): Remove `src' field from > instruction mask. I don't think this description accurately describes the real change? You are basically adding an opcode for `src' to the instruction format. > diff --git a/cpu/bpf.cpu b/cpu/bpf.cpu > index 13dde7094c8..2ae74fc4c18 100644 > --- a/cpu/bpf.cpu > +++ b/cpu/bpf.cpu > @@ -768,7 +768,7 @@ > "call" > (endian-isas x-endian) > "call $disp32" > - (+ disp32 (f-offset16 0) (f-regs 0) > + (+ disp32 (f-offset16 0) (.sym src x-endian) ((.sym f-dst x-endian) 0) > OP_CLASS_JMP OP_SRC_K OP_CODE_CALL) > (c-call VOID > "bpfbf_call" disp32 (ifield (.sym f-src x-endian))) The BPF side of the patch is OK. Thanks!