From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EFB083858421 for ; Thu, 22 Sep 2022 09:08:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EFB083858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663837702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y3UxZgbpyqhVVMmdm5dCyZoDRZuADhLKiiS+hOLAaBE=; b=E8+HmGi7bLzZ5RkNntC8mdve1W0OX+7o+OE8KvwhmWpJcfqsHuUxb/K102N79q+04bLdyQ D4rfMqgxeA27iovMvbNMSE93iVPh0/mBzI+U8rk40bWNxJnIC48BxRTbItvf4wMVL8BckN TvPnSdZnnw7AuyhkQrVXMUceJnqiqgg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-37-ypD7o1tNMzag6NvoQZJhrw-1; Thu, 22 Sep 2022 05:08:21 -0400 X-MC-Unique: ypD7o1tNMzag6NvoQZJhrw-1 Received: by mail-wm1-f72.google.com with SMTP id b5-20020a05600c4e0500b003b499f99aceso797199wmq.1 for ; Thu, 22 Sep 2022 02:08:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=y3UxZgbpyqhVVMmdm5dCyZoDRZuADhLKiiS+hOLAaBE=; b=DF/LNDblY7xom8I/W+4dr9tyHiYHUuXUTyTGxPo2MIOlVxmr/Q3sbdaB3Hxy1QRuJT SWC/xKGEG9RmCQVIdiau+mkGQfDK7+uV9WJfBgNh60RO5bFRpmzVqkNoTtgdNXf5KGxe lqZJL0xHa7wp3SZkiYU5nrpgRvGawG1JbDtuk/HEgvuMHy1GijQ41F1fSI+/VdJu8I4X 3DMMd/8GIXZ6t3Jmqa+HPkkvxRlzLZK8Qd17xgAOhk/48jVTwe+cLHmPI9ustdcJi5Hf gEqedQTgC56A6lFLTAOyAbRtPi9l3c5ud3FZ2EZeQjDIl5Dbvc24VrnjmL4qmTBgp2wy /5eg== X-Gm-Message-State: ACrzQf3zxrqZzBdheR+A+XMiT/z7rNBAp97g/FmV4PfMIHuO+BrbwjGx nJ7KfiDhVbBOrr3o0cnvJXyOn6HVcGtUEFU5huMTPGj+TUs5kZVAnsZ4jvvXLh/sX1C7Llyg+T6 O+R9DCT9jOcZNuY18Qw== X-Received: by 2002:a5d:6d82:0:b0:22b:b9f:d7fb with SMTP id l2-20020a5d6d82000000b0022b0b9fd7fbmr1285199wrs.580.1663837700189; Thu, 22 Sep 2022 02:08:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5MHkQskFJ/repWL9yu0Efnq2h1P+OntcUxwc7dt4r2yeHNJTHT/cnMcbM+iSodWgeWu07Gxg== X-Received: by 2002:a5d:6d82:0:b0:22b:b9f:d7fb with SMTP id l2-20020a5d6d82000000b0022b0b9fd7fbmr1285186wrs.580.1663837699975; Thu, 22 Sep 2022 02:08:19 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id c18-20020a5d4152000000b0022ac119fcc5sm4449723wrq.60.2022.09.22.02.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 02:08:19 -0700 (PDT) From: Andrew Burgess To: Richard Earnshaw , binutils@sourceware.org Subject: Re: [PATCH 1/2] opcodes/arm: add missing ';' characters In-Reply-To: <114cf7e5-aacf-ddba-4232-806278746aff@foss.arm.com> References: <8cc1b606a6e5c5164b03389d04f127f7909a2a36.1663334366.git.aburgess@redhat.com> <114cf7e5-aacf-ddba-4232-806278746aff@foss.arm.com> Date: Thu, 22 Sep 2022 10:08:18 +0100 Message-ID: <87mtarepz1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Earnshaw writes: > On 16/09/2022 14:21, Andrew Burgess via Binutils wrote: >> I spotted a couple of places where the ARM disassembler produces what >> seems to be some comment style text '@ Impl Def' without including a >> comment character ';'. In other places where we have similar messages >> a comment character is emitted, so I suspect this was just an >> oversight. >> >> Fixed in this commit by adding two new comment characters, and >> updating the expected test results. > > No, this is incorrect. @ is the comment marker on Arm; ';' is the > statement separator. > Wow! OK. So, I tested what you said, and you'd absolutely correct. But does that mean all the places where the disassembler prints what (I believe) is clearly a comment without printing '@' is actually a bug? Or am I missing something really subtle here? Here are just a few of the many examples that can be found in the gas testsuite for ARM: sub r0, r0, #32, 24 ; 0x2000 add r0, r0, #32, 24 ; 0x2000 nop ; (mov r0, r0) subhi pc, pc, #805306368 ; 0x30000000 ldrh r3, [pc, #-8] ; 8 ldrsb r2, [r3, #255] ; 0xff ldrsh r1, [r4, #-250] ; 0xffffff06 ldrsb r1, [r5, #240] ; 0xf0 strh r2, [pc, #48] ; 68 There are many more, but they are all pretty similar in content. Should I instead propose changing all these to use '@' ? Thanks, Andrew