From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70802 invoked by alias); 3 May 2019 19:31:52 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 70793 invoked by uid 89); 3 May 2019 19:31:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 19:31:51 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x43JIeWD079714; Fri, 3 May 2019 19:31:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=GBOc6t5DnbsB1ZlKZtk6f5qA8wJtDY+DhzV3F0LHOnA=; b=kFarb0rABHzJCjVJ/h5ofAhpA0hhOE0cOWBCPmna92oSX0g0ck3stjp2UhAvCtM6cDUw /O2chX8GIY31cmgmmB2rZGCZ4k7eisrLv3ZbjjoaFSyAyFQ6OFMbVlKyLbYqlAbOCPgN +M2VnsnI6oqQ5CQOkdcf4zb67B7faakYMaFPyg/7WygmiJeFpItFDqEiPB6hhqBk/1Y0 wFhLcuOot0N4lMFeBRPDGrca7JkY2fbPIx6pA0pVTE9p8pqiOhX8pIvL43wATwQt/87g ncOGq0AzIgoCmHengU/AKggXXofJ3WgsIFUityHD7p4nPWC1ecYfmzrbY5Eo9DHluGN+ Fg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2s6xj00tmc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 May 2019 19:31:45 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x43JVinm137319; Fri, 3 May 2019 19:31:45 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2s7p8agqtr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 May 2019 19:31:45 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x43JVgsH022522; Fri, 3 May 2019 19:31:42 GMT Received: from loom (/81.187.191.129) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 May 2019 12:31:42 -0700 From: Nick Alcock To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH 05/19] libctf: error handling References: <20190430225706.159422-1-nick.alcock@oracle.com> <20190430225706.159422-6-nick.alcock@oracle.com> <43876c47-526e-75e3-a918-24c4541342fb@redhat.com> Date: Fri, 03 May 2019 19:31:00 -0000 In-Reply-To: <43876c47-526e-75e3-a918-24c4541342fb@redhat.com> (Nick Clifton's message of "Thu, 2 May 2019 17:10:14 +0100") Message-ID: <87muk3uyg3.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00119.txt.bz2 On 2 May 2019, Nick Clifton uttered the following: > Hi Nick, > >> +static const char *const _ctf_errlist[] = { >> + "File is not in CTF or ELF format", /* ECTF_FMT */ > > Have you considered allowing these strings to be translated ? Sure! But gettextization is a bigger job I haven't even looked at yet. (e.g. do we need to gettextize all the debugging strings, too?) I suppose we'd translate the error messages in particular via explicit gettext() calls in ctf_errmsg()? (Of course, ctf_errmsg() can also return a strerror() value, but I suppose libc will take care of translating that for us.) (But if you call gettext() explicitly, presumably you have to mark the translatable strings in the array with something too, or they won't land in the po files? I have no idea, and haven't read the gettext manual in far too many years... I'd have to do some research first.)