From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13362 invoked by alias); 1 Nov 2010 21:34:50 -0000 Received: (qmail 13321 invoked by uid 22791); 1 Nov 2010 21:34:50 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Nov 2010 21:34:45 +0000 Received: by wyf23 with SMTP id 23so6289841wyf.0 for ; Mon, 01 Nov 2010 14:34:43 -0700 (PDT) Received: by 10.227.142.133 with SMTP id q5mr12603225wbu.3.1288647283118; Mon, 01 Nov 2010 14:34:43 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107]) by mx.google.com with ESMTPS id h29sm5617147wbc.9.2010.11.01.14.34.41 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 01 Nov 2010 14:34:42 -0700 (PDT) From: Richard Sandiford To: "Maciej W. Rozycki" Mail-Followup-To: "Maciej W. Rozycki" ,binutils@sourceware.org, rdsandiford@googlemail.com Cc: binutils@sourceware.org Subject: Re: [PATCH 1/5] MIPS/GAS: Fix o32 LD to the base register References: <87vd4gd995.fsf@firetop.home> Date: Mon, 01 Nov 2010 21:34:00 -0000 In-Reply-To: <87vd4gd995.fsf@firetop.home> (Richard Sandiford's message of "Mon, 01 Nov 2010 21:28:06 +0000") Message-ID: <87mxpsd8y7.fsf@firetop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00019.txt.bz2 Richard Sandiford writes: > I still don't like the way that you're matching ECOFF and ELF offsets > in a single test, allowing two load offsets when (for each format > individually) only one offset is actually acceptable. But patch 5 > is OK nonetheless. That is, the relevant parts of 5 are OK nonetheless (i.e. the parts that cover patch 1). And I suppose that won't include any of the ELF/ECOFF thing anyway. Richard