From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 3FD153858CD1 for ; Tue, 12 Mar 2024 06:52:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FD153858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FD153858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710226366; cv=none; b=bn+oKyG4xwHqrpca1rVPrRUycRstE+MrF8Tz2CMCbg0xQZV8SODe8T5CSl038q/hfCVf78NgyZvOnJgyf7PFshf8lrSACacma3fvjBKQojYn7KY/skLoxc9Ch9hp+qZwneSpEW7frGt0t1267uAnWRThVajEdD04KAHVfHzOSVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710226366; c=relaxed/simple; bh=ZuHMW/Z0PFMf36yb4V0CRLn28eZwkJvR2AK+monJm4g=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=qQ1JUhG2TdCKsDG4hOsYZ/4lElfXPP3TvvvEI0h3dxeLlKI/pR22pbBjnFbunpSpQJoCwGOJgm1ufY5QddNF38kIr+2adx2PVU2D1ofhMTmEpf538VlyrrdZNzNy1bHblthkESN/b3qig1dolmjySPiwWyBzvtvTq5GOxoXL5fI= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: Nick Alcock Cc: Andreas Schwab , binutils@sourceware.org, torbjorn.svensson@foss.st.com, yvan.roux@foss.st.com Subject: Re: [PATCH] libctf: check for problems with error returns In-Reply-To: <87y1ao243l.fsf@esperi.org.uk> (Nick Alcock's message of "Mon, 11 Mar 2024 15:14:06 +0000") Organization: Gentoo References: <20231009151146.3818141-1-torbjorn.svensson@foss.st.com> <20231013140152.427376-1-nick.alcock@oracle.com> <87sf2evr35.fsf@esperi.org.uk> <87zfv8p1ie.fsf@gentoo.org> <87y1ao243l.fsf@esperi.org.uk> User-Agent: mu4e 1.12.0; emacs 30.0.50 Date: Tue, 12 Mar 2024 06:52:39 +0000 Message-ID: <87o7bk2b7s.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Nick Alcock writes: > On 9 Mar 2024, Sam James told this: > >> Andreas Schwab writes: >> >>> On Jan 30 2024, Nick Alcock wrote: >>> >>>> diff --git a/libctf/testsuite/libctf-writable/libctf-errors.c b/libctf/testsuite/libctf-writable/libctf-errors.c >>>> index 71f8268cfad..2790b608396 100644 >>>> --- a/libctf/testsuite/libctf-writable/libctf-errors.c >>>> +++ b/libctf/testsuite/libctf-writable/libctf-errors.c >>>> @@ -12,7 +12,7 @@ main (int argc, char *argv[]) >>>> ctf_dict_t *fp; >>>> ctf_next_t *i = NULL; >>>> size_t boom = 0; >>>> - ctf_id_t itype, stype; >>>> + ctf_id_t itype = 0, stype = 0; >>>> ctf_encoding_t encoding = {0}; >>>> ctf_membinfo_t mi; >>>> ssize_t ret; >>> >>> This silences the warnings and all dependent tests pass. >> >> I just ran into this myself today, looks like it never got committed? > > Ugh sorry you're quite right! I'll rebase, retest, and push today. Mea > culpa, it got lost toward the base of the huge pile of stuff I'm working > on right now. It happens ;) Cheers Nick!