From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id CC6A63857C4C for ; Tue, 27 Sep 2022 18:08:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC6A63857C4C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id BCBFF10046EAF for ; Tue, 27 Sep 2022 18:08:44 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id dF0do7TX9lpGedF0eouF2T; Tue, 27 Sep 2022 18:08:44 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=I/ag+Psg c=1 sm=1 tr=0 ts=63333c2c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=kBeY8xdUWNEe0GNCGREA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Fh6JndrcYqdplWiu8Fj5lxcTM5L9G1ous3BeuyI0z00=; b=ZK41mn7+NYe2kIjRrN6Z85urhq L8Uog2WGD+QZnk7VrstZB6ibSvfU3Mvn3IhGlxX2ohtfOuGsawEjODxgr2u9DsCmBGEerYdLob6nk Xc0wtKPor6n662ZHGLKbRALUH; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56578 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1odF0c-003IEF-S5; Tue, 27 Sep 2022 12:08:42 -0600 From: Tom Tromey To: Fangrui Song via Gdb-patches Cc: Alan Modra , Jan Beulich , Nick Clifton , Simon Marchi , Fangrui Song , binutils@sourceware.org Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections References: <20220923040837.550160-1-maskray@google.com> X-Attribution: Tom Date: Tue, 27 Sep 2022 12:08:36 -0600 In-Reply-To: <20220923040837.550160-1-maskray@google.com> (Fangrui Song via Gdb-patches's message of "Thu, 22 Sep 2022 21:08:37 -0700") Message-ID: <87o7v0zo4b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1odF0c-003IEF-S5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56578 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1008.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Fangrui Song via Gdb-patches writes: > PR29397 PR29563: The new configure option --with-zstd defaults to auto. > If pkgconfig/libzstd.pc is found, define HAVE_ZSTD and support zstd > compressed debug sections for most tools. > * bfd: for addr2line, objdump --dwarf, gdb, etc > * gas: support --compress-debug-sections=zstd > * ld: support ELFCOMPRESS_ZSTD input and --compress-debug-sections=zstd > * objcopy: support ELFCOMPRESS_ZSTD input for > --decompress-debug-sections and --compress-debug-sections=zstd > * gdb: support ELFCOMPRESS_ZSTD input. The bfd change references zstd > symbols, so gdb has to link against -lzstd in this patch. This also needs some change to the sims. I see failures like this with git master: make[4]: Entering directory '/home/tromey/gdb/build/sim/bpf' CCLD run ../../bfd/libbfd.a(compress.o):compress.c:function decompress_contents: error: undefined reference to 'ZSTD_decompress' ../../bfd/libbfd.a(compress.o):compress.c:function decompress_contents: error: undefined reference to 'ZSTD_isError' (unknown):176: error: undefined reference to 'ZSTD_compress' (unknown):179: error: undefined reference to 'ZSTD_isError' collect2: error: ld returned 1 exit status You'll see them all if you do a build with all sims enabled. thanks, Tom