From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7216 invoked by alias); 8 Oct 2013 19:23:07 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 7205 invoked by uid 89); 8 Oct 2013 19:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f182.google.com Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 08 Oct 2013 19:23:06 +0000 Received: by mail-wi0-f182.google.com with SMTP id ez12so7209747wid.9 for ; Tue, 08 Oct 2013 12:23:03 -0700 (PDT) X-Received: by 10.180.76.48 with SMTP id h16mr25174695wiw.32.1381260183414; Tue, 08 Oct 2013 12:23:03 -0700 (PDT) Received: from localhost ([2.28.235.51]) by mx.google.com with ESMTPSA id fb9sm8123226wid.7.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 08 Oct 2013 12:23:02 -0700 (PDT) From: Richard Sandiford To: "Maciej W. Rozycki" Mail-Followup-To: "Maciej W. Rozycki" ,Chao-Ying Fu , "binutils\@sourceware.org" , rdsandiford@googlemail.com Cc: Chao-Ying Fu , "binutils\@sourceware.org" Subject: Re: [PATCH] MIPS SIMD Architecture (MSA) patch References: <81D57523CB07B24881D63DE650C6ED82019034B4@BADAG02.ba.imgtec.org> Date: Tue, 08 Oct 2013 19:23:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Tue, 8 Oct 2013 18:20:12 +0100") Message-ID: <87ob6zr2i1.fsf@talisman.default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00093.txt.bz2 "Maciej W. Rozycki" writes: >> Index: opcodes/mips-dis.c >> =================================================================== >> RCS file: /cvs/src/src/opcodes/mips-dis.c,v >> retrieving revision 1.116 >> diff -u -p -r1.116 mips-dis.c >> --- opcodes/mips-dis.c 19 Aug 2013 18:56:59 -0000 1.116 >> +++ opcodes/mips-dis.c 8 Oct 2013 00:30:27 -0000 >> @@ -738,10 +747,22 @@ parse_mips_dis_option (const char *optio > [...] >> if (CONST_STRNEQ (option, "virt")) >> { >> mips_ase |= ASE_VIRT; >> - if (mips_isa & ISA_MIPS64R2) >> + if ((mips_isa & INSN_ISA_MASK) == ISA_MIPS64R2) >> mips_ase |= ASE_VIRT64; >> return; >> } > > This looks like an unrelated bug fix to me that should be applied > separately. Yeah, this part is OK on its own, thanks. I think both it and your earlier encoding fix should go on 2.24 too. Richard