From: Thomas Schwinge <tschwinge@gnu.org>
To: "H\.J\. Lu" <hjl.tools@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: PATCH: PR ld/12730: regression] crash when allocating in a static constructor
Date: Sun, 19 Jun 2011 19:18:00 -0000 [thread overview]
Message-ID: <87oc1tzl3w.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <BANLkTimWntPAuVK8zNzK0kek0nFcfUJW+A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]
Hallo!
On Sat, 7 May 2011 06:39:42 -0700, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> Here is the updated patch. OK to install?
(Has been in the mean time.)
> ld/testsuite/
>
> 2011-05-07 H.J. Lu <hongjiu.lu@intel.com>
>
> PR ld/12730
> * ld-elf/elf.exp (array_tests): Add "pr12730".
> (array_tests_pie): New.
> (array_tests_static): Add -static for ""static init array mixed".
> Add "static pr12730". Run array_tests_pie for Linux.
> diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
> index 73a417c..6808d8a 100644
> --- a/ld/testsuite/ld-elf/elf.exp
> +++ b/ld/testsuite/ld-elf/elf.exp
> [...]
> +
> +# Run PIE tests only on Linux.
> +if { [istarget "*-*-linux*"] } {
> + run_ld_link_exec_tests $xfails $array_tests_pie
> +}
> +
> [...]
Why, oh why? :-)
ld/testsuite/
* ld-elf/elf.exp: Execute array_tests_pie tests on *-*-gnu*, too.
---
ld/testsuite/ld-elf/elf.exp | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
index ff0f03e..da24bed 100644
--- a/ld/testsuite/ld-elf/elf.exp
+++ b/ld/testsuite/ld-elf/elf.exp
@@ -150,8 +150,8 @@ set array_tests_static {
set xfails [list "*-*-netbsdelf*"]
run_ld_link_exec_tests $xfails $array_tests
-# Run PIE tests only on Linux.
-if { [istarget "*-*-linux*"] } {
+if { [istarget *-*-linux*]
+ || [istarget *-*-gnu*] } {
run_ld_link_exec_tests $xfails $array_tests_pie
}
--
tg: (38b56ed..) hurd/testsuite (depends on: master)
OK to commit? (Or are such changes even obvious and don't need
approval?)
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2011-06-19 19:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 5:19 H.J. Lu
2011-05-05 8:27 ` Alan Modra
2011-05-05 13:27 ` H.J. Lu
2011-05-05 14:13 ` Alan Modra
2011-05-06 13:23 ` H.J. Lu
2011-05-06 16:16 ` H.J. Lu
2011-05-07 8:11 ` Alan Modra
2011-05-07 13:40 ` H.J. Lu
2011-05-07 14:05 ` Alan Modra
2011-05-09 13:53 ` Alan Modra
2011-05-09 14:09 ` H.J. Lu
2011-06-19 19:18 ` Thomas Schwinge [this message]
2011-06-21 15:14 ` Nick Clifton
2011-05-15 10:14 Craig Southeren
2011-05-16 0:15 ` Alan Modra
2011-05-16 0:37 ` Craig Southeren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oc1tzl3w.fsf@kepler.schwinge.homeip.net \
--to=tschwinge@gnu.org \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).