public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@CS.UCLA.EDU>
To: Jakub Jelinek <jakub@redhat.com>
Cc: binutils@sources.redhat.com, libc-alpha@sources.redhat.com,
	        Michael Meeks <michael.meeks@novell.com>
Subject: Re: [PATCH] DT_GNU_HASH: ~ 50% dynamic linking improvement
Date: Wed, 28 Jun 2006 19:10:00 -0000	[thread overview]
Message-ID: <87odwdyv8n.fsf@penguin.cs.ucla.edu> (raw)
In-Reply-To: <20060628170900.GX3823@sunsite.mff.cuni.cz> (Jakub Jelinek's message of "Wed, 28 Jun 2006 19:09:00 +0200")

Jakub Jelinek <jakub@redhat.com> writes:

> (Dan Bernstein's string hash function posted eons ago on comp.lang.c.)

Bernstein now prefers XOR, i.e.,
"h = h * 33 ^ c;" instead of
"h = h * 33 + c;".  Did you try that as well?
Several sources indicate it's a bit better, e.g.,
<http://eternallyconfuzzled.com/tuts/hashing.html#djb2>.

> We have tested a bunch of different hash functions

Which hash functions did you try?  One-at-a-time?  FNV?  You'll
probably get hassled by hash triviists (like me :-) no matter which
function you choose, but you can forstall that to some extent by
mentioning which functions you tested.

(Thanks for doing all this, by the way.)

  reply	other threads:[~2006-06-28 18:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 17:21 Jakub Jelinek
2006-06-28 19:10 ` Paul Eggert [this message]
2006-06-28 20:25   ` Roland McGrath
2006-06-28 21:40   ` Jakub Jelinek
2006-06-28 21:46     ` Paul Eggert
2006-06-28 21:49       ` Roland McGrath
2006-06-29  0:35       ` Ulrich Drepper
2006-06-29 19:39 ` Michael Meeks
2006-06-29 21:52   ` Jakub Jelinek
2006-07-03 15:12     ` DT_GNU_HASH: reducing working set Michael Meeks
2006-07-03 15:59       ` Jakub Jelinek
2006-07-03 18:18         ` Michael Meeks
2006-07-03 21:05           ` [PATCH] DT_GNU_HASH: reducing working set ... (take 2) Jakub Jelinek
2006-06-30 23:55   ` DT_GNU_HASH: ~ 50% dynamic linking improvement Ulrich Drepper
2006-07-03  9:26   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87odwdyv8n.fsf@penguin.cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=binutils@sources.redhat.com \
    --cc=jakub@redhat.com \
    --cc=libc-alpha@sources.redhat.com \
    --cc=michael.meeks@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).