From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mav.lukeshu.com (mav.lukeshu.com [IPv6:2001:19f0:5c00:8069:5400:ff:fe26:6a86]) by sourceware.org (Postfix) with ESMTPS id 2DAB03858D26; Mon, 10 Jun 2024 03:04:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DAB03858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lukeshu.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lukeshu.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DAB03858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:19f0:5c00:8069:5400:ff:fe26:6a86 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717988643; cv=none; b=waf+3ZXxwUvzAtarAfVbPAt7hHmJtFn8fZUhowbic06/T9rNXt5WM2uItNB/8ko/5QuonGl29OkfMg258UbaYS7+PGm3byWzn+5Cjlt1lSfs7IfcFNSqEooAJ4MD/cGTM1RY+FbwYLGaPdKhSS++JB6IpGFtHOJ/76XB7rt7fqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717988643; c=relaxed/simple; bh=pZhy4//zxBxTjUeQWZssg9PHOauzAzFR6MRqB0mWf2E=; h=Date:Message-ID:From:To:Subject:MIME-Version; b=CHJpcJbCG0DWVlxb3YV1xcy7IoNI6xQ6qn18MuSJBSFDGSe1y1Wx3deCZxLNGIRavcky8flwtWJbGn9/6qhr8d48lehSOfdZ7pECLLmoFET0UATGSF1b/E6yaaNXYJNLrW2QDffBU2YjirujiLuHyFtUEzShjiJ7y7cWCocI5SE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from lukeshu-thinkpad-e15 (unknown [IPv6:2601:280:5e01:2a5d:aee0:10ff:fe55:8023]) by mav.lukeshu.com (Postfix) with ESMTPSA id A2B658067E; Sun, 9 Jun 2024 23:04:00 -0400 (EDT) Date: Sun, 09 Jun 2024 21:04:00 -0600 Message-ID: <87plspxzvj.wl-lukeshu@lukeshu.com> From: Luke T. Shumaker To: Jan Beulich Cc: "Luke T. Shumaker" , "Alfred M. Szmidt" , Ralf Wildenhues , Tom Tromey , binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] zlib: Remove files that should certainly not be checked in In-Reply-To: <87cyotdw8b.wl-lukeshu@lukeshu.com> References: <20240606201145.1747021-1-lukeshu@lukeshu.com> <20240606201145.1747021-4-lukeshu@lukeshu.com> <87cyotdw8b.wl-lukeshu@lukeshu.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 07 Jun 2024 01:53:56 -0600, Luke T. Shumaker wrote: > > On Fri, 07 Jun 2024 00:24:53 -0600, > Jan Beulich wrote: > > > > On 06.06.2024 22:11, Luke T. Shumaker wrote: > > > The *.obj files are compiled binaries that should have been > > > .gitignore'd > > > > Are you sure about this? > > Good question. Here's my reasoning about how sure I am: > > ... I'm adding this justification to the commit message in v2 (which I'm about to submit). > > Further, if these really were to be .gitignore-d, wouldn't the > > patch sensibly be adding them (perhaps as *.obj pattern) to > > .gitignore? > > Yes, that would be a good thing to do. This patch series IMO > highlights a lot of good things to do. I'm going ahead and adding the .gitignore change in v2. -- Happy hacking, ~ Luke T. Shumaker