From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 0903E3858C83 for ; Fri, 21 Apr 2023 15:07:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0903E3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-329673008e3so18633235ab.2 for ; Fri, 21 Apr 2023 08:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1682089645; x=1684681645; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KCV6674Wx9zCJDbRnIY7lMGs/bERE6YUa9dwhcS5lIg=; b=CxBnXu8w3i5t7EahDasVu3WTNA9brUTvLWfj3wfUSt1fd/V/uyV8Tj9DCW1ggJXIUj QiW7AD4yT+e0y8W/uvJoD/R7NU3cg0c1AjjN6EgetGnhzDxpQLTy3182m93wyMHQg7/o tQr9P0Lw1ZwmhXEB7V9w0kdXONJYwDJhG8sWODbVPaaNJMqC/ourjozQFyTlDS46swpn AlgIhSeSulv5AjA/GVtGpzyJi45w37vTukmscVwWuHmj9zC6MkC/9EBxupvp1KlkWHts cXPcVuGUrt9x7ADu+ZV2rz3SJbwKwNG6oyVO+mYp0ks1DquAPQkM05jHR/UObPqg/TNZ +VkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682089645; x=1684681645; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCV6674Wx9zCJDbRnIY7lMGs/bERE6YUa9dwhcS5lIg=; b=isBSsfdySfZZijG4aSW9MCsWSfUSGKMv4PfAWxvM9iFa5Nhma78oHBnfpZBfKx91cT iRvppEoBUG1+eQ+W4dESSD7WSLGdIWKYkeSHOKNgUZTvN8S515YkAaEpHYkKB3VJc8al bHJ/5pM2L3UVBWopW+xMOn7mQyUhQ+z1C6n6wxEqOLVeeB1EGHYAX12fBf3v3za+6nHj 3x1IrxrHmEILEREt7ba0f79mmZr9C9Te/tvmSew0rfK7zpG9ZNdJ6iwoY6E3m//AviPj hNg8jcT3f2PRsFxljY4mujC0FZLDYQDh6fT1lCwU8KsjE8Urg3YOVENl9/AYq7bl/5WL XKrQ== X-Gm-Message-State: AAQBX9epkcCHlkjwoXjlnq2zN3uX1uWvQsDih/2IkqKZNlhieRuDg8Fj educYnWYaUX0QVv1W4WwGLZkLWBuGyzRUt8CIXqtuw== X-Google-Smtp-Source: AKy350Zw8ZKuwHHU+QjQMwIue+09SKvbi2mrKoIL2uaPd+dY/Mrs5JpKJOpB26X1jvI5lDmwqtspVw== X-Received: by 2002:a92:6c10:0:b0:32c:88d9:af1d with SMTP id h16-20020a926c10000000b0032c88d9af1dmr4009347ilc.13.1682089645254; Fri, 21 Apr 2023 08:07:25 -0700 (PDT) Received: from murgatroyd (71-211-191-82.hlrn.qwest.net. [71.211.191.82]) by smtp.gmail.com with ESMTPSA id u17-20020a056e02111100b0032aeccff2b1sm1139574ilk.51.2023.04.21.08.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 08:07:24 -0700 (PDT) From: Tom Tromey To: Jan Beulich Cc: Tom Tromey , binutils@sourceware.org Subject: Re: [PATCH] Fix -Wmaybe-uninitialized warning in opcodes/i386-dis.c References: <20230421130802.2964785-1-tromey@adacore.com> <703cf414-4714-fb3d-66bb-6acbb499e063@suse.com> X-Attribution: Tom Date: Fri, 21 Apr 2023 09:07:24 -0600 In-Reply-To: <703cf414-4714-fb3d-66bb-6acbb499e063@suse.com> (Jan Beulich's message of "Fri, 21 Apr 2023 15:24:09 +0200") Message-ID: <87pm7xz32r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Jan" == Jan Beulich writes: Jan> Would be nice if you could (also) state the compiler variant and Jan> version, as that's generally more meaningful than a distro one. I updated the commit message with this info. >> This patch fixes the warning, but I don't know whether it's really >> correct -- I just copied a pattern from eariler in this function. Jan> It is correct, and it was my bad to not check the function's return Jan> value. Please commit. Thank you for the review. I'm checking it in. Tom