From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by sourceware.org (Postfix) with ESMTPS id C7D2B3842403 for ; Wed, 22 Jul 2020 09:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C7D2B3842403 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06M9GoLL041051 for ; Wed, 22 Jul 2020 09:35:52 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 32brgrj4xs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 22 Jul 2020 09:35:52 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06M9I91x168764 for ; Wed, 22 Jul 2020 09:33:51 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 32eej5knp5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 22 Jul 2020 09:33:51 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06M9XovI018511 for ; Wed, 22 Jul 2020 09:33:50 GMT Received: from loom (/81.187.191.129) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 22 Jul 2020 09:33:49 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: Re: [PATCH 50/59] fixup! libctf, dedup: add deduplicator References: <20200630233146.338613-1-nick.alcock@oracle.com> <20200630233146.338613-51-nick.alcock@oracle.com> Emacs: don't try this at home, kids! Date: Wed, 22 Jul 2020 10:33:48 +0100 In-Reply-To: <20200630233146.338613-51-nick.alcock@oracle.com> (Nick Alcock via Binutils's message of "Wed, 1 Jul 2020 00:31:37 +0100") Message-ID: <87pn8nx5ab.fsf_-_@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9689 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 suspectscore=1 spamscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007220071 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9689 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 suspectscore=1 adultscore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007220071 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 09:35:54 -0000 Fix a confusing comment (ctf_dedup_hash_type was once split in two, and this comment is a relic of that era). --- libctf/ctf-dedup.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libctf/ctf-dedup.c b/libctf/ctf-dedup.c index c7badcd17a1..670d14f77fb 100644 --- a/libctf/ctf-dedup.c +++ b/libctf/ctf-dedup.c @@ -971,10 +971,7 @@ ctf_dedup_rhash_type (ctf_file_t *fp, ctf_file_t *input, ctf_file_t **inputs, return NULL; } -/* Internal implementation of ctf_dedup_hash_type (below), which is the entry - point others should call. - - Hash a TYPE in the INPUT: FP is the eventual output, where the ctf_dedup +/* Hash a TYPE in the INPUT: FP is the eventual output, where the ctf_dedup state is stored. INPUT_NUM is the number of this input in the set of inputs. Record its hash in FP's cd_type_hashes once it is known. PARENTS is described in the comment above ctf_dedup. -- 2.27.0.247.g3dff7de930