From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6622 invoked by alias); 9 Oct 2013 15:46:06 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 6602 invoked by uid 89); 9 Oct 2013 15:46:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 15:46:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99Fk2sr008439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Oct 2013 11:46:02 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r99Fk0d1019493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 9 Oct 2013 11:46:01 -0400 From: Tom Tromey To: Jan Kratochvil Cc: Hans-Peter Nilsson , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: Build regression on 32-bit hosts [Re: [PATCH] fix PR symtab/15597] References: <1375983426-19308-1-git-send-email-tromey@redhat.com> <87pprfft9c.fsf@fleche.redhat.com> <8738obfd3q.fsf@fleche.redhat.com> <878uy2edtz.fsf@fleche.redhat.com> <20131009145403.GA8005@host2.jankratochvil.net> Date: Wed, 09 Oct 2013 15:46:00 -0000 In-Reply-To: <20131009145403.GA8005@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 9 Oct 2013 16:54:03 +0200") Message-ID: <87pprecurr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-10/txt/msg00115.txt.bz2 >>>>> "Jan" =3D=3D Jan Kratochvil writes: Jan> opncls.c: In function =E2=80=98get_alt_debug_link_info_shim=E2=80=99: Jan> opncls.c:1485:3: error: passing argument 2 of =E2=80=98bfd_get_alt_deb= ug_link_info=E2=80=99 from incompatible pointer type [-Werror] Jan> opncls.c:1211:1: note: expected =E2=80=98bfd_size_type *=E2=80=99 but = argument is of type =E2=80=98size_t *=E2=80=99 I see my BFD record still stands. Here's a follow-up. Tom 2013-10-09 Tom Tromey * opncls.c (get_alt_debug_link_info_shim): Update type of 'len'. Index: opncls.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/bfd/opncls.c,v retrieving revision 1.84 diff -u -r1.84 opncls.c --- opncls.c 9 Oct 2013 14:26:26 -0000 1.84 +++ opncls.c 9 Oct 2013 15:45:36 -0000 @@ -1480,7 +1480,7 @@ static char * get_alt_debug_link_info_shim (bfd * abfd, unsigned long *crc32_out) { - size_t len; + bfd_size_type len; bfd_byte *buildid =3D NULL; char *result =3D bfd_get_alt_debug_link_info (abfd, &len, &buildid); =20