From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0209C3842AC5 for ; Wed, 29 Jun 2022 11:19:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0209C3842AC5 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-HaKnWG0bPjGV4COh5dNl-g-1; Wed, 29 Jun 2022 07:19:33 -0400 X-MC-Unique: HaKnWG0bPjGV4COh5dNl-g-1 Received: by mail-wr1-f71.google.com with SMTP id r20-20020adfb1d4000000b0021b8507563eso2342720wra.16 for ; Wed, 29 Jun 2022 04:19:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=4iCrK0Vuf3uUgAbK97liW3WgOLyJ16jVYgtRSBSdu28=; b=vtIxfKjgxQuFkETn0E5DwoyDtNl57l/JwQfhNYJHqNGAFF9J/Sw6p6wdADc/g7dY0r j511/53AmbAjg9HetSh93xm0DwHtVIJuLqrcxmyeYN4mepfs+aitq5hcCspTumHzYzMY 4vXMVNyiPcWzAf+fEdWZyHRwajkq14IIeyOzdVgc9/6vetjRyzaT4JbVFw2b4JbgdQTi 3igGrX+MBw5i2URflPmRxOLRXk0nej4nLDfvDcsjRHcAuhVc/+LL51quJusxBpx+H3gD pmzoF0xPE/hE54xeBeLLavCuzjwQPOu9vLopqcnEBVTBjn5JVT7hFFmKill2mnC7RJsY bk5Q== X-Gm-Message-State: AJIora9gGsvA6JJbo6LlazmQHe2qxm+ZcWkU3Fei0DhQiic+lmcCZdCu gAy0fHljSR9RKBa1wDAld0ORBPNzZyzOt3r2aROn/yhB8La2GPoelTXWuooPIJaIUpTYHPzd8qE bSVCL0Flo0Nv/ayI/JA== X-Received: by 2002:a5d:4251:0:b0:21b:885b:2fcc with SMTP id s17-20020a5d4251000000b0021b885b2fccmr2666051wrr.52.1656501571694; Wed, 29 Jun 2022 04:19:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vn9szry7NH9jfINuyJDA7pcZKg7w9lXyeTfaFS7oyggATEad4SuDSaaPEcJgxmXHgNzkwtMg== X-Received: by 2002:a5d:4251:0:b0:21b:885b:2fcc with SMTP id s17-20020a5d4251000000b0021b885b2fccmr2666033wrr.52.1656501571448; Wed, 29 Jun 2022 04:19:31 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id t7-20020a05600001c700b002167efdd549sm16239284wrx.38.2022.06.29.04.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 04:19:31 -0700 (PDT) From: Andrew Burgess To: Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH 1/2] opcodes/aarch64: split off creation of comment text in disassembler In-Reply-To: <2f9eb769-46d4-2450-ac62-7767c4b31b21@redhat.com> References: <96fd8fa2c7f20081998cf1e4d9800f3e65f6d8d8.1655810414.git.aburgess@redhat.com> <2f9eb769-46d4-2450-ac62-7767c4b31b21@redhat.com> Date: Wed, 29 Jun 2022 12:19:29 +0100 Message-ID: <87r137d8e6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 11:19:40 -0000 Nick Clifton via Binutils writes: > Hi Andrew, > >> In this commit, I propose to extend aarch64_print_operand to take a >> second buffer. Any comments for the instruction are written into this >> extra buffer. The two callers of aarch64_print_operand are then >> updated to pass an extra buffer, and print any resulting comment. > > Patch approved - please apply. Thanks, I pushed this patch, but will leave part 2 to gather more feedback. Andrew