From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id DCC5E3858C36 for ; Tue, 30 Jan 2024 14:22:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCC5E3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCC5E3858C36 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706624558; cv=pass; b=erlRLsI/58OIFdNX8tQTb6hdTdSl1AcMMjvTeqKckl0atQlX3sCPuMhtciDps9YpCPVKHu7qlH7YRd5cyJJPL4Swo6ENaEtWsYtajgxe1FWQvbUMSuoBL/0G138zxH8i0iZevbTK8xKuYbftY7rWLEg+KbQJlUzqCGkusTpYIkI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706624558; c=relaxed/simple; bh=Q5hXrY5X/aO9tCDAoQ3Iup3NgLF/WH1ivd76KRg6Uvo=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=K+lqNTVC5FY8uclt30yYobqRmsKBBwsHeQech3cYTlIQVmNdIHh8EPsmugLmFYqZgxM7UB2zWzh/6JsgjYf/HD0Ys4mmnI43UYnIgZnriBoljMDweW9ZCKyQh6ZYMBOfBTAXNJJfa2q7fCmtZ7t/yQwgzhhaUFQnqjDMq3kguUc= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40UCA4Tc006895; Tue, 30 Jan 2024 14:22:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-11-20; bh=Gz+6gST8GMeVdA1VVyNu7F/MTx49kSsPrP141Q6xrYE=; b=XsfRB2ro3bbAr9tv10Gu5t96RLqzdVVVeSpWxp0BdZGTx4sQkdzL6vOHtD9fbOT/2XdL 63bBvIPpC56gl51a921y7Po3opgcKqzVloU8ZrOFRlz29jcbyuXFsFZO5SVTao+O54WD MmUqp+S53XYe1gDioX33T9reCmaxJzkatl+L/cAIjYiLePrQ7xYl+9VE36xOVG66ALd/ EvOg14dUfPXBqDqnX6BJEElvCvG/SN8xsSi0wBMA5435Qb48Q1GYTF8/kMa3Cu1JCNnf k4Qc/Tb9lXH+mSlN3d1ewwRY3myhafOXADzyuO9rECLMDCq5F98ObvuzbGgcSogyJraK IQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vvrm3xvsh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2024 14:22:29 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40UD5gVN014761; Tue, 30 Jan 2024 14:22:29 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vvr9df9fv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2024 14:22:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxHE0PmR1VgbDWHmB7Fq9PjgiliM1/Ne3K2Eyt2ZEP3+3AK1XmjLjf0KwONHaD3e7R+AsND6Uyh5WN6mXcjXhfRZuK/B3Alpg6UM01BppCealElhTVfJlq7ORJYljHDNWSUw1FQjzSGXMokJvUiGa9A8qd+XRWcN3FLV4hsg/t9U6NeTUWU3tQphJ9reRTJhyN0JBG4Rf0WJ83HuFhmIbLSl89Naj2Fe9Uvx9fbYHE0sWSU0csaMRJYnovbnYKaUSpvmfzaHji8AYrDgUvnX+aiI62//BxRtxi7y6Q5pdGo7ZWt4i4ksuI68NzmrNnsJIq3/G5lo5aOH6fOXAGzA9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gz+6gST8GMeVdA1VVyNu7F/MTx49kSsPrP141Q6xrYE=; b=nl6m02K1QY5FpRvI2CFVz8H8gzGH/vI5yw1XbxFQY25xsEzDWiUmj2e4EIXj9jqGnEjIClNLiiKXddXba6LlfI1cSt8zoEKAhaXUSDSwfTU+K0oa5SmwdGg59k1vYtYrn8tWJamC8PIEqB4NM8U06sxgp2oCRon2VEQD7+TBrX+5rPwW/nEYP/VJ0MIMhv3qFALsq+1MA/ZlV+ThRx7jDHTO1zlZnPwQY+G0m3sy0FNmCiog27mQfLAKE2gTXxmnzeGFBjVMBrJpJFiUuABjuG47i4zlX93CG5cO8EKzZOdNYPo7vyI/kpQ4vFYzAyjVufV2GkdKL+Vx/RkxijWHzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gz+6gST8GMeVdA1VVyNu7F/MTx49kSsPrP141Q6xrYE=; b=cg+el5W1LvH8LOJQovQPHdgg2fYoXOQEqM97W7jpwJMZReYxQchqfWhd2GXPKIwJHy1bgmn1GK3bX4uVXqVMXr0UVRE4cDcP8oNOlFYg8IiLY5laPQpsCoPenPTQcfATVPa/82M3/UMjNpBNzs7ZBI7mdr66pS5IJ0iqEmF41E4= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by MW5PR10MB5850.namprd10.prod.outlook.com (2603:10b6:303:190::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Tue, 30 Jan 2024 14:22:26 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::799:e107:1f58:8c4c]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::799:e107:1f58:8c4c%5]) with mapi id 15.20.7228.035; Tue, 30 Jan 2024 14:22:26 +0000 From: Nick Alcock To: Andreas Schwab Cc: binutils@sourceware.org, torbjorn.svensson@foss.st.com, yvan.roux@foss.st.com Subject: Re: [PATCH] libctf: check for problems with error returns References: <20231009151146.3818141-1-torbjorn.svensson@foss.st.com> <20231013140152.427376-1-nick.alcock@oracle.com> Emacs: don't cry -- it won't help. Date: Tue, 30 Jan 2024 14:22:22 +0000 In-Reply-To: (Andreas Schwab's message of "Tue, 30 Jan 2024 13:46:56 +0100") Message-ID: <87sf2evr35.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0159.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::27) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|MW5PR10MB5850:EE_ X-MS-Office365-Filtering-Correlation-Id: 078ddb2d-39d0-48fc-6923-08dc219ee20b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qVCgQhcEeARxmxPlHbOUEW6KRoA7TwtBlEWqxmf+EBmHbFj/KAdu0b9uNKWwWlalRUEU8ynEq/7k1AYQloF7XS5nxxeVUfGvXBtGWW5UXRmOx4M4IlapUTTYqQl4NWaJwPEJPnNyXX+xfsQdw2l/u7d4xWdWjC9wGXCZFqLDEgwq0XXuZyNIw284/WjOHkiHjSZlG59e3wlpCnmA7l0IuoYucbII+AlMzcEa2bAnn7KDWrdSBa8RAq/6weZDyjO+nkYjeuX9xn5QaaIqoPXs1lDBQVjth+3QaGvCq6vrvrHfj6vNFMz/zOv4fN5rhyxsqOB6vim8ChhBpznbO8RRIh1ziDSfaHy/SsOqbl2Pv15GmeObVTHx1xW7iCriUByzMHmDQFrftIISOJxTtYPyQMdBFuRjkAMAKp8sVxOrU2b5yzvc+Llm94KboBcNzNHHaMdcyRUy++SVk/YW0M+e3Q0qyU31I0Wns4EywSIuSaqKSRZWPisF7MHjlOP9ot15rZBNt5dl477JfkCjPU2ekmyr4WYh0qq/ajtuuHJAlqTZahzmadmkM3Fk87iWYAP7QDafsQkwh8qrWIki4P+wXMz/euc8dkEEF9KdsoRK7hjNV4OZn9AiPM8HTt0t1ihu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(396003)(136003)(376002)(39860400002)(230173577357003)(230273577357003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(41300700001)(478600001)(6666004)(86362001)(6512007)(6486002)(6916009)(53546011)(6506007)(9686003)(38100700002)(5660300002)(44832011)(2906002)(66946007)(8936002)(66476007)(66556008)(4326008)(8676002)(316002)(83380400001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y1iABTwqJM1WRLIXqvxHTIVRoZoYCeWP9lVKGfbrrcDkZXulBs2zbpZJ6OUt?= =?us-ascii?Q?RGCY/MvToMVcVwK95IkacafAYLPrEXsp+8PJxFrhN9oTSu/QpscqoUrxSAtb?= =?us-ascii?Q?fnakAv1ZsGi+PvElSvS0JKzPldF8QCD20/K8xFWtUVaIjsnDDCwv65jNIyUx?= =?us-ascii?Q?3PHMkgjfcDLNUcd8KO3zmHenC8mTEgJQ+kmz875L7Q0Eo0ujOxVnHHWEZLGP?= =?us-ascii?Q?/WjrCeb5gZrAoPqPxeRA1DufIC09yDyh2TvBJgI99Cqnbz/j/1EpXRH8kPXG?= =?us-ascii?Q?swQeUau3m30W0oP/30JwlkJLUV0lK2drUpoOIouMxHfRJplTlJvv2x9Fx40N?= =?us-ascii?Q?Wxl9VqkaztLjfM9kDj+8GY9Cq/aQfsCHmz97sJZAhOZQnTawj/bAEVqpeTnV?= =?us-ascii?Q?r8iApokIsR4+UL0qfxAThcXFOJhqCYxpIB4D2XwbdfAm9ga5jSnK8to8hlY/?= =?us-ascii?Q?zJ2JGkoGCfUkSG8K5JPTwmt+TRsdnBHnApsD43TYseZUVg4NEpQtdnXYzDoy?= =?us-ascii?Q?+aYhKgsnSF6X8iiK6pBy1m/RgS9bOdceUoOqG7x0bIPIxf/beyyfLLeKTEFD?= =?us-ascii?Q?6iHTgqSOpz0klFkFMXl3/LsF5CdDk4NosSjJcdP8KvkQFsv9G1H/z12s5Cxw?= =?us-ascii?Q?OdUj1Z9MS5iLZgEdXuZBzQYTHH3+XJJtbcOwGgPyYC/rxheo6zVYYB2Wwy/g?= =?us-ascii?Q?JwEsOZQg/LQEUheeoefQ9uC47ytXdlxxtvJb9RpHMBThrOVaVGnnlCgc4e3p?= =?us-ascii?Q?yUnvgO2vLUK8CZpsZsJAg4DSfv0csBk6pmP7v8jxjbDIt1uQx9iO2l7AWl0t?= =?us-ascii?Q?7YgPSGkx3teOwQiHgI1C57xXv3f1luWvIXXHPN5mMN7wbEPvkdsK1LGcfevj?= =?us-ascii?Q?eqkn1pGi27PEUkoCtGmsThgH6Bsr/b/QyfZowQ4HpEnKgCmFqdE5OcMiL2w/?= =?us-ascii?Q?PTyoFXJ2Rud718weId5ODLY3klBly/kNFluC3M8Mgy83Gt8xrqt1YVPRMpfa?= =?us-ascii?Q?18KwBdFCxmFqC/G5lmI9u7ESeBHzfp/fKqKO1V+BLDGBZtX3bqMhtYbMHl9d?= =?us-ascii?Q?AjG4hr5m682IYIimCKCMAVsgYCX4woMRYo9NgQ60CYQIiIrBRTDgnTRPPuJL?= =?us-ascii?Q?7r8tf334VxhJGx80MMfJLFjDDOU9zQ1wQ4aYeENOx8DyTqPVs6GcI+vlydFK?= =?us-ascii?Q?66YksPN+VElKTp+1CNtJ0ADYXU27VHCa4qAj2zMWInKWTuNmPnOM/R8A3y7+?= =?us-ascii?Q?DtPIMlnOM1cMUDY9KK2M1PPceqnc6GgfAwih1U3TSeFZIx4MB+OVnERbbirq?= =?us-ascii?Q?w1HB4G/Z9AJKyRfLJcuH/wFjHEM6vbiAldClv0Omc1F1FlYWnk++x8+fdhyr?= =?us-ascii?Q?N8tOqJ9/xK29gD3wO0MARY1YCmQRUxwWsNiryvtahgs1RlzTO3egqB8QQfPq?= =?us-ascii?Q?iKjUiXr04YsdKXwLme5Nz7wX+f7p/OorPCGhs/N7JCT13Bcdps7vUpW8Q7PJ?= =?us-ascii?Q?16QEP6cVYeGpdcjrDTl1DaJAUXx82delrotjG+UJ98jGXI/JxYo7ET4FsztP?= =?us-ascii?Q?m++hbmJ+uIopIMZaYA4m8R8S5WtgLH37UbHA6YZW471yqfcSrXXU2wIT4fWO?= =?us-ascii?Q?hg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /ATN/k6LLQh7lBoDnqzgOpJ3SMspZ/qob8h/v4fp1RfM2xmI8kKNnDYKnAwNU+8xk3dX0MJeJYRbelBaLlE6QCy6IGn2C2IakCpRRDcJJmzbet1o8T36yv4hyknFRgfue5YQk8Fl4Hw6yEaYf2ZBr7imSZ/RqAZSSecpP3Xu3p7CdkJv+/WxyluYM6vTzapRgfuXm1xeAZrrMBSHAVs16UIjOCEmFCcR0r9dtW8a11/VP87kHHinmOZrtordnZdl6yF0Tqpyi69pyVP8HuT9FxeeaD2B7LxLP2QemAr11ZoPBvkPJl9MewwBx3suFoqvM1DAlvYqqqCDstOw+ONtWhTuws3fF2nAaaMNjLRhh150/VlIE0aeE2gGYelR9+No0Kg3FSUkvfxwx8NVbpEAo9VTrCMMbcrHjOwK9fZixTyHkxeR/G+o52CoqSND4AHZK61FGUi5WFzq6FGzedY1S4vsSp1Kk5Ur9iKzy7ttpetPKvChgamtyNVw9jMg8a738IFB+r7TfzRdvpL/R1z+EbZJ4DT1cE94lNVVygb/uM1hNs+14iGiX8jKrCtLWGdGLzRS/8pAqBJlFJ8b6HgDb/+oM2O4RYH9kj+BPtHb8i8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 078ddb2d-39d0-48fc-6923-08dc219ee20b X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 14:22:26.3260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mqY4qYM4/iMiNxnqYoIAE1du4YJNpLGTpTx3nxUw2f6c97tG3fl8ZcyS8/HeBTgFT+g4j2rLoK2f9pSve6slzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5850 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-30_07,2024-01-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401300105 X-Proofpoint-GUID: ZzcXVoBcz0YVVrbHdQwIxGNJdjpFNtZy X-Proofpoint-ORIG-GUID: ZzcXVoBcz0YVVrbHdQwIxGNJdjpFNtZy X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30 Jan 2024, Andreas Schwab said: > ./libtool --quiet --tag=CC --mode=link gcc -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -Wno-error -I../../libctf/../include -I../../libctf -I. -I./../bfd /home/abuild/rpmbuild/BUILD/binutils-2.42/libctf/testsuite/libctf-writable/libctf-errors.c -o tmpdir/lookup libctf.la > /home/abuild/rpmbuild/BUILD/binutils-2.42/libctf/testsuite/libctf-writable/libctf-errors.c: In function 'main': > /home/abuild/rpmbuild/BUILD/binutils-2.42/libctf/testsuite/libctf-writable/libctf-errors.c:54:9: warning: 'stype' may be used uninitialized in this function [-Wmaybe-uninitialized] > while ((ret = ctf_member_next (fp, stype, &i, NULL, NULL, 0)) >= 0) { > ^ Thanks! I was being sloppy on error paths and the compiler has spotted my sin... will push the attached fix shortly, if your compiler is happy (none of my compilers spot this one). ------------- >8 ----------- >From 78fd0d4e60e8aed4c7396837d64cf1d1114b8c24 Mon Sep 17 00:00:00 2001 From: Nick Alcock Date: Tue, 30 Jan 2024 14:18:54 +0000 Subject: [PATCH] libctf: fix uninitialized variables in testsuite Just because a path is an error path doesn't mean the program terminates there if you don't ask it to. (And we don't want to -- but that means we need to initialize the variables that are missed if an error happens to *something*. Type ID 0 (unimplemented) will do: it'll induce further ECTF_BADID errors, but that's no bad thing.) --- libctf/testsuite/libctf-writable/libctf-errors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libctf/testsuite/libctf-writable/libctf-errors.c b/libctf/testsuite/libctf-writable/libctf-errors.c index 71f8268cfad..2790b608396 100644 --- a/libctf/testsuite/libctf-writable/libctf-errors.c +++ b/libctf/testsuite/libctf-writable/libctf-errors.c @@ -12,7 +12,7 @@ main (int argc, char *argv[]) ctf_dict_t *fp; ctf_next_t *i = NULL; size_t boom = 0; - ctf_id_t itype, stype; + ctf_id_t itype = 0, stype = 0; ctf_encoding_t encoding = {0}; ctf_membinfo_t mi; ssize_t ret; base-commit: b960445a45981873c5b1718824ea9d3b5749433a -- 2.43.0.272.gce700b77fd