public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: binutils@sourceware.org
Cc: Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH 4/4] libctf: get the offsets of fields of unnamed structs/unions right
Date: Sat, 08 Apr 2023 16:50:11 +0100	[thread overview]
Message-ID: <87sfdaidak.fsf@esperi.org.uk> (raw)
In-Reply-To: <87355dkzbu.fsf@esperi.org.uk> (Nick Alcock via Binutils's message of "Thu, 06 Apr 2023 12:46:45 +0100")

On 6 Apr 2023, Nick Alcock via Binutils spake thusly:

> On 27 Mar 2023, Alan Modra stated:
>> On Mon, Mar 27, 2023 at 11:27:40AM +0100, Nick Alcock wrote:
>>> Are they all 32-bit platforms? It looks like it.
>>
>> Yes, and built on x86_64-linux.  Which is why things go wrong.
>> "lookup" is compiled and running on x86_64, thus compiled in offsets
>> are for the 64-bit host.  The test objects are compiled by the
>> relevant target compiler, in this case all 32-bit.  Things would break
>> with a 32-bit host and 64-bit targets too of course.
>
> I have a fix under test that just turns this test off when
> cross-compiling.

Now pushed as commit 30a794e9f1db2de9099ed4c494d917d4e86de0fd.

-- 
NULL && (void)

      reply	other threads:[~2023-04-08 15:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 13:36 [PATCH 1/4] libctf: fix assertion failure with no system qsort_r Nick Alcock
2023-03-24 13:36 ` [PATCH 2/4] libctf: work around an uninitialized variable warning Nick Alcock
2023-03-24 13:36 ` [PATCH 3/4] libctf: fix a comment typo Nick Alcock
2023-03-24 13:36 ` [PATCH 4/4] libctf: get the offsets of fields of unnamed structs/unions right Nick Alcock
2023-03-25  6:07   ` Alan Modra
2023-03-27 10:27     ` Nick Alcock
2023-03-27 11:22       ` Alan Modra
2023-03-27 12:38         ` Nick Alcock
2023-04-06 11:46         ` Nick Alcock
2023-04-08 15:50           ` Nick Alcock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfdaidak.fsf@esperi.org.uk \
    --to=nick.alcock@oracle.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).