From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5F19E3858401 for ; Wed, 10 Aug 2022 16:12:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F19E3858401 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-t5jWPEvXN9WdP3-z2DXIDA-1; Wed, 10 Aug 2022 12:12:51 -0400 X-MC-Unique: t5jWPEvXN9WdP3-z2DXIDA-1 Received: by mail-wm1-f70.google.com with SMTP id az42-20020a05600c602a00b003a552086ba9so1286014wmb.6 for ; Wed, 10 Aug 2022 09:12:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc; bh=41GPV2pKDBwn697RYGHXrIvOubwlbrzOUfIxiwNIRlo=; b=uwMY57DrP2H9SKHTcgmPhWLIiCN/qCMWfmWZvPhJNCuP6FTxqzEqZ/J8ROq7UlJnSw EpzRfsLMw7simmJ9/A/YDNIQOwxRRBd/aOeloPQhXPstEFsEnbAE9rwySfGVixfdVK7m QlziqHc6do5FPgbgRhSnFRHp3h+7uHWjKtsdqVz7uNG+qWt4dbehs0L+3edd5edvAZC4 roIEQLjW/vC/y6SYKoSjwtSZGcPMUG1jNYh4pQxo19AlE8NOcIC87xOC42LRsdMyT0PL +k43b9U9Zcn6YyOO8EKp+F4BczY+hSwzXFvDP+s2JVAqLjONlAS/HdndBvE7uRWz8Fch yC8A== X-Gm-Message-State: ACgBeo0/F+rouoT4jb7orjczndlLkDyebNCLT8/L63JktoFM5ZspsE6S d0qNemNPce6vRTYvcA0EHX5ABXFoLCK0mw94cn6/M/7+iI3m0SVdKAAQZF7uQYSHJcV/jDxjYyp DytIPLVdvwUkTD7Nm5w== X-Received: by 2002:a5d:4345:0:b0:21a:3b82:ad57 with SMTP id u5-20020a5d4345000000b0021a3b82ad57mr18002996wrr.176.1660147969821; Wed, 10 Aug 2022 09:12:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR5T544ANIreD8k14EgI5FWXuEvt80ykew4k4H6Cgs16NrQttfpkNVs0H92Fu/TtQETamkRF2Q== X-Received: by 2002:a5d:4345:0:b0:21a:3b82:ad57 with SMTP id u5-20020a5d4345000000b0021a3b82ad57mr18002990wrr.176.1660147969666; Wed, 10 Aug 2022 09:12:49 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id a3-20020adfe5c3000000b0021edb2d07bbsm16124524wrn.33.2022.08.10.09.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 09:12:49 -0700 (PDT) From: Andrew Burgess To: Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH 1/3] objdump: fix extended (256) disassembler colors In-Reply-To: References: <091335e069804270ba8d9e217285c70743100603.1660139020.git.aburgess@redhat.com> Date: Wed, 10 Aug 2022 17:12:48 +0100 Message-ID: <87sfm4yt4v.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 16:12:54 -0000 Nick Clifton via Binutils writes: > Hi Andrew, > >> PR 29457 >> * objdump (objdump_styled_sprintf): Check disassembler_color >> against an enum value, don't treat it as a bool. > > Doh - sorry for missing this. Patch approved - please apply. I've pushed this patch. I'll rework #2 and #3 inline with your feedback and repost. Thanks, Andrew