From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 785BD3857C41 for ; Wed, 16 Mar 2022 11:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 785BD3857C41 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22GBBSaD018886; Wed, 16 Mar 2022 11:30:58 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3et60rnund-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Mar 2022 11:30:58 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22GBG2Ix118829; Wed, 16 Mar 2022 11:30:57 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by aserp3020.oracle.com with ESMTP id 3et64kkv3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Mar 2022 11:30:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ocl28FB/Fzl5Y9erWgs9BRZ5l0nEBn38TTUxuFa7U81sPV4FYQWSJWpSz6HSKttFD2DBcsYHwDUnZftWcCo6/H9Wxwig0npTiM3Yk3v3shhJylr4MvAMt9SCMuUmMx0HQ6H2ERNddsxhRtv5EF77lwuLVcjumfG+FenVv+AXUSgogK5Bi+liANaCitzYSZ6HjZz8YIw8A9XP6TEFhYcQoyB25HaulPMwQ1nbR3SexYSV/L94s2zX3j/9FXSQpUNH0DqskSVpUVLJ3ICIv1ZJhfo5GB5yIdQWmDks2jcePkxZiuHRPvfp6sZ4b84AwXiAOEnWHQLD04fFxGlU3nzWfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fKmd+C54+WPaAlxpzMqV4Xd5csEt45t6wLkYtpKro0w=; b=DDLmGOLvAt9ywmPjUHJYWxLPLxtObGzAVbC5+GlEVUtf7FUkVQehZeoniI1/3h/BMNfrxvZNupO+HVh+oLUg1pDjLXtzwwSBmntvSz9Qp4gD5/R0Da336fviqEmgR0TNXhAcJp6G6Le3mhOs+MXLC3ChHwzJW6eeItoqhevs9TmOVHJzaHQjqgH+6OWRaVp4OoVwVlgLy0P6QIxvxZStAI7E5Fsvd9P20KB0igL5XzlCwdzGIfiDDf+w6LLFu+98JiQqkZskJp44RhEJDVkgYHCa0MoTJ6AmUmDpBSuT7BSZv1Wp1NSlVPzUeILF58NCTM/u6gmwPGw3DXdgWxzEcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4715.namprd10.prod.outlook.com (2603:10b6:806:fb::10) by PH0PR10MB4583.namprd10.prod.outlook.com (2603:10b6:510:43::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.24; Wed, 16 Mar 2022 11:30:55 +0000 Received: from SA2PR10MB4715.namprd10.prod.outlook.com ([fe80::a1ca:a394:7333:2aca]) by SA2PR10MB4715.namprd10.prod.outlook.com ([fe80::a1ca:a394:7333:2aca%4]) with mapi id 15.20.5061.028; Wed, 16 Mar 2022 11:30:55 +0000 From: Nick Alcock To: Joseph Myers Cc: Tobias Burnus , Binutils Subject: Re: Build issues due to patch "gprofng: a new GNU profiler" =?utf-8?Q?=E2=80=93?= CLOCK_MONOTONIC_RAW not defined References: Emacs: where editing text is like playing Paganini on a glass harmonica. Date: Wed, 16 Mar 2022 11:30:48 +0000 In-Reply-To: (Joseph Myers's message of "Mon, 14 Mar 2022 20:53:36 +0000") Message-ID: <87sfrijfrr.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::27) To SA2PR10MB4715.namprd10.prod.outlook.com (2603:10b6:806:fb::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60d5681c-a1b0-4c9b-5e6f-08da07406f5e X-MS-TrafficTypeDiagnostic: PH0PR10MB4583:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8LnEct+11r+inl6xMeVU8t7stJ37YwkemwScs1eo1IXj1Z4O9M/YDkcSis92P0rMtwBvgL4cRdLcrGrZBSdYaAhVCXhaNVjUY+PAj8QQlNENu6Z7y+2H2k7GqJpoMYo6vl2V2t+374pyiyHsT0psPcTlmyx7yare1WVjFc7Hk5SgNnFOY/ak9wjLTx6PrC7cqpQAcudvmOPryP7R0272g57stEmHzUX8r4whEvb8jZOBEid17EQTFZi78cFY1ShqKcGsQIXFjzFln7DLMokNluN45YPxLjzRqIQzL1JBW/AmXmO6ZsVJF/2lWPNkxe5s8ixjjA+XY+05/76x370DBH/YBN7ul7SDht83BR8MGe1wHqPPE/9ejEwsD2MCbUKCltWoJkF54qjG/hFVUyuKo6etSfcoQGx9C1Szu/XMvp7N2d6SJp4fFuLGMAmGStwmOgxKo8iUdPEqyEoEViKAkKlrcTlQ2yxjZ6dnRyKWoALY+1ISLTyQc8ne5ogerqLrSnXcq3dc0XNkaXafJTMo41dgWySncFaCOH41ICDf2+TFxBKOSZQcxNwvB51z05xedsDp5ED0/NUWO0i9L0izaTCstyZzzzQqZtQoJhmghUsIVBWa1RmKMfy+0mvuzZBcwOKIvJmu8vf3RuMhtS7qeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4715.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(86362001)(66946007)(66556008)(66476007)(2906002)(508600001)(9686003)(6666004)(6512007)(6916009)(54906003)(316002)(6506007)(6486002)(52116002)(186003)(38100700002)(44832011)(8936002)(5660300002)(83380400001)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7WF701OATJ3FFO2lqcUNJ3b+8s15RCStDdiAC3c3xVRhyRXfh9qIRsPTLv+6?= =?us-ascii?Q?fhlxrEvM3QBCZldbO25rT2HHdFRPmaWLreZlOwOhz2PGrE/Buy+x7rzxQAXs?= =?us-ascii?Q?vGdSxwAmEQcz0bTUI1tOAA8PNUass8CT3mzoTuD4x6qb1y4MyZ4qT/ZLqJDi?= =?us-ascii?Q?2HrgQsISHmTl+M/Jnfsp0v7e4RMyRG7XhRMLx+1fT4PjmtqlbDa5+1DZGbEe?= =?us-ascii?Q?9R0oMwDs7yp6729K0966q0npQTGJXH61MbAeLG8tkhfFFjfRao83MLTwKluc?= =?us-ascii?Q?o0IHsKVEJYTrKCyLHbLIWdT6HjB9Q7kN2XMMLw8kbKaVhFECmhBZkscSF8vp?= =?us-ascii?Q?P1ybo2oeaX1NlEaDCOFycPLAaS0KDzVGU9k78gCJfgl0MPiBdnJU33z2zJgb?= =?us-ascii?Q?YLPvphAZkIWqbMrZ00DDoaV7Nly9xr2EUHSc1ikcV8N5HcqDgsqgGJEB8DEp?= =?us-ascii?Q?QqJjJPHo6a+qHDhvBMSD24Ouh/EQTDMC6owishaMy/oMUvfvhNkE2OEFmMGy?= =?us-ascii?Q?9XqY75ZlAWAhlhRzrEG4XbuTe1rw/AUvCRUA4JfmpiD374+nncrzV9X7jmai?= =?us-ascii?Q?0f0hWUssMNRRTmfM9PDOv2upynjDXBVOvLbP091yopJ1z5hfLNAJlpsZ1n3t?= =?us-ascii?Q?hX4lqbOu4CPoRz0fTk03J2PMYOvKCODPMTgzWIiLTTiAbWZTTnU0+ykgbNIT?= =?us-ascii?Q?rGromJkEoR3HF3PD7v7ZZ64JsmA2N8LWmdnp4dQjSkukgP/cAty5Byy0Wm7s?= =?us-ascii?Q?G71LjQANV/zTC811M/CWsN6JAG6KlUthHReCBnIf2KvtKhyOhFQkTl8yYhoR?= =?us-ascii?Q?o1tJ9w3Mc5WbccLB6sIK5yYbRLCB9Ew4yQgn9YgwZWcDSRCy+0Rz2PFbHNjN?= =?us-ascii?Q?9A0g5crtEtz2jTNnEuylA4GFbnCz8hSIa0DP8V7GbBpzIs9DEhNI9O8iTHQ7?= =?us-ascii?Q?jJWasI/hr1islcG7f0SJPvS5mNqgJBmsPUyiyfbohKJ8VEp+PUia2G7bTGBK?= =?us-ascii?Q?k9uIaGmbAL+XON/CxHLuAYBovkeyddUjjulCChPSRqlMvmRzeji7WaCncxjU?= =?us-ascii?Q?Lun9cP4c0m12s4NMIq0A7zoBG53fn8mtDXhir4rBjLys02f3wUrrdz37OgeO?= =?us-ascii?Q?zdVS7ZGiWz7O/B1cfWJX1mz2m8B3M5yWBBWYA7NGOuuvSjIpNunoJKbpO9Jn?= =?us-ascii?Q?32i3KjB/wZS291b6HOLQJCs6M64e9nTCe3N3ojLsoTNWDaxw4GPtJSmSok84?= =?us-ascii?Q?49pieQu7QLW7FRIwPSuQV2nuNqY8ABb5T4PTFGupKvbrJAuRLWKvj1p33rO1?= =?us-ascii?Q?dZiM2rZkMsGwbUjUz27HHvxP8YUwnra7/BKqLal/Cf/kZ0nMwDvD4JDUmtqm?= =?us-ascii?Q?s3AgKNNQroD/CCnKKUjM/11lssv/nmf7WSMFVlzcV7wxYADrENJCNeLXlOoE?= =?us-ascii?Q?BdVxDA13N7AL9CAEL4vpgsscL5iSoJgVNCgyEl7Ti3nzkffrS6n4Qw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60d5681c-a1b0-4c9b-5e6f-08da07406f5e X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4715.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 11:30:55.6446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9T3fbKr7uhejMuo52ZKrNpgitfvzPSRDxQunwAPS8i8Fdq2hNP81hP+inlqTeM2LrEcvctCkS/tCjOI0rSgwHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4583 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10287 signatures=693139 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203160070 X-Proofpoint-ORIG-GUID: 2Ny-GjT2S5A3mapkFvcp_wI3IBfJIeI9 X-Proofpoint-GUID: 2Ny-GjT2S5A3mapkFvcp_wI3IBfJIeI9 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 11:31:03 -0000 On 14 Mar 2022, Joseph Myers outgrape: > (I might ask incidentally why the Bison output files QLParser.tab.cc and > QLParser.tab.hh are checked in - normally binutils doesn't commit Bison > output files to the repository on master, although it makes sure to > include them in release tarballs. If there's a Bison version dependency > issue, then arrange not to build gprofng when the installed Bison is too > old.) There is. Since we have a reentrant parser, we need either gross hand-hacking of the generated parser to move everything into a class (which is what the code *used* to do, and is a non-starter in my eyes), or at least Bison 3.3 (for api.parser.class): it is quite possible that some dependency on a later Bison has crept in, but that's not *fundamental* to the parser the way the api.parser.class dependency is. The right approach seems to me to be to check the generated parser into the disted release tarball, and then to configure gprofng only if Bison is sufficiently recent or if the generated parser is already present (i.e. this is a release tarball). In any case the generated parser would disappear from version control and dbe/Makefile.am would gain rules to regenerate it (and also at dist time for the tarball). I think the default Automake rules already do this, as do the gnulib rules we would probably have to use instead due to the Automake rules forcing bison -y. At any rate this does not look impossible, or even that hard, certainly not compared to rewriting the parser or something. And there's certainly no justification for bumping the treewide bison version (if there even is one: I thought there was, but now I look for it I can't find it). The only people who will need to upgrade bison for this are people building gprofng from git checkouts and who want its building to not be skipped, who are presumably either developing gprofng (in which case upgrading bison is no trouble), or are distributors working in recent distro leading edges (in which case they are almost certainly both used to upgrading bison and are using a newer version already). It looks like the skip-configure-if-unsuitable stuff is hardwired into the top-level configure.ac, but it also looks like it can use basically any reason to suppress building of single directories, so checking for new-bison-or-gprofng/dbe/QLParser.cc-exists seems at least technically doable. Does this all seem sane to everyone else? -- NULL && (void)