From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id C2CD33858D37 for ; Thu, 3 Feb 2022 12:16:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C2CD33858D37 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2139k3LZ010115; Thu, 3 Feb 2022 12:16:23 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3dxj9wgwfu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Feb 2022 12:16:23 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 213CBFEl043497; Thu, 3 Feb 2022 12:16:22 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by aserp3020.oracle.com with ESMTP id 3dvwda5s5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Feb 2022 12:16:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+tslljGssxBEH9HocaaU4OCPdE+GL1AJMEvDB6j62QVdHhz1lsTFQ28mQcQZl57dkKZ5LjjFet+hXByKTFf/RnbftkAxzPRG2BA3F4EcuoFVyaahHS86cySV/v+hyeQFwYssn26U3ss6+YHVzyvAqfRq0CBRazrmulvgDZfglALfUVPKB4cYHOE2LO9TDRGPEri5Y8nJqx5uGyEGjUnyaXdGuQ+Hc7LKqipAcKsLJJcCxSEXmaeEam1HBOzBlR6M+GuNwzcLNQq01pj6lbUCiqN0WJALyvOTSdG2NRuQZDIp7FHxJvhmPLV9jkdov7XWUQtdtFEVncX8IwNd2a1Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Atl9lZOz/7CWWugZ8wO6JOvsXK8uXvuRoKJvdWx3p+M=; b=L7P+sUGVs7qAjO8NB1caQyy2709Fv5J4yr1Bdyub1YXOaUTj1eLQ8B8ZDdR5KYUJOxiPIx0T8xb2v/Swj+wIWRcpHuOY/cKnty9V/Ub4laeWuRprR2lexeKtcgvPHgsQcwjYwgjQSlJAHmuaehWsstOd6oALh/8yzweNL4uI5zBgu9ISO1Y/DlBiKhXETWWIiDpLq6beGR1gAnPfp+r7yJKouoBPBeAVw2LOtfW/fbvJAjdwDuMlwEF7x7t2MlACC3/8QtAs6imDuWj1pZD64W/f3+Zzogz1OUjPI9TUrv2VonEgC0SAk9zUM+4F8UDYNh1mgklKgX8PWoy/6/cryQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BN6PR1001MB2114.namprd10.prod.outlook.com (2603:10b6:405:2d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Thu, 3 Feb 2022 12:16:20 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::7946:cba4:bc10:70a6]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::7946:cba4:bc10:70a6%4]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 12:16:20 +0000 From: "Jose E. Marchesi" To: "Maciej W. Rozycki" Cc: Vladimir Mezentsev , Vladimir Mezentsev via Binutils Subject: Re: [PATCH V4] gprofng: a new GNU profiler References: <7dadb881-ab4b-de4a-0453-6d8661a8cd83@oracle.com> <44e0ca3c-0792-7fc2-bff4-0918f1f4bea2@redhat.com> <653282db-9261-e5fc-4280-0d00be272d81@oracle.com> <53d65dfe-38b4-7a2c-2052-b3c039642392@redhat.com> <3d87cce5-1ac6-ca35-0baa-576d599acdc7@redhat.com> <1c976060-3d2f-1050-f948-9448acb33c71@oracle.com> <87fsp9jli4.fsf@oracle.com> <877dadw7r7.fsf@oracle.com> <1397fd59-7142-fc73-80f0-9893f7b07f33@oracle.com> Date: Thu, 03 Feb 2022 13:16:13 +0100 In-Reply-To: (Maciej W. Rozycki's message of "Thu, 3 Feb 2022 11:02:12 +0000 (GMT)") Message-ID: <87sft06t82.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LNXP265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::36) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f19bc723-7575-4056-1060-08d9e70efc2a X-MS-TrafficTypeDiagnostic: BN6PR1001MB2114:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hkFtRX/jTerp9TpZNYGZcyu7SYNiyDooKiXO9meh3Trc/d9yTc3Eo38nAej7IkLGEFFXKw4qZhdOPLxjK0ASOyRKc4DFCIxDerWJlGV0r7Q1+b4cu9JZJuEY9IOV3QATcJgjnxDOAwM/aOjtvqJAE1ZlTOQ1dfDpCauiyzeC5DfghLdpeeSioEJkduD5xjSXKZQ+Iydt6MyGiDCREN4XOhJIgLPf9HZkZbKCoN2vQ+hAJWxMbBhn+LR05P7bDKG37L1KO7H/xITt6svOSv2gGQg+lgsVnSqh8k14yr4imqqNEnL5pd4agUNBJiGYs93nZCjLXmeTsVUNTCWuNl3GPhqsm8vfwJgnib8rUyN5eN23EL+R8ra97bzdoiCCLqmdtY2rEt5S9p5/KL48R26yXUL/sJGO70R7H8Fw67L1E0EDugALkXxqoAafyGi0r31pl7l1GootkJvvUs1W9edUY/vflcbw+ag4Stelu4GIQU8iPDCPpl1lXxGEFwC3UrgLYkw9kjnZ2jXx4Wsp8a6Jlk58Khg+WGpTQ1I4oGP1/M5UyAcxjarrz9qt0iHM9R1WsVDNwC7EsPPh1gv2WrV8G0y+3FBfxf6gVOYo+p75dlIzt637T5uhUqQIQYeJ20WqcAtTiFCx5MnCzB3NyBIVbsEgkrE8Ll6Y0GEoQlGYi7vjxKLn1WSINeOYPCbUoFRkcFaAhE9ruRjuacZFtett1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(6486002)(38350700002)(38100700002)(508600001)(5660300002)(86362001)(2906002)(6666004)(83380400001)(36756003)(2616005)(66476007)(66946007)(6506007)(4326008)(66556008)(26005)(316002)(8676002)(186003)(8936002)(6512007)(6916009)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmVlSTMyR1NWdmw1T0VBNlBuYjAwaGhvS3U2NVpLdElCdWk5bkVhOE5oL1kz?= =?utf-8?B?YUl3QktRdTg3S29Gejc5YXVMSm13VUJvS3Ayd2xacWhYNzlUcGFYQzNzS1VC?= =?utf-8?B?cWRXSDFZSWZSUU9tZUhaanc0cEd2ajNEMFpkM1NFdUZDeUxtb1AxbW03dkl1?= =?utf-8?B?clRYMXNCRmlYbVNaSG5vcTVsNVJxRldhUnJoWGFVVzJ4OUkzb090bEVSQlQz?= =?utf-8?B?UlhSNzBaMkJjbUNFdy90UmovcG9lbmt0eG1pemsxWmszaUVMYndvSWVLd2xO?= =?utf-8?B?MnBNZkJCMWdIam9xSTlpUEpmNElaNjdFMDJmYVJNODc1dWlJSXpLVXN5cG82?= =?utf-8?B?a1hrMkZEYTBqMUkvUlpYUElWdHVQZzZqSHZvZmVGZnNyOHpIZDZDaW5JRHUv?= =?utf-8?B?TnAyRHZQWGZxVEtQam9ZVDFtZ3BJWXpWN0R0VEx4MFlNd3pDUjZEUmpLWDVK?= =?utf-8?B?UCs1UEJMdmc4SU04cStnd0xHVVpyMk5SQWlCeU9lNUY5bVd3aUhVSWYrWFVy?= =?utf-8?B?bVg3NFlWMjU1S2VkaVJmbHNqS1E3Z0VWTXVSZFR1SzBmRzZ5MktKeHpSbktN?= =?utf-8?B?LzZ6ZUdVWjVxejhMQ0JVN3F6RmxXbjU2STdXWm03YTVaVTZsb3FRWkF6L3ZC?= =?utf-8?B?a2c0U1RWWUlRUkRMVDV6Y3N1TFFCZWg3YTloYVk4Q2tWUGFQclNsSm9BVWt4?= =?utf-8?B?SktJdzZZb2xSWTB1eUhvWmowRlZZbk16NXVOZ3ZRWnlNTG05SDhPVFVzbjdJ?= =?utf-8?B?SGs3T3REa0ZTdERXTWZnelB0WlB3MDdHUXBZS2FMUDBCTjhOZWZzMWdHYTM2?= =?utf-8?B?bVlpUmt1dmhzV3NvYmxCRHF2eGxWcHBVWklScDcwMkZuWlJSMGxPMWUwZnU2?= =?utf-8?B?ZnBBTUl2Zjd4a3dNMjhmcFpZWDFZckJnd3RYeUQzbllLWGlqa0ZxeVowVm0x?= =?utf-8?B?RDE5dkxVRWYwOGhtZDNrTStST3QvSW5udVdTS3gwbTBhbStCOEd2OHBBMlQz?= =?utf-8?B?citTWFd6OERIUTkzcXRsUmR2anQwTVdPb2RacVdVckJ3M1NSUmZZa3NnOS9B?= =?utf-8?B?eVJxRzREdXhlaFJ0ODBZUzR4SWluZTU2NC9NVFZxNUhkU2kzL2o2UCtFRjFS?= =?utf-8?B?S2NhRXJsYlBPbWRBeHh5VzFXYkhDdGJTWm9LcHVTblN0WkZuK3lqWWVycDRV?= =?utf-8?B?bFZydUFqaGlNb1d2d3huTCt5SFVKeHdxREJ4cWJTSDduRjFRZlIrYkNDNE1Q?= =?utf-8?B?dWd3TW9ENytYViszOG5XV1NtZW1yUDEydWlXNXFWeDJORGJwbHlhM01LNVhl?= =?utf-8?B?bnA3NWJjZjZoWFZnY1E2NVVFVmJ5Qk0raHlPV01yQWdtMllMenJGUlNNRlkv?= =?utf-8?B?azcxMjlWRDJrdi9zbkM1U0FFeTk0NHdOZUxtakhCOUhDVHVlZ3FZdU1kQ2o0?= =?utf-8?B?QVYzamJNL1RhQncvMnlLZTNtV3cyU0Rla1hhMnlOSmIrcE1lNFJzRkU4azlH?= =?utf-8?B?QmVicXdLbk5wczJoamhrWFRjalI1QzB5UUp1MzFwdGF3Y3hna0hMeDdZamd2?= =?utf-8?B?WjFJN2kvLzRTVmMrNDl1NjE2RFFXaSszQjVIN1JGOHdmTCt5c1ZYWFp4Y1di?= =?utf-8?B?Ni9OUHIzRFZCNGNsaUErbGdXVTBLL2FlQ08vY3JFUm8wWkZ6RnVjc2Vyb04y?= =?utf-8?B?akoxczBSTkJMRS90eklVQVRHZ1RxTFhuVjBsbVRRRG5JVW9sM0pDNjcwaUg0?= =?utf-8?B?TjRVZmY3b2ppY2ViQk1WbzJMUk1DZUpuVWtHdlNrZk9jYXExT25ua0syMFNv?= =?utf-8?B?aXpuV0hhWklVU0VSNis2TVNvQ1BzSWpBRXQ0bXJYWkRrQmVUK2RXeTVHb2ZW?= =?utf-8?B?UXpjOGFFNG5VZXpVLzlrQm1oSXVaRTBwOUVTdTBoM3NnUStPNDFpYVZxbjRt?= =?utf-8?B?WnRTSUhuZ29HN2ZNZmNTRjg1TkdTa0FvY241cS82Q1k2SnRYSE1OdEV3bHdO?= =?utf-8?B?RGhyNGphcjFRdzdaZ1YvclVSSEtXNmVhNDBYMzJXaUVVTHk2YVRQMnVSVEJ5?= =?utf-8?B?WHBIdkM4cWFtZURXcXRsZHdsYlA4dVh3V2I3SmJDU2hCMlh6cmdOZzNUK2tt?= =?utf-8?B?eWlpU1l1V2VLZ0RkMWt6elh6akJ0am8wM3pzZGxBOStLOVo1bGpZbmh3a2Na?= =?utf-8?B?VzVHdzQ5dkxpMU1ZYkgwK2EwS200V2dwbUdHTlhISDFuZ2xDcENwb2s4Kzk3?= =?utf-8?B?ak9weW1yWjBlS0lHVGVEWFpnZ1dRPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f19bc723-7575-4056-1060-08d9e70efc2a X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 12:16:19.9402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wk5an4+Kb0mQMDCduvobD82tjGMYhKjIz3ziVsyJHUyTD58EKXqSUl2c6kQGXcVP8Ih0Zse+YbJGy+1z7yeiE9B4g6XDlluCYSL6t4wIOuo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2114 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10246 signatures=673430 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=984 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202030077 X-Proofpoint-ORIG-GUID: tbnBTNIwUY9xxttBJzSdSE7FT9vMIwqJ X-Proofpoint-GUID: tbnBTNIwUY9xxttBJzSdSE7FT9vMIwqJ X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2022 12:16:27 -0000 > On Wed, 2 Feb 2022, Vladimir Mezentsev wrote: > >> > > > Woudn't it be better to skip building gprofng in case no --enable-= shared >> > > > is specified at `configure' time? >> > > Is it actually necessary to require `--enable-shared' in the first= place >> > > for the program to work? >> > I think so. AFAIK the gprofng collector works as an interposed shared >> > object. >>=20 >> yes. >> We use the gprofng library in LD_PRELOAD. This library should be a share= d >> library. >>=20 >>=20 >> I am trying to set=C2=A0 extra_configure_flags=3D'--enable-shared' for g= profng build >> only. >> But gprofng depens on libopcodes and this library should build with -fPI= C. >> I haven't yet found how to solve this build issue. > > Forcing `--enable-shared' in gprofng/ unconditionally could be confusing= =20 > to the user who might want to avoid shared libraries for a reason. > > I think perhaps the best solution would be using AC_ENABLE_SHARED in=20 > gprofng/ or the equivalent LT_INIT option (I think it's the default=20 > anyway) and bail out with a suitable message such as: > > "Building in gprofng is unsupported with shared libraries disabled. > Please reconfigure with `--enable-shared=3Dgprofng' or `--disable-gprofng= '." > > or suchlike. I think this warning could be implemented in the top-level configure.ac, setting `notsupp' for gprofng if `enable_shared' is "no". Then, if the user builds binutils without --enable-shared, or in a host or target for which gprofng is not supported, you get the familiar message: *** This configuration is not supported in the following subdirectories: gprofng (Any other directories should still work fine.) > Then in libopcodes/ you probably want the `pic-only' option to LT_INIT=20 > (or use `--with-pic') unless `--enable-shared' has been also used for the= =20 > library, though I think it would best be conditionalised on gprofng havin= g=20 > been enabled if possible as there's a performance hit from using PIC code= . =20 > As there's a `--without-pic' option too the user can give this all may=20 > have to be coordinated at the top level rather than within gprofng/. > > Perhaps the way how `extra_host_libiberty_configure_flags' are handled=20 > could serve as an example (though I think it should also use `--with-pic'= =20 > rather than `--enable-shared' unless `--enable-shared' has been explicitl= y=20 > given already). > > I realise what I have outlined is not a complete solution, but I hope it= =20 > can help regardless. > > Maciej