public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Nick Clifton <nickc@redhat.com>
Cc: <binutils@sourceware.org>
Subject: Re: [AArch64] Add SVE condition codes
Date: Thu, 25 Aug 2016 12:18:00 -0000	[thread overview]
Message-ID: <87shtt6nyw.fsf@e105548-lin.cambridge.arm.com> (raw)
In-Reply-To: <f0f33ec2-a6ed-fc8a-33ef-f3075c2d0ee7@redhat.com> (Nick Clifton's	message of "Thu, 25 Aug 2016 12:39:29 +0100")

Nick Clifton <nickc@redhat.com> writes:
> Hi Richard,
>
>> SVE defines new names for existing NZCV conditions, to reflect the
>> result of instructions like PTEST.  This patch adds support for these
>> names.
>  
> This patch fails to build for me because:
>
>   opcodes/aarch64-opc.c: In function 'aarch64_print_operand':
>   opcodes/aarch64-opc.c:2617:19: error: implicit declaration of function
> ARRAY_SIZE' [-Werror=implicit-function-declaration]
>
> Adding #include "libiberty.h" at the start of aarch64-opc.c fixes the 
> problem, but it makes me wonder - how did you build the patched sources
> without this include ?  Did I miss something ?

Ah, sorry, I only tested the patch on top of the main SVE series.
The include then comes from patch 23/32.

I did wonder whether this should have been part of the main series.
In the end it seemed better to split it out since it would affect
non-SVE users of the disassembler.

Thanks,
Richard

  reply	other threads:[~2016-08-25 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  9:33 Richard Sandiford
2016-08-25 11:39 ` Nick Clifton
2016-08-25 12:18   ` Richard Sandiford [this message]
2016-08-25 12:22     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shtt6nyw.fsf@e105548-lin.cambridge.arm.com \
    --to=richard.sandiford@arm.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).