From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Catherine Moore <clm@codesourcery.com>, binutils@sourceware.org
Subject: Re: [PATCH 13/20] MIPS/GAS: Improve instruction's mnemonic processing
Date: Sat, 11 Dec 2010 10:36:00 -0000 [thread overview]
Message-ID: <87sjy4y4sk.fsf@firetop.home> (raw)
In-Reply-To: <alpine.DEB.1.10.1012101704150.5345@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Fri, 10 Dec 2010 18:48:39 +0000 (GMT)")
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> 2010-12-10 Maciej W. Rozycki <macro@codesourcery.com>
>
> * config/tc-mips.c (mips_ip): Make a copy of the instruction's
> mnemonic and use it for further processing.
OK as part of the microMIPS patch.
(In case you're wondering why not just "OK": there's nothing wrong with
temporarily replacing whitespace with nulls, so without the microMIPS
changes, that's what we'd do here. The thing I objected to with the
microMIPS patch was editing the mnemonic in-place, by removing characters.
That's what you're fixing with the combination of this patch and the
updated microMIPS one, so the two patches are OK together.)
Richard
next prev parent reply other threads:[~2010-12-11 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 19:21 Maciej W. Rozycki
2010-12-07 11:05 ` Richard Sandiford
2010-12-10 18:48 ` Maciej W. Rozycki
2010-12-11 10:36 ` Richard Sandiford [this message]
2010-12-11 12:53 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjy4y4sk.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
--cc=clm@codesourcery.com \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).