From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-38250-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 31359 invoked by alias); 24 Feb 2005 21:05:29 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 31314 invoked from network); 24 Feb 2005 21:05:25 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 24 Feb 2005 21:05:25 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1OL5OqG032738
	for <binutils@sources.redhat.com>; Thu, 24 Feb 2005 16:05:24 -0500
Received: from firetop.home (vpn50-46.rdu.redhat.com [172.16.50.46])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1OL5JK02161;
	Thu, 24 Feb 2005 16:05:19 -0500
Received: from rsandifo by firetop.home with local (Exim 4.34)
	id 1D4QAg-0000zJ-3o; Thu, 24 Feb 2005 21:05:18 +0000
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: binutils@sources.redhat.com
Subject: Re: [patch] MIPS: Fix synthesized doubleword transfers (ping)
References: <Pine.LNX.4.61L.0502242001360.23589@blysk.ds.pg.gda.pl>
From: Richard Sandiford <rsandifo@redhat.com>
Date: Thu, 24 Feb 2005 22:57:00 -0000
In-Reply-To: <Pine.LNX.4.61L.0502242001360.23589@blysk.ds.pg.gda.pl> (Maciej
 W. Rozycki's message of "Thu, 24 Feb 2005 20:04:46 +0000 (GMT)")
Message-ID: <87sm3lhdo1.fsf@firetop.home>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-02/txt/msg00622.txt.bz2

"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> 	* config/tc-mips.c (macro): Avoid a reloc overflow for word 
> 	memory transfers in expansions of the "li.d", "l.d", "s.d", "ld" 
> 	and "sd" macros.

Don't these instructions require doubleword-aligned addresses?
If so, I don't see the problem.  The relocs for "sym+offset"
should always be sorted as:

        HI16 sym        (in-place addend of %hi(offset))
        LO16 sym        (in-place addend of %lo(offset))
        LO16 sym        (in-place addend of %lo(offset+4))

and the linker will do the right thing.

I suppose bad things could happen if you composed an aligned
address from an unaligned symbol and an unaligned offset,
but is that allowed?

Richard