From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 03C15384770C for ; Thu, 18 Apr 2024 13:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03C15384770C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 03C15384770C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713445587; cv=pass; b=k89/aJ9UOrwYbPeZK0onzIMAv61mwkTtlFbi6F2u0RtXMTsYYOfamigIfYpRauI7KLGvSNcq4FENYE7rPdZYuTX2X8tVAjaKJpxtfGfr1fEqqCjApb3800040P8dv6sBkg2STiviicPZlxhfsB6vt+H0pbzWdj2qYXyq9gzPseQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713445587; c=relaxed/simple; bh=3WN6jiHTojBLrY3IxWXtqHj65ZmjOHw/+AMMRyo78I8=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=GjzpNkXS0RMQ30h6JGELVMw2pJuZe41Z4NMCtwMx2c1IE/zGAXprDvSVDxLNmFDmjQ5vAjW+CsEml0uffuwPkHIh4g8f2vF3uBZn2INEmwe2spi6/nYgXGLG+4bfWuUuUnQR/u4glilPLGW+z2Wz8G6iMuI6XmM9QUFh3vMlMeI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43ICJ0P1015200; Thu, 18 Apr 2024 13:06:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-11-20; bh=7KKTj3PjqY0RY06++ukNAMp2Yd3P5pCB976jVdH7yNU=; b=ZXE3KvTEsUWx8Dj8VUcVqj7cryD2TzqBXHGYaZDfkvrQyTVSZNuq3ZyYOIFwSrTIsLnv nry27tdFT9EB0NauBb1P1G1ZobSABQJSHgoCDlEUnuYQ2YpckFwL/hN5bUHiLTW1rXWU VShDtTlI6BaQRj7wiCHkNSu2nm9DBBDf40krBsIDRAfCH0A5HfuHHN0NDdavVwhKgxGU fGbPOXQ2qDoMzL2vUe/6uTwkItmPt6qgDbaVh4fyDu81BKQGRZBw+RtMaib+TNqxJqr5 /BF4BUl82tFLUr2rX+fn1tGRItGv4orgUgzKn60tRIqAFAYYOtJIOnm8KdpHNOX5cKt9 SQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfhnujeh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 13:06:15 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43ICeQRi021628; Thu, 18 Apr 2024 13:06:14 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2041.outbound.protection.outlook.com [104.47.74.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfgggnw9f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 13:06:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KbaKxsWzKuQg6mCqvjU2NqJoWNXGaD9aLQph30Pjt43QC6pCdXDDj70iE/HOh+pvbUAsA3ZOfyYXCbJFfBxkI08hqbWFPzFT7ISzLJqm9B2GCMSLRmSY0oeGjevuASfrtFd0YJU8FkjDCVmbDnfqeEquJerktkKugA28nTdxfbXXteEvgrAt4bga7Ftcfo0X2KemJFqfuXWWV8ALF2XaDHQ86yrvJ1nNf5Q8AOkcOvkRmTwIHxXumLuFm+x6x+6nL5p70i760UiA1yc1FydH51vGEiHTqiJre3W6fpvoiw+qfCDnaxaI4VWLXmtgYyX/p4mR2X6TF+8HKPUYJxUGJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7KKTj3PjqY0RY06++ukNAMp2Yd3P5pCB976jVdH7yNU=; b=V9LlSnnnqDvOjrAgciEEhsEqTjsuWZFRURzc5O0v/JGVHRyaUz9gbndHA83HZ++PwprHKISxgLI/Mi+c8MWs4eEBJFvGaSaX1T5/fgvRfm82R2U/eiOqaffcAx9yGLIcg76E1qg5MnfDHD73nOMGAmkRbIDkLfC7aisw/IzWPPF0hVZHFkEHQJu91LXeD4PoqnHIJYU0DiZxW+cgDA/fuut1yHrgh+lj4HFq49+y82AXRj6AqFgOGNP6l7MnDsgGy/FCV2SCq9EKvuZ4AxoY5Ak9YTe5A70WPV8lW8dtxR8oft0wwA3//vU8YmPXeCmutz3X5PPgOFMoKf+G4vPkHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7KKTj3PjqY0RY06++ukNAMp2Yd3P5pCB976jVdH7yNU=; b=cnAJ7oSIkN0qAfcJCUOiynrtMF06JvoMECKwUG7jxX0NQ7qG++krEo7S/tRKYgHGHSV3c01I+bXkH893+ZJ3sPffg6BBN9x1gkjAOAX7vGxyLz/KNwnWWSOec78/JY/GrWuMQSKq0RsoubuYF+PUialoMAjmdRzayLwEcqFr0Eo= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by BLAPR10MB5107.namprd10.prod.outlook.com (2603:10b6:208:324::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.41; Thu, 18 Apr 2024 13:06:12 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7472.037; Thu, 18 Apr 2024 13:06:12 +0000 From: Nick Alcock To: Alan Modra Cc: binutils@sourceware.org Subject: Re: [PATCH 01/22] binutils, objdump: Add --ctf-parent-section References: <20240417202018.34966-1-nick.alcock@oracle.com> <20240417202018.34966-2-nick.alcock@oracle.com> Emacs: if it payed rent for disk space, you'd be rich. Date: Thu, 18 Apr 2024 14:06:09 +0100 In-Reply-To: (Alan Modra's message of "Thu, 18 Apr 2024 11:35:07 +0930") Message-ID: <87ttjyvn0e.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0252.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::24) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|BLAPR10MB5107:EE_ X-MS-Office365-Filtering-Correlation-Id: 366dc5a4-72ed-4450-52d4-08dc5fa8528b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vmJnuYtRMhS4X0vHK5fO5rrlPzeBZp3UJ/ENFtkSlRYczBy3ycJbBeVy084K2wCh7Cotqw8wtcGSRya0uJnN/BiPPOwqomP8kxdITG6QcWdm6jEQpdqrsDWQ73aqsKGQZ22m+kH7wQVF1OIdu5ZI4JgAosjM17CGBC1ev6wdwOeJ1uUglotW3yQWUe/uplCTVbgp47JD9WrtXmlNA6O47VY719ykjkBJG0Dbf3kfS6ON33KaXMJsxxz8enOykyLzt5WPAt9ByM/RPaAQvKKdsGnqDMPWLzT+OsWsoFZEB7RkheBe42KqKOaWXLsowXdOyb6eOqic9uWlDklr/8OsZt+8JBcAdQHCKmLa1OgDbJ5QhJ1eDxVoIDZU+fTVUAMZR2xvzS0g084aM/tQW4IMrype1LkaqOYNHgCVRnaqTCnyJIJbQ2axhP+M2aNdoDSU8REeyM9GNwUcA7FpYLfhIWey21LO4PnrY7NlUsc6uQYj6NEhgiDfih+3nuZSsNXnn4URvlR90MLaQOlxfwqFQqe2aRgEs2R1ookDtFa2UyoNxBILfk5rolm8Eg4G19aeQ0wAMmTz0t9OP863sKkKxPSX8x0yZjQiBMGQ4kqGiWDlUTKwAROCUAWFOIR1/g1T6Fq7exlmFCbP6eWXAGZ8rxEwWJ3r0TjaHR/AIAVrEe0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR10MB6608.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lzcFDcZmj3iZ96qx25Qtzidcx94ysU1tElbsRRRNLEZgSAfBqxSK3eMXFUiv?= =?us-ascii?Q?UvRRTVje8kIhNNpRejME2JVf8nmdXc1otPbATbRlNVCAs7BpxEUL2QIOeiZ5?= =?us-ascii?Q?Iw041/f9ROPUgt6ITYUqgFIaRvUUX1KGHlhZbzTyJeJHQ23tMKJT1aTVt+FH?= =?us-ascii?Q?+oO9VYoi0IYO9mJMu2hA5HILEpS4aGwmYlGQ9w546xrwzfwePXSKJtbfhHjd?= =?us-ascii?Q?W0vOehbon4YppusGEiVFsM5udW5tqtFnBiDB0Dp4D/x0cwBQ3xfXb5n+yKA3?= =?us-ascii?Q?CBuLwiM6RPuve8y03uqjwIFphFb2Fz4Bp3PTMZoOOZVmk+yoMoprDeFNgscK?= =?us-ascii?Q?5MkdZ1ou47kvU3c0hkuE/bxQb0Cysvf/AxVPSHJYN0VEalxu6KBloZG0omYB?= =?us-ascii?Q?twA0K7BIAH3NpW9tyXZA+MpKXeod7B7CBzSLaSGwq/XKoJ0jnyVA81i+r3S/?= =?us-ascii?Q?e5lyM3KbVwjRoERaJJfNn4xFKRN7XPzPlhypkjd5a82WMTwgravVTViRYaEQ?= =?us-ascii?Q?/MkbJpqGD26DYYXNVbQKwrBOmWwFpACr0WuCkfx5yjImP7M5Ym95aGd4KQuT?= =?us-ascii?Q?NCU60mw75kJc6X6TueYxi4ph9UtXU/MJOsP4LMjtATM8GXosOTd6qCaKHli+?= =?us-ascii?Q?kXuorOsD7T0InBxD4S6qUhg01O9Zu/lu6OLhy6CHmvbw3OEN38eOsyTht7rn?= =?us-ascii?Q?+++12WHUyldXSQhUuu8JhqwQbTIRsx5ROyl2nJkxhAbQb1yqNKpTtP32YLZW?= =?us-ascii?Q?xAJDaAJpzguGt6C+6CEZuQ/6VUPakxeqh77pF8wLJu9gARA79BDyL4Eh2TML?= =?us-ascii?Q?CKRP/ck12QWaDrqO5k44jcQxNPCjgAm99ib+d2Ut8TBHyWfHW5VWasm7rp+i?= =?us-ascii?Q?5waS9dZHjo962Wwtdfj8Hb/F1uV87viSiNsI8PUnWMuQ76cEVnG52zh64ynl?= =?us-ascii?Q?EFdK8PvSwC1Gve+C1mJhhJ7pe3ECrhHkRZ+fIs1eF/zr/G5/1NUr2t1SY2fm?= =?us-ascii?Q?dlVK7AMs64tAdkPjXvivhj++0+9ldpEcZQQrHxeRgYh67lYjY2j3AslJ+lYm?= =?us-ascii?Q?C2KuUj8BFfcLzmYllPNMhBBLBqjNUBtqH9n2s5nUw5+QeOJFvM/ybgCkf6+9?= =?us-ascii?Q?98NRj1JbOBMVWUHq9j3fvxd+ewlVZ0wP/gmFojyzopn1W6XVFt+jp6Wh0BP1?= =?us-ascii?Q?J7w483VW2q4awK3E7Fs2pMY63iExMG4kI7y72UShfb3Z+/VxFcD2LfTH4R9g?= =?us-ascii?Q?FLhGst7rATMcKESD7SPNk9I9o/fXYFo1WDrWk+msc4aCalW9n9tD3WyzTHdU?= =?us-ascii?Q?K0fLWo2Gnsqs3x3IcOHpvrAg5H06L/ZR7w8QDGqsgNCM/txy6ILcafhxxs+2?= =?us-ascii?Q?oVbw76x7rsdMqlxcEe7zC0Z+tXM76W2F58JrBFSxCT4fzZi6+Cx6VXXxNjrv?= =?us-ascii?Q?9SW1vJRzD2ryrSuMcM2dsB23aqiJq0Uct4CWYdCYRs/ER1mcX22ZtQE1W4w5?= =?us-ascii?Q?vrEu8FFadLaUUXtmBT4oKzyCoOnma1LC4zxoVBGYh/hUFnL07nIk7QYp0VY0?= =?us-ascii?Q?Mw36faZYnI8W+/VhmOkAeVN8CLb7mx7ZlCHfNJHmja66XIbq7/FVTMQrNHVz?= =?us-ascii?Q?tg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lbqlZkEIQCsw5zuuuR0gpU/IuNH2rXK1Gkoc4F/vBgSz6/4D5jLoefiXhb1CWYFgRMxKvl8AlliNJswZKFRYvaSR6hE4cLRWe0aJx6MDs7PdTHlvAOFwecZx7Za0EHllrUzMIkfJSYN9cMWyEmhgVg3kqZFxXWU7jaqsD6fXsq/fvknwI4MF2dSPU4BkcevoR675oNXXSibnlv4bQnLSYqVnZRzRlF4P3dVleLgCpkLCcAM050mmdZT4s3cmXuOmVbT9Etjb6fijcjKmbgNNhhX78/EPgQPq0q9LECWefN8H0HpgPnrk8WGnQkSJJZCv8WBfSCCNkRkgJuVuFbeUnrtIMFLNCrZf+NaYULWqJCJ3+dC2hihvCwMUYhdYzB8YMe1ARueukHeMhNTNM4C6iem9k+CrLJnIQZDDwnq9fIQhQ3g+uJN3GqY5vw5JdfgBIef9fGyWZgJoqk/8vZLUGedzt8cvUugvIkokFYEm5YveSOSXFbZQWYGIZjPz/PwXAPqSrMZaIENnOTqZijmfcJYqX42HX3h9YiZTvI2kry+dMtSvdA1atu3P0RIjWjz4yZ/vZf3/WxfxTw0kK+Ub6zkHyb0jAxwBI3fWXw9+PfQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 366dc5a4-72ed-4450-52d4-08dc5fa8528b X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 13:06:12.4704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vASA0NlCDKIJWsEae/a3zYfBd7TG7JHXuKtQDz77ATXuJwpgEvV5LHH5IChSoE+AhStKB1TaMSQzTm5W08BoAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5107 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_11,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180093 X-Proofpoint-GUID: TDXUUacyj2nw5fupOUFuRwg6LB3GGU38 X-Proofpoint-ORIG-GUID: TDXUUacyj2nw5fupOUFuRwg6LB3GGU38 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18 Apr 2024, Alan Modra said: > On Wed, Apr 17, 2024 at 09:19:57PM +0100, Nick Alcock wrote: >> @@ -4890,13 +4897,36 @@ dump_ctf (bfd *abfd, const char *sect_name, const char *parent_name) >> return; >> } >> >> - if ((parent = ctf_dict_open (ctfa, parent_name, &err)) == NULL) >> + if (parent_sect_name) { >> + psec = read_section (abfd, parent_sect_name, &ctfpdata); >> + if (sec == NULL) { >> + my_bfd_nonfatal (bfd_get_filename (abfd)); >> + free (ctfdata); >> + return; >> + } > > Formatting, here and elsewhere in this patch. Open braces go on a > line by themselves. AUGH. Apologies, will audit the whole series for this: I see several others just from a quick grep (and a few leading space/tab problems too, despite my having hooks trying to spot them). Doing simultaneous development in OTBS and GNU-style codebases means I make these sorts of mistakes *all the time* :/ and cc-mode, even with electric newlines, doesn't always fix them for me. > Patch is OK with these all fixed. Thanks! -- NULL && (void)