From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 0D88B3858408 for ; Tue, 17 Oct 2023 15:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D88B3858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D88B3858408 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697555722; cv=pass; b=gjXJggzbm/gGuxX2iQuoEqnQOsO1YzCmd7+axS8z89RtPpJ9K8/qNYjVtZ3awjvCDhXV30m6Zb55oZnCJ7TBdC9aKOwJM7Ok9fzgp9lAxvsoaUswj0rEZEsB9FfSJEP7BWmp2vXtwySpKrKQc/Y5/nw1Pa4xkO3rOsXbZ3p7KyA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697555722; c=relaxed/simple; bh=RnBdUuAM1THAe4TpHN9PwraxP/sItl2p7QXjK1yPrRw=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=e4EbWzARROkFTORh2rBcPyNeBFgcdg903mH1v+FsIpbURlCCiRVtE9WAyCW3jshWzTi7KAfAncc5QXHds+Z+BPdc+d+XVk8oNeJNSd2x6c1GFu701DmEmmxwj8nfKOAODYvLb0pkJe2c+b8fM88qerVr/JM5KFXLwxDLIlzrLkA= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39HF4RLY027620; Tue, 17 Oct 2023 15:15:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=CLsrZ0XZX/vBk6/Ud/dfwwd5W78l162AY1JK/kmCSlI=; b=IWmvRacVvh1ePfUmMq8p04t55MAgto77/ugairrLIZMelFZtL2zQa6MHm7m0XYKpLOPS iT9hAVJVIPnxt9aNhV08gpbDPQNSMFOXnPW0hoNOFzSVlHeLq7QW4GzI5fka2IpB/fFZ 4Z5sEDXVu/5mXI1PrPtVxhknGGhLgJuTzjCmYKUR1q5mnW5z9Y0skWJxIPCiFaMEcl6T B7OdS/9M46DofdY8oevZRKiHgq2VP592PspTpLZE2xlBqJ+fMtKgM3liaJ90h7HuDtWv RHcKIVbrDu93KS15fwoUj/Oe2Ph9tZEM/4CCUm4AHihGYZgVpFRIplQsZ3AqbVBnKxq5 Dg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tqkhu5f87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 15:15:14 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39HEXxlY021694; Tue, 17 Oct 2023 15:15:13 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3trg515v4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 15:15:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZK9cGUKyS8/ckMYckYZOk4hg9iBngAOWvM8Lt7TsfhESPUfrMJMkLU6tx9abWwfXQ9xAmedMmP264AzwunPxttEWuN6i7wEqMPiQi7DrGI6LJw6oGXMIerQaJZfC3IojgjeAWLwTcX7tsoxbsfRYMZQ843K7DCtbol3Sp0mrsCjLw5js2Ls1Q1HYdGycHvtoyP2qzESc5viqjytlbtEYENMqPbkzR9SajSQ4Nu6NJ/Lzv1gcCvlEls/tktTZ/CR+GbwLVSz1l7xlZGnv/l6anG65NzmNqu6VCRhUWaO+5iJ1RZEojbV8HjYtT4N55gve1bQ28ajW1Ht7SI4WeHdIFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLsrZ0XZX/vBk6/Ud/dfwwd5W78l162AY1JK/kmCSlI=; b=nkil16/zxSdPNcEDjSMJRvtO5RY9/GZNNyGC/5W/pVJsdW9ebSSRhsU9J8Iv4nLDu2yagJI7DE7eYyvKTR38lC9TZjCUzfLmlfiFAZlBcSg0TgomnjZAyKQ9csuVnLoKd6qKGATtfplqqcYOxRMuvuuG5C4lxfqx9jtOvdpWiWtYQJnBXAa8/i2GGMBlxmwz5TZvkosY6fmrP6d7Y0CtEL4CVAQzx0zbB22P0zQWPiARlu7u63iDpS+0xmd5beVdwmE3b1mtIJWe/PcITCsra1qN3Djq0XPnjRnkAplz0f9VzKjQgkLwf2Qu7kc1QkMhVZIvlMXfgCWYkeuloqgZmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CLsrZ0XZX/vBk6/Ud/dfwwd5W78l162AY1JK/kmCSlI=; b=ii6JS5eyUrHhxVJPQKlrqQvn2C0Zo/ul0ZyCY9MzSZHbmDUdxCEZzXdRDKUv4Xv3AM32FlyD79H+DGkDECXkNcAir4ziHDOMFjRQaKbSqxBXrt6sfAJr2AcLp9WonqE4Lo93cee/RDRh3MJCX3LgK9TZ8iYdOlRQXFOjTJ0ylb0= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by SA1PR10MB7814.namprd10.prod.outlook.com (2603:10b6:806:3a7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Tue, 17 Oct 2023 15:15:11 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::19ff:c8cb:d04d:8b5a]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::19ff:c8cb:d04d:8b5a%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 15:15:11 +0000 From: Nick Alcock To: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON Cc: , , , Yvan ROUX Subject: Re: [PATCH v8] libctf: Sanitize error types for PR 30836 References: <87ttqrae3o.fsf@esperi.org.uk> <20231016125059.1798219-1-torbjorn.svensson@foss.st.com> Emacs: because Hell was full. Date: Tue, 17 Oct 2023 16:15:07 +0100 In-Reply-To: <20231016125059.1798219-1-torbjorn.svensson@foss.st.com> (=?utf-8?Q?=22Torbj=C3=B6rn?= SVENSSON"'s message of "Mon, 16 Oct 2023 14:51:00 +0200") Message-ID: <87ttqp8emc.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::13) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|SA1PR10MB7814:EE_ X-MS-Office365-Filtering-Correlation-Id: a8cc263a-ffa2-40a9-91b5-08dbcf23db56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NRi1+8vN8OB333IDGwZb2iS+g8TF/JG5vEYOiswfLURJ42CAE8QGSNChaR9j0AYjM/b/aOeYKUOMU6JOXFLGQOHtTIFmgindz4E2+jcS4H765uT+gBrWndUfFiMf/ggKpVdGOZb0Ebuxt1NWtjAtYrgYeX+rgxfqIeF7vBexqjMdeHGNzSqUidykzvYQsBOReEAagH4U1KScE6CT+NxAzG5bdef1tb9W9RD15yFc13KdvXqvP6D2i6exuIfUgD1Y5w/EUoEMLGKFZ3JM1LDHcQye2uskI2y218y3+kcv8CgSrK21B1e9VupKRfc9RtDXf52fuHBmqGMkU13wouydNjczcp55uPs2Bbxlfq5b+QPI5tQDf1QA4z3zbwCMIQHWap8FHftFC44RqDUyDok0T8XJiL+GVkGXx3nKWAhDBgq3cR4rf28NpebnjPcxuJ//4fMGLpVgtm6KbFPK3oOdq3vxKuFL8gcWdJQd9rHr512+tYpzhtHbe9q8Bo1cpCA1EOilRR48xuDFAGfYQry/S9E/Wc1DibUgVW89kjby6y+jBwu33Gix6RsP5jbLXeIs X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(136003)(376002)(346002)(366004)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(478600001)(6916009)(316002)(66946007)(41300700001)(54906003)(66556008)(66476007)(4326008)(8936002)(6486002)(8676002)(44832011)(5660300002)(6506007)(38100700002)(86362001)(6512007)(9686003)(36756003)(2906002)(6666004)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzNnL3BwUzRBeEhJRG12elpGVDlLUVYveDBRa2VoSitBUFpyRXcvdHcvVysw?= =?utf-8?B?R0FnSXZ4L2xCZ0ZOSGVBWDFsSkVsSUd6djBqVkJQSWorYlp1WW1OakI3RGxX?= =?utf-8?B?a3IrMDUvcVA3WWVPNXhDZDJvUkdiR1d0dWlucmR5THpxc0RkRklyY08wWlpI?= =?utf-8?B?dm9JRkZzQ2kyVVlPUjkwUGtnZHRGc1RCNW5xK1llRWw4VHlnS28zcnVaWVAz?= =?utf-8?B?WnNFOTRrRXNmZWNPeUNRSjFXTkpkNG84cDU2MmdXTVZFanRmekVoMVg5ZVdC?= =?utf-8?B?VHZxWHJudkNXcE9sMy9VOXhlbCtiYmhvRCtyei9vRWR2bzg2NjFWNG1iTFJq?= =?utf-8?B?bHgrWUsyMUt3NEZLcFBFeUx0L3MzZy9ycTJoRTROMGMwSXVvZEpqbUhnZEdW?= =?utf-8?B?Y1F4aUkzVkU2TnZwQ2VCMzVneXFxSnFOd1Rtbmd1QVdZZExvZnJvekprY1k4?= =?utf-8?B?bU9IYkNsL21FQVA1VGJTei85RXpBend0dlhCOVd2azdIdnNLeDNaaVU1RHgr?= =?utf-8?B?QURMMWkzUWkwSHJsVmhkSHBaUEJJNnZWS0xJZ3UwQmVENWIyNWl4MzJKclRP?= =?utf-8?B?TlBPOG9WZVNNS0ZxMUxlNG9lSHpGMTFwSkl2a3dYU0pmMXF4c3lZSE5qUkVt?= =?utf-8?B?TEF6OUdxb3ZDa0tZSW1LOUV6dEVsNEZqM1dFWjNTbUR5eXA3b3NqMVEzVGl2?= =?utf-8?B?SUI0UHZrSThIby9PcUdlcWlhNkIwa0xPNk1qQ2lpenYwQmxzVDZ1SVFyeERI?= =?utf-8?B?WUFVWkI1TjcvWUQ3cFNkblh6K0JFaGcybmVLeFEvWGJsUVQwc0NuNWptaXE2?= =?utf-8?B?cTlEUGg0SmwvdFkxM3FGcU9QSHFpVkVtZFpVU0Q5VGMvQUxCSUtYVG12Mmpz?= =?utf-8?B?YlJlZ0luQ3pCb0huMW9aUG15MTJXelRDUXk3Nk5nd3dlY0hWejVaVVdMSlVi?= =?utf-8?B?Z0dvK0oyTERHQWJKY1Zmc3NwNjEwYTdBem8wSm5mcENzMzhQWVh6YWtrSWpV?= =?utf-8?B?d1lGbjc0WlJ5RGlubytOYzlPczQxSXFzQWtvaGNNZGNIZWJiQ3RQV09mU3Mw?= =?utf-8?B?eDB3Z3YwTnhnTk14N0wvNkZPNFdUK2JxVFhEZUpmRURvSzBlQmRnOFlLcWJC?= =?utf-8?B?cmZkUUxVR1EreEthNVdhc3R5R1FscXBmQmFsOE5zRUthb2VRWDMzQXQ1cGJ5?= =?utf-8?B?Z2huMG9CZDJVK1lidHVLMTcvY010dFhMNG0wUFVtR3VMSW52V3dycWpPYms3?= =?utf-8?B?RnljeVpOZHdOZ0k1RlYwbWo0SUNORm9kM3B3TU9BN1Z6NHdPb1FQTWtYY2JU?= =?utf-8?B?Q29PTlpmQ1NwcWIyYjNtTmNxUXZZYzZXQldEOEk5Zml2MGVRd3NkYXRpZFpv?= =?utf-8?B?ZkUzMWd5ZTRnUzBSSVRYeXQycWdiNWEvNGwvN0FYb2IxenMyV2hGWGFHVUtY?= =?utf-8?B?YTJyMmpWaDRHb2tGNS9VUnpBRWZUdlYrMXdhMUNWR1Yxd3BOb01SRHFsa0th?= =?utf-8?B?MDB3U1BrdUZMcGNvVTRaRElBa21KMkh6SGVMRjRjQi91a2FDemtnV0pUaXll?= =?utf-8?B?RVNOeUpzamh1bExWTS9jYjAwTHdpSllNY0NmS1lHZzA4NWN0WWVMbEtlWE5y?= =?utf-8?B?WGViWXF4OFFnNm9HUGZFblczOWx6bHVpQW9mc2JvUFhXWDRVSnFwTG8rS2Yv?= =?utf-8?B?M1BjWjBRNFo4WERxOEZIbFNLSVF0czVsUVNIUndVUlVObWlBZjlwaVNXbEt1?= =?utf-8?B?Q3ZyQTRtdFBTSXRvaTdPRWxpZmdKekFWbmkvYjZkSzhmU3VXeVlCSjFNaW9S?= =?utf-8?B?NHE5dEhJQ0dTdERZSnBiSXFPQVN1TEVUYmtVdGt5aktBaDBCbU1TaFNRY1BM?= =?utf-8?B?TVoxK1lGRUVFdXlhdGR2UFVyREVtV29RbXdpdlo3ODFtNjZYSHFnNXpaQ0hz?= =?utf-8?B?UjlJZmM0bHZGeUFhV1ZLV0ZIM1IzMytxbHZ2aSsxa1pyTnFoeTRuRXMyc0pM?= =?utf-8?B?QXROczdmOEtIQzN1bjZmenFGKzl1WkdpVzFUTGRZbE9uTUc0UUR6YWFrcXJm?= =?utf-8?B?UDk1TEhQRUNJZmYvaHhxZS92T2VURmY3dytLbitUZGZhZHZWYURiQkRkdE9B?= =?utf-8?B?VXJTSWtqb1pqazNtVWZzckRodUZNMUZLSW1qN1V2RTFSUmZZeW1UNnhHU1ZH?= =?utf-8?B?dlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: JruAn+eo24no41BhjkZYnwOTPBB2zD6YuqOYdvO1irF1MTiLhWk0meXPmhWNtr8Z448ZkJRKVcjOb4NfG7DbYbQiJibEVwh9N5TjfMJsqucmdPo1YvkS3dZyeatQhtDGczM1FWXVKgy58CKebWoRJFg6+RqjT+TYX92yZ+GmxUMUU5EPFbb/tZcxjKQaDfuNV0OtBWSbtmbxBdWhm1JkwR+nw3usKpAqwbGCZ905TYYue0IXWrE3uho/NBXi/HpWAXG02OkdKhUKvXPzr5gDQJbpTrhVTrNoQ4uSANxT4N/E50s4SQladP2QY36fjtpuDt9PC/xboQ4A+I+dMKGwSWW8a5Dm1NY5Jazm4AKrmY2tBBqIqB72yE6UyBJPG4Nj2AkH27fM7jc+2HJyx+mEwTRC0nATLuIup0PmnwO0I7t/MX0NMcDXBce7ajrHsuyK5XnrLr1cIeBnJm+hlOx4FE4k6QHLfUjiO5qN+Jm/qaD//H4mnTKeod2axzPnSh4MKYl4Bibj2EAbRMnX0KDtR4s+OsoqHZGBTY5/Nn7fb4bMMHkf8UNl0LPoYjMffOT52xWU8hIG2Uk8xFGcjnLC6WF5hTaZka0PJ6iGtMdXk6EVSzNJ0unVvxZ0Bby8iCbTFcI2mO9gfOc4EY/nRoAsTS86T9ResBBM+PTQdy/plHllUEbOcTk/iAmuij+koJNPoFRv7Rsvwzg6d824IyxVQTStNbkp8vz7/4SdZ2AV8KTwKN27Pk/11CGdVQHBBm+fhPQqlVGGffPxcdz3nBYCttTZFrvt9uqRWvOMg4KzY54yMm+TyagHuDX9QG7fq9GC X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8cc263a-ffa2-40a9-91b5-08dbcf23db56 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 15:15:11.4903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YBJ2l2NnXmf4Ja5sfue2wWnfzr8/EWvhI9rcCow7PmftoSnGRmrzlDNGq+vhDsbjcIjHLyDL8dzyGQWrRPokwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7814 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-17_03,2023-10-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=859 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310170129 X-Proofpoint-GUID: e5Ntavzhdu5LW2PhZjnSwtFLTi4TTw-Q X-Proofpoint-ORIG-GUID: e5Ntavzhdu5LW2PhZjnSwtFLTi4TTw-Q X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16 Oct 2023, Torbj=C3=B6rn SVENSSON told this: > Made sure there is no implicit conversion between signed and unsigned > return value for functions setting the ctf_errno value. > An example of the problem is that in ctf_member_next, the "offset" value > is either 0L or (ctf_id_t)-1L, but it should have been 0L or -1L. > The issue was discovered while building a 64 bit ld binary to be > executed on the Windows platform. > Example object file that demonstrates the issue is attached in the PR. > > libctf/ > Affected functions adjusted. > > Signed-off-by: Torbj=C3=B6rn SVENSSON > Co-Authored-By: Yvan ROUX Looks good to me! I'll push my test for this after your fix goes in. --=20 NULL && (void)