From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114670 invoked by alias); 23 Apr 2016 17:54:23 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 114659 invoked by uid 89); 23 Apr 2016 17:54:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=senthil_kumar.selvaraj@atmel.com, senthil_kumarselvarajatmelcom, H*r:0200, slew X-HELO: eusmtp01.atmel.com Received: from eusmtp01.atmel.com (HELO eusmtp01.atmel.com) (212.144.249.242) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 23 Apr 2016 17:54:10 +0000 Received: from HNOCHT02.corp.atmel.com (10.161.30.162) by eusmtp01.atmel.com (10.161.101.30) with Microsoft SMTP Server (TLS) id 14.3.235.1; Sat, 23 Apr 2016 19:53:58 +0200 Received: from jaguar.atmel.com (10.161.30.18) by HNOCHT02.corp.atmel.com (10.161.30.162) with Microsoft SMTP Server (TLS) id 14.3.235.1; Sat, 23 Apr 2016 19:54:05 +0200 User-agent: mu4e 0.9.17; emacs 24.5.1 From: Senthil Kumar Selvaraj To: Binutils CC: Denis Chertykov , Nick Clifton Subject: {Patch] }Treat avr as elf target in nm.exp Message-ID: <87twisjjqk.fsf@atmel.com> Date: Sat, 23 Apr 2016 17:54:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00395.txt.bz2 Hi, This patch adds avr to the list of ELF targets in nm.exp - without this, the nm --size-sort test fails for the AVR target, as it uses nm-1.s as the source file, instead of nm-elf-1.s (which has the .size directive to set symbol size). I tried adding avr-unknown-none to is_elf_format itself, but that causes a lot of failures in gas and LD, just as the comment says :) I intend to follow up on those failures as well, but until then, this patch lets the specific testcase pass. Regards Senthil binutils/testsuite/ChangeLog 2016-04-23 Senthil Kumar Selvaraj * binutils-all/nm.exp: Add avr to elf target list. diff --git a/binutils/testsuite/binutils-all/nm.exp b/binutils/testsuite/binutils-all/nm.exp index 94f7f9c..34454f8 100644 --- a/binutils/testsuite/binutils-all/nm.exp +++ b/binutils/testsuite/binutils-all/nm.exp @@ -163,6 +163,7 @@ if [regexp $want $got] then { # all the ELF variants, but adding the patterns here to that proc then # introduces a whole slew of new regressions in the GAS and LD testsuites. if { [is_elf_format] + || [istarget avr-unknown-none] || [istarget *-*-dragonfly*] || [istarget *-*-*elf] || [istarget *-*-freebsd*]